mirror of
https://github.com/php/php-src.git
synced 2026-04-23 16:08:35 +02:00
Peter Kokot
d679f02295
This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
70 lines
1.7 KiB
PHP
70 lines
1.7 KiB
PHP
--TEST--
|
|
Bug #64438 proc_open hangs with stdin/out with 4097+ bytes
|
|
--FILE--
|
|
<?php
|
|
|
|
error_reporting(E_ALL);
|
|
|
|
if (substr(PHP_OS, 0, 3) == 'WIN') {
|
|
$cmd = PHP_BINARY . ' -n -r "fwrite(STDOUT, $in = file_get_contents(\'php://stdin\')); fwrite(STDERR, $in);"';
|
|
} else {
|
|
$cmd = PHP_BINARY . ' -n -r \'fwrite(STDOUT, $in = file_get_contents("php://stdin")); fwrite(STDERR, $in);\'';
|
|
}
|
|
$descriptors = array(array('pipe', 'r'), array('pipe', 'w'), array('pipe', 'w'));
|
|
$stdin = str_repeat('*', 4097);
|
|
|
|
$options = array_merge(array('suppress_errors' => true, 'bypass_shell' => false));
|
|
$process = proc_open($cmd, $descriptors, $pipes, getcwd(), array(), $options);
|
|
|
|
foreach ($pipes as $pipe) {
|
|
stream_set_blocking($pipe, false);
|
|
}
|
|
$writePipes = array($pipes[0]);
|
|
$stdinLen = strlen($stdin);
|
|
$stdinOffset = 0;
|
|
|
|
unset($pipes[0]);
|
|
|
|
while ($pipes || $writePipes) {
|
|
$r = $pipes;
|
|
$w = $writePipes;
|
|
$e = null;
|
|
$n = stream_select($r, $w, $e, 60);
|
|
|
|
if (false === $n) {
|
|
break;
|
|
} elseif ($n === 0) {
|
|
proc_terminate($process);
|
|
|
|
}
|
|
if ($w) {
|
|
$written = fwrite($writePipes[0], substr($stdin, $stdinOffset), 8192);
|
|
if (false !== $written) {
|
|
$stdinOffset += $written;
|
|
}
|
|
if ($stdinOffset >= $stdinLen) {
|
|
fclose($writePipes[0]);
|
|
$writePipes = null;
|
|
}
|
|
}
|
|
|
|
foreach ($r as $pipe) {
|
|
$type = array_search($pipe, $pipes);
|
|
$data = fread($pipe, 8192);
|
|
var_dump($data);
|
|
if (false === $data || feof($pipe)) {
|
|
fclose($pipe);
|
|
unset($pipes[$type]);
|
|
}
|
|
}
|
|
}
|
|
|
|
?>
|
|
===DONE===
|
|
--EXPECTF--
|
|
string(4097) "%s"
|
|
string(4097) "%s"
|
|
string(0) ""
|
|
string(0) ""
|
|
===DONE===
|