mirror of
https://github.com/php/php-src.git
synced 2026-04-22 23:48:14 +02:00
Peter Kokot
d679f02295
This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
45 lines
1.2 KiB
PHP
45 lines
1.2 KiB
PHP
--TEST--
|
|
proc_open with PTY closes incorrect file descriptor
|
|
--SKIPIF--
|
|
<?php
|
|
|
|
$code = <<< 'EOC'
|
|
<?php
|
|
$descriptors = array(array("pty"), array("pty"), array("pty"), array("pipe", "w"));
|
|
$pipes = array();
|
|
$process = proc_open('echo "foo";', $descriptors, $pipes);
|
|
EOC;
|
|
|
|
$tmpFile = tempnam(sys_get_temp_dir(), "bug69442");
|
|
file_put_contents($tmpFile, $code);
|
|
|
|
exec($_SERVER['TEST_PHP_EXECUTABLE']." -d display_errors=1 -d error_reporting=E_ALL ".$tmpFile." 2>&1", $output);
|
|
$output = join("\n", $output);
|
|
unlink($tmpFile);
|
|
|
|
if (strstr($output, "pty pseudo terminal not supported on this system") !== false) {
|
|
die("skip PTY pseudo terminals are not supported");
|
|
}
|
|
--FILE--
|
|
<?php
|
|
$cmd = '(echo "foo" ; exit 42;) 3>/dev/null; code=$?; echo $code >&3; exit $code';
|
|
$descriptors = array(array("pty"), array("pty"), array("pty"), array("pipe", "w"));
|
|
$pipes = array();
|
|
|
|
$process = proc_open($cmd, $descriptors, $pipes);
|
|
|
|
foreach ($pipes as $type => $pipe) {
|
|
$data = fread($pipe, 999);
|
|
echo 'type ' . $type . ' ';
|
|
var_dump($data);
|
|
fclose($pipe);
|
|
}
|
|
proc_close($process);
|
|
--EXPECT--
|
|
type 0 string(5) "foo
|
|
"
|
|
type 1 string(0) ""
|
|
type 2 string(0) ""
|
|
type 3 string(3) "42
|
|
"
|