mirror of
https://github.com/php/php-src.git
synced 2026-04-19 14:01:01 +02:00
9cbe1283f7
Before the fix for bug 48289 has been applied, the algorithm to construct a Q-encoded-word has been optimistic, i.e. try to encode as many bytes that *may* fit in the remaining space, calculate the actual length of the Q-encoded word, and if it's too long, try again with a reduced size. However, the fix for the mentioned bug replaced this by a pessimistic algorithm, which always terminates[1] the for loop[2] during the first iteration (which renders the following 3 lines as dead code), and as such easily produces unnecessarily short encoded-words. Instead the proper fix for the bug would have been to make sure that `out_size` is always decremented, if the space isn't sufficient for the encoded-word. [1] <https://github.com/php/php-src/blob/php-7.3.0beta3/ext/iconv/iconv.c#L1421> [2] <https://github.com/php/php-src/blob/php-7.3.0beta3/ext/iconv/iconv.c#L1360>
22 lines
579 B
PHP
22 lines
579 B
PHP
--TEST--
|
|
Bug #66828 (iconv_mime_encode Q-encoding longer than it should be)
|
|
--SKIPIF--
|
|
<?php
|
|
if (!extension_loaded('iconv')) die('skip iconv extension not available');
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
$preferences = array(
|
|
"input-charset" => "ISO-8859-1",
|
|
"output-charset" => "UTF-8",
|
|
"line-length" => 76,
|
|
"line-break-chars" => "\n",
|
|
"scheme" => "Q"
|
|
);
|
|
var_dump(iconv_mime_encode("Subject", "Test Test Test Test Test Test Test Test", $preferences));
|
|
?>
|
|
===DONE===
|
|
--EXPECT--
|
|
string(74) "Subject: =?UTF-8?Q?Test=20Test=20Test=20Test=20Test=20Test=20Test=20Test?="
|
|
===DONE===
|