mirror of
https://github.com/php/php-src.git
synced 2026-04-13 19:14:16 +02:00
d679f02295
This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
39 lines
1.0 KiB
PHP
39 lines
1.0 KiB
PHP
--TEST--
|
|
Testing null byte injection in imagejpeg
|
|
--CLEAN--
|
|
$tempdir = sys_get_temp_dir(). '/php-gdtest';
|
|
foreach (glob($tempdir . "/test*") as $file ) { unlink($file); }
|
|
rmdir($tempdir);
|
|
--SKIPIF--
|
|
<?php
|
|
if(!extension_loaded('gd')){ die('skip gd extension not available'); }
|
|
$support = gd_info();
|
|
if (!isset($support['JPEG Support']) || $support['JPEG Support'] === false) {
|
|
print 'skip jpeg support not available';
|
|
}
|
|
?>
|
|
--FILE--
|
|
<?php
|
|
$image = imagecreate(1,1);// 1px image
|
|
|
|
|
|
$tempdir = sys_get_temp_dir(). '/php-gdtest';
|
|
if (!file_exists($tempdir) && !is_dir($tempdir)) {
|
|
mkdir ($tempdir, 0777, true);
|
|
}
|
|
|
|
$userinput = "1\0"; // from post or get data
|
|
$temp = $tempdir. "/test" . $userinput .".tmp";
|
|
|
|
echo "\nimagejpeg TEST\n";
|
|
imagejpeg($image, $temp);
|
|
var_dump(file_exists($tempdir. "/test1"));
|
|
var_dump(file_exists($tempdir. "/test1.tmp"));
|
|
foreach (glob($tempdir . "/test*") as $file ) { unlink($file); }
|
|
--EXPECTF--
|
|
imagejpeg TEST
|
|
|
|
Warning: imagejpeg(): Invalid 2nd parameter, filename must not contain null bytes in %s on line %d
|
|
bool(false)
|
|
bool(false)
|