mirror of
https://github.com/php/php-src.git
synced 2026-03-30 04:02:19 +02:00
b746e69887
This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
60 lines
1.1 KiB
PHP
60 lines
1.1 KiB
PHP
--TEST--
|
|
Bug #60634 (Segmentation fault when trying to die() in SessionHandler::write()) - fatal error in write during exec
|
|
--INI--
|
|
session.save_path=
|
|
session.name=PHPSESSID
|
|
session.save_handler=files
|
|
--SKIPIF--
|
|
<?php include('skipif.inc'); ?>
|
|
--FILE--
|
|
<?php
|
|
|
|
ob_start();
|
|
|
|
function open($save_path, $session_name) {
|
|
return true;
|
|
}
|
|
|
|
function close() {
|
|
echo "close: goodbye cruel world\n";
|
|
return true;
|
|
}
|
|
|
|
function read($id) {
|
|
return '';
|
|
}
|
|
|
|
function write($id, $session_data) {
|
|
echo "write: goodbye cruel world\n";
|
|
undefined_function();
|
|
}
|
|
|
|
function destroy($id) {
|
|
return true;
|
|
}
|
|
|
|
function gc($maxlifetime) {
|
|
return true;
|
|
}
|
|
|
|
session_set_save_handler('open', 'close', 'read', 'write', 'destroy', 'gc');
|
|
session_start();
|
|
session_write_close();
|
|
echo "um, hi\n";
|
|
|
|
/*
|
|
FIXME: Something wrong. It should try to close after error, otherwise session
|
|
may keep "open" state.
|
|
*/
|
|
|
|
?>
|
|
--EXPECTF--
|
|
write: goodbye cruel world
|
|
|
|
Fatal error: Uncaught Error: Call to undefined function undefined_function() in %s:%d
|
|
Stack trace:
|
|
#0 [internal function]: write(%s, '')
|
|
#1 %s(%d): session_write_close()
|
|
#2 {main}
|
|
thrown in %s on line %d
|