mirror of
https://github.com/php/php-src.git
synced 2026-03-24 16:22:37 +01:00
6173a9a109
The aim of this PR is twofold:
- Reduce the number of highly similar TMP|VAR handlers
- Avoid ZVAL_DEREF in most of these cases
This is achieved by guaranteeing that all zend_compile_expr() calls, as well as
all other compile calls with BP_VAR_{R,IS}, will result in a TMP variable. This
implies that the result will not contain an IS_INDIRECT or IS_REFERENCE value,
which was mostly already the case, with two exceptions:
- Calls to return-by-reference functions. Because return-by-reference functions
are quite rare, this is solved by delegating the DEREF to the RETURN_BY_REF
handler, which will examine the stack to check whether the caller expects a
VAR or TMP to understand whether the DEREF is needed. Internal functions will
also need to adjust by calling the zend_return_unwrap_ref() function.
- By-reference assignments, including both $a = &$b, as well as $a = [&$b]. When
the result of these expressions is used in a BP_VAR_R context, the reference
is unwrapped via a ZEND_QM_ASSIGN opcode beforehand. This is exceptionally
rare.
Closes GH-20628
55 lines
928 B
PHP
55 lines
928 B
PHP
--TEST--
|
|
Relative print commands
|
|
--INI--
|
|
opcache.enable_cli=0
|
|
--PHPDBG--
|
|
b foo
|
|
r
|
|
p
|
|
p o
|
|
q
|
|
--EXPECTF--
|
|
[Successful compilation of %s]
|
|
prompt> [Breakpoint #0 added at foo]
|
|
prompt> string(4) "test"
|
|
[Breakpoint #0 in foo() at %s:15, hits: 1]
|
|
>00015: var_dump(strrev($baz));
|
|
00016: }
|
|
00017:
|
|
prompt> [Stack in foo() (8 ops)]
|
|
|
|
foo:
|
|
; (lines=8, args=1, vars=1, tmps=%d)
|
|
; %s:14-16
|
|
L0014 0000 CV0($baz) = RECV 1
|
|
L0015 0001 INIT_FCALL %d %d string("var_dump")
|
|
L0015 0002 INIT_FCALL %d %d string("strrev")
|
|
L0015 0003 SEND_VAR CV0($baz) 1
|
|
L0015 0004 T1 = DO_ICALL
|
|
L0015 0005 SEND_VAL T1 1
|
|
L0015 0006 DO_ICALL
|
|
L0016 0007 RETURN null
|
|
prompt> L0015 0001 INIT_FCALL %d %d string("var_dump")
|
|
prompt>
|
|
--FILE--
|
|
<?php
|
|
|
|
namespace Foo {
|
|
class Bar {
|
|
function Foo($bar) {
|
|
var_dump($bar);
|
|
}
|
|
|
|
function baz() { }
|
|
}
|
|
}
|
|
|
|
namespace {
|
|
function foo($baz) {
|
|
var_dump(strrev($baz));
|
|
}
|
|
|
|
(new \Foo\Bar)->Foo("test");
|
|
foo("test");
|
|
}
|