1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 08:12:21 +01:00
Files
archived-php-src/ext/dom/tests/delayed_freeing/comment_node.phpt
Niels Dossche 003ebdd039 Fix GH-9628: Implicitly removing nodes from \DOMDocument breaks existing references
Change the way lifetime works in ext/libxml and ext/dom

Previously, a node could be freed even when holding a userland reference
to it. This resulted in exceptions when trying to access that node after
it has been implicitly or explicitly removed. After this patch, a node
will only be freed when the last userland reference disappears.

Fixes GH-9628.
Closes GH-11576.
2023-07-03 21:31:57 +02:00

24 lines
493 B
PHP

--TEST--
Delayed freeing comment node
--EXTENSIONS--
dom
--FILE--
<?php
$doc = new DOMDocument;
$comment = $doc->appendChild($doc->createElement('container'))
->appendChild($doc->createComment('my comment'));
echo $doc->saveXML(), "\n";
$comment->parentNode->remove();
echo $doc->saveXML(), "\n";
echo $doc->saveXML($comment), "\n";
var_dump($comment->parentNode);
?>
--EXPECT--
<?xml version="1.0"?>
<container><!--my comment--></container>
<?xml version="1.0"?>
<!--my comment-->
NULL