mirror of
https://github.com/php/php-src.git
synced 2026-03-24 00:02:20 +01:00
b10416a652
This deprecates passing null to non-nullable scale arguments of internal functions, with the eventual goal of making the behavior consistent with userland functions, where null is never accepted for non-nullable arguments. This change is expected to cause quite a lot of fallout. In most cases, calling code should be adjusted to avoid passing null. In some cases, PHP should be adjusted to make some function arguments nullable. I have already fixed a number of functions before landing this, but feel free to file a bug if you encounter a function that doesn't accept null, but probably should. (The rule of thumb for this to be applicable is that the function must have special behavior for 0 or "", which is distinct from the natural behavior of the parameter.) RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg Closes GH-6475.
64 lines
2.2 KiB
PHP
64 lines
2.2 KiB
PHP
--TEST--
|
|
Bug #73858: diff() of two relative/described DateTimes is wrong
|
|
--FILE--
|
|
<?php
|
|
/*
|
|
In the "verbose setup method" I'm trying setup the DateTime object myself
|
|
to see if it's the format string which is parsed in correctly or if it's the DateTime
|
|
object which is breaking stuff. From the testing it appears DateTime is broken somehow.
|
|
*/
|
|
$ss = 'february first day of last month midnight';
|
|
$es = 'february first day of this month midnight - 1 second';
|
|
|
|
$s = new DateTime($ss);
|
|
$e = new DateTime($es);
|
|
$d= $e->diff($s);
|
|
var_dump($d->days); // 0 ... but should be 30
|
|
|
|
$s = (new DateTime("now"))->setTimestamp(strtotime($ss)); // verbose setup method
|
|
$e = (new DateTime("now"))->setTimestamp(strtotime($es)); // verbose setup method
|
|
$d = $e->diff($s);
|
|
var_dump($d->days); // 30 ... and should be 30
|
|
|
|
/*
|
|
Next we will try mix/match the code to see what happens, surprisingly it seems that the end date ($e)
|
|
is the important one, if it uses the verbose method it returns the correct values.
|
|
*/
|
|
$s = (new DateTime("now"))->setTimestamp(strtotime($ss)); // verbose setup method
|
|
$e = new DateTime($es);
|
|
$d= $e->diff($s);
|
|
var_dump($d->days); // 0 ... but should be 30
|
|
|
|
$s = new DateTime($ss);
|
|
$e = (new DateTime("now"))->setTimestamp(strtotime($es)); // verbose setup method
|
|
$d= $e->diff($s);
|
|
var_dump($d->days); // 30 ... and should be 30
|
|
|
|
/*
|
|
This test just proves that the $e date is important BUT NOT because it's the one we call the diff() method
|
|
on, that's just coincidental that seems to imply that the "- 1 second" in the date string is the problem.
|
|
*/
|
|
$s = new DateTime($ss);
|
|
$e = (new DateTime("now"))->setTimestamp(strtotime($es)); // verbose setup method
|
|
$d= $s->diff($e);
|
|
var_dump($d->days); // 30 ... and should be 30
|
|
|
|
/*
|
|
[Workaround]
|
|
This final test seems to prove that the input string is important and that the "- 1 second" has a negative knock-on
|
|
effect on the results of the diff. By modifying the datetime with ->modify everything works as expected ...
|
|
it just means you have to be careful of how we work with DateTimes .
|
|
*/
|
|
$s = new DateTime($ss);
|
|
$e = new DateTime('february first day of this month midnight');
|
|
$e->modify('- 1 second');
|
|
var_dump($e->diff($s)->days); // 30 ... and should be 30
|
|
?>
|
|
--EXPECT--
|
|
int(30)
|
|
int(30)
|
|
int(30)
|
|
int(30)
|
|
int(30)
|
|
int(30)
|