archived-php-src/Zend/tests/exit/die_string_cast_exception.phpt at master - archived-php-src - Gitea: Git with a cup of tea

php/archived-php-src

mirror of https://github.com/php/php-src.git synced 2026-04-26 17:38:14 +02:00

Files

T

Juliette 4c5767f62f PHP 8.4 | Exit as function: fix incorrect parameter name (#15433 )

Follow up on 13483

As previously reported in https://github.com/php/php-src/pull/13483#discussion_r1718546927:

> The parameter names seem to be incorrect.
>
> It should be `$status`, not `$code`.
>
> The RFC explicitly uses that parameter name in the proposal: https://wiki.php.net/rfc/exit-as-function#proposal
>
> It is also the name already used in the [manual](https://www.php.net/exit).
>
> Lastly, the parameter name `$status` better covers what can be passed: either a status _message_ or a status _code_.
> While `$code` would read pretty weird when passing a message:
> ```php
> exit(code: 'message');
> ```

This commit attempts to fix this.

Includes adding a test for exit/die using a named argument.

Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>

2024-08-16 22:35:16 +01:00

15 lines

279 B

PHP

Raw Permalink Blame History

 --TEST--
 Bug #79777: String cast exception during die should be handled gracefully
 --FILE--
 <?php
 try {
     die(new stdClass);
 } catch (TypeError $e) {
     echo $e->getMessage(), PHP_EOL;
 }
 ?>
 --EXPECT--
 exit(): Argument #1 ($status) must be of type string|int, stdClass given