divinity76
c2d3734e89
Fix GH-15964: printf() can strip sign of -INF
...
We need to cater to negative infinity explicitly.
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de >
Closes GH-15965.
2024-12-02 14:27:36 +01:00
Niels Dossche
ab7c3b1e7b
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix GH-16957: Assertion failure in array_shift with self-referencing array
2024-11-29 19:21:49 +01:00
Niels Dossche
f1fc4e8ff7
Fix GH-16957: Assertion failure in array_shift with self-referencing array
...
We have an RC1 violation because we're immediately dereferencing and
copying the resulting array in the test case. Instead, transfer the
lifetime using RETVAL_COPY_VALUE and unwrap only after the internal
iterator is reset.
Closes GH-16970.
2024-11-29 19:21:11 +01:00
Niels Dossche
3a80936391
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix GH-16905: Internal iterator functions can't handle UNDEF properties
2024-11-28 19:22:55 +01:00
Niels Dossche
6a195bd9e7
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Fix GH-16905: Internal iterator functions can't handle UNDEF properties
2024-11-28 19:22:36 +01:00
Niels Dossche
e1b4534790
Fix GH-16905: Internal iterator functions can't handle UNDEF properties
...
Closes GH-16907.
2024-11-28 19:22:10 +01:00
David Warner
f086eaa7b8
Add Windows Server 2025 build number
...
Closes GH-16838.
2024-11-26 13:35:08 +01:00
Christoph M. Becker
8a5fd6c027
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Use another for bug51056.phpt
2024-11-25 22:06:59 +01:00
Christoph M. Becker
0b5de3014a
Use another for bug51056.phpt
...
This port is already used by san_ipv6_peer_matching.phpt, wo we choose
another port which is not explicitly used in our test suite. The
proper solution would be to use ephemeral ports[1], but our OpenSSL
`ServerClientTestCase` does not support this yet.
[1] <6ab4e330ac >
Closes GH-16871.
2024-11-25 22:06:04 +01:00
Christoph M. Becker
053af52835
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix potential conflict of copy_variation5-win32.phpt
2024-11-25 13:50:16 +01:00
Christoph M. Becker
4ceae71954
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Fix potential conflict of copy_variation5-win32.phpt
2024-11-25 13:49:20 +01:00
Christoph M. Becker
12ef3da381
Fix potential conflict of copy_variation5-win32.phpt
...
copy_variation1.phpt also creates and deletes a file copy.tmp in the
same folder, so conflicts may occur[1]. We apply a quick fix.
[1] <https://github.com/php/php-src/actions/runs/11902293714/job/33167012826 >
Closes GH-16854.
2024-11-25 13:48:50 +01:00
Christoph M. Becker
19e685ecc4
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Skip file_put_contents_variation7.phpt on Windows
2024-11-20 15:51:48 +01:00
Christoph M. Becker
38ec780015
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Skip file_put_contents_variation7.phpt on Windows
2024-11-20 15:50:54 +01:00
Christoph M. Becker
3656a84c39
Skip file_put_contents_variation7.phpt on Windows
...
While the test obviously succeeds on Windows, it may occasionally
conflict with file_put_contents_variation7-win32.phpt[1], so we skip it
like we do for many other of these tests which have win32 pendants.
[1] <https://github.com/php/php-src/actions/runs/11527743659/job/32093951818 >
Closes GH-16722.
2024-11-20 15:50:24 +01:00
Jakub Zelenka
7c96af42b7
Merge branch 'PHP-8.3' into PHP-8.4
2024-11-20 11:14:04 +01:00
Jakub Zelenka
ffff27f734
Merge branch 'PHP-8.2' into PHP-8.3
2024-11-20 11:12:19 +01:00
Niels Dossche
f3ade203d7
Fix GHSA-r977-prxv-hc43
...
Move the bound check upwards. Since this doesn't generate output we can
check the bound first.
2024-11-20 11:07:04 +01:00
Jakub Zelenka
d7fe40868e
Fix GHSA-c5f2-jwm7-mmq2: stream HTTP fulluri CRLF injection
2024-11-20 11:06:02 +01:00
Gina Peter Banyard
e7891838a1
ext/standard: Sync parameter names for fpow() to be identical to pow()
...
Closes GH-16751
2024-11-11 13:04:46 +00:00
FraOre
7bbf2eae8c
[skip ci] Fix array_any() and array_all() descriptions
...
Closes GH-16731.
2024-11-08 20:02:14 +01:00
Christoph M. Becker
5f5d2c04c3
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Fix rename_variation12*.phpt parallel test conflicts
2024-11-08 00:25:24 +01:00
Christoph M. Becker
03eeec16f0
Fix rename_variation12*.phpt parallel test conflicts
...
For rename_variation12.phpt this is actually not necessary, since there
is no rename_variation11.phpt, but we still fix it to be in sync with
rename_variation12-win32.phpt which actually is prone to parallel
conflicts.
(cherry picked from commit d4263ddc40 )
2024-11-08 00:24:49 +01:00
Ilija Tovilo
230defc198
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix array going away during sorting
2024-11-04 15:51:24 +01:00
Ilija Tovilo
f033cf75e4
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Fix array going away during sorting
2024-11-04 15:51:03 +01:00
Ilija Tovilo
2bdce61390
Fix array going away during sorting
...
Fixes GH-16648
Closes GH-16654
2024-11-04 15:50:35 +01:00
Arnaud Le Blanc
4c212b305f
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix tests: Prevent stack overflow during dtor
2024-10-24 15:58:12 +02:00
Arnaud Le Blanc
f3e87e2a6d
Fix tests: Prevent stack overflow during dtor
...
On s390x the stack is smaller and/or the object dtor code uses more stack,
which causes the destruction of deeply nested objects to crash in these
tests. Here I ensure that objects are released one by one at the end of the
tests to avoid recursive dtor.
Closes GH-16561
Fixes GH-16528
2024-10-24 15:56:25 +02:00
Ilija Tovilo
5f2f1a5702
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix exception in assert() callback with bail enabled
2024-10-14 14:01:16 +02:00
Ilija Tovilo
f512ff4afa
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Fix exception in assert() callback with bail enabled
2024-10-14 14:00:20 +02:00
Ilija Tovilo
b5c09b1a61
Fix exception in assert() callback with bail enabled
...
Fixes GH-16293
Closes GH-16304
2024-10-14 13:59:26 +02:00
Calvin Buckley
4643386703
Fix regression on platforms without ZEND_CHECK_STACK_LIMIT set (8.4) ( #16285 )
...
The check called an API only available with this def set.
Gate the check behind ifdef and change control flow to better fit it.
Co-authored-by: Arnaud Le Blanc <arnaud.lb@gmail.com >
2024-10-08 10:22:23 -03:00
Niels Dossche
612a6ad0af
Use standard error message for stack limit in serialize()
...
With GH-16204 merged, we can use the standard error message for the
recently-merged GH-16159.
Closes GH-16225.
2024-10-04 20:09:45 +02:00
Niels Dossche
577eb68212
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix GH-15169: stack overflow when var serialization in ext/standard/var
2024-10-02 21:32:20 +02:00
Niels Dossche
bd724bdf42
Fix GH-15169: stack overflow when var serialization in ext/standard/var
...
Adding a stack check here as I consider serialization to be a more
sensitive place where erroring out with an exception seems appropriate.
Closes GH-16159.
2024-10-02 21:30:59 +02:00
Arnaud Le Blanc
3952a8f9f1
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
[ci skip] NEWS for GH-16061
Fix array_merge_recursive(): convert_to_array() may need separation (#16061 )
2024-10-02 12:44:00 +02:00
Arnaud Le Blanc
220c8828cc
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
[ci skip] NEWS for GH-16061
Fix array_merge_recursive(): convert_to_array() may need separation (#16061 )
2024-10-02 12:43:48 +02:00
Arnaud Le Blanc
545bef8ae6
Fix array_merge_recursive(): convert_to_array() may need separation ( #16061 )
2024-10-02 12:37:04 +02:00
David Carlier
4ad12bdd2d
Merge branch 'PHP-8.3' into PHP-8.4
2024-09-30 18:11:25 +01:00
David Carlier
d828308095
Merge branch 'PHP-8.2' into PHP-8.3
2024-09-30 18:11:14 +01:00
David Carlier
332b067c5e
Fix GH-15937: stream timeout option overflow.
...
close GH-15942
2024-09-30 18:10:33 +01:00
Christoph M. Becker
ebee8df27e
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix potential parallel test conflicts
2024-09-29 02:13:06 +02:00
Christoph M. Becker
a17634c029
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Fix potential parallel test conflicts
2024-09-29 02:11:48 +02:00
Christoph M. Becker
f5649556ea
Fix potential parallel test conflicts
...
Both tests call `create_files()` with the same `$name_prefix` what
might clash.
Co-authored-by: Gina Peter Banyard <girgias@php.net >
Closes GH-16103.
2024-09-29 02:05:14 +02:00
Ilija Tovilo
28d88c72bc
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Reduce regex backtracking in phpinfo.phpt
2024-09-27 17:10:58 +02:00
Ilija Tovilo
0226e5d01d
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Reduce regex backtracking in phpinfo.phpt
2024-09-27 17:10:47 +02:00
Ilija Tovilo
c4c45da4b9
Reduce regex backtracking in phpinfo.phpt
...
On NixOS, the output of phpinfo() can get very large, causing us to run into the
backtracking limit. Lazy matching for .*/.+ can help reduce backtracking.
2024-09-27 15:02:21 +02:00
Christoph M. Becker
f44250c418
Merge branch 'PHP-8.3'
...
* PHP-8.3:
Fix GH-15980: Signed integer overflow in main/streams/streams.c
2024-09-24 12:35:06 +02:00
Christoph M. Becker
acee803e6a
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Fix GH-15980: Signed integer overflow in main/streams/streams.c
2024-09-24 12:33:17 +02:00
Christoph M. Becker
81916758ec
Fix GH-15980: Signed integer overflow in main/streams/streams.c
...
We need to avoid signed integer overflows which are undefined behavior.
We catch that, and set `offset` to `ZEND_LONG_MAX` (which is also the
largest value of `zend_off_t` on all platforms). Of course, that seek
may fail, but even if it succeeds, the stream is no longer readable,
but that matches the current behavior for offsets near `ZEND_LONG_MAX`.
Closes GH-15989.
2024-09-24 12:32:00 +02:00