Michael Voříšek
9a73ec0367
Always skip randomly failing OCI8 extauth tests
...
This might be caused by an issue with the Oracle Instant Client
libraries[1]; we skip the tests for the time being.
[1] <https://github.com/php/php-src/pull/9524#issuecomment-1244409815 >
Closes GH-9524.
2022-09-13 14:21:23 +02:00
George Peter Banyard
47500f3300
Fix GH-9421 Incorrect argument number for ValueError in NumberFormatter
...
Closes GH-9489
2022-09-13 12:42:58 +01:00
George Peter Banyard
293e69179d
Fix GH-9308 GMP throws the wrong error when a GMP object is passed to gmp_init()
...
Closes GH-9490
2022-09-13 11:24:19 +01:00
Ilija Tovilo
4a8cca241f
Skip oci tests that leak under asan
2022-09-08 15:56:13 +02:00
Ilija Tovilo
aa7f4497bf
Fix undefined left shift in oci
...
The bit is shifted into the signed bit which is undefined. Make the
integer explicitly unsigned before shifting.
2022-09-08 15:56:10 +02:00
Ilija Tovilo
1435fc6262
Private method incorrectly marked as "overwrites" in reflection
...
Fix GH-9409
Closes GH-9469
2022-09-08 10:43:25 +02:00
Yurun
6ac3f7c84d
Fix GH-9411: PgSQL large object resource is incorrectly closed
...
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de >
Closes GH-9411.
2022-09-05 16:37:54 +02:00
Dmitry Stogov
81cb005ef7
Fix type inference
...
Fixes oss-fuzz #50792
2022-09-05 12:55:50 +03:00
Arnaud Le Blanc
db1ef97209
Add tests
2022-09-02 13:33:21 +02:00
Nicolas Grekas
93f11d8429
Fix GH-8932: Provide a way to get the called-scope of closures ( #9299 )
...
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de >
2022-09-02 13:32:50 +02:00
Dmitry Stogov
263a07e5b0
typo
2022-08-29 17:12:57 +03:00
Dmitry Stogov
4135e6011c
Fix memory leak
...
Fixes oss-fuzz #50616
2022-08-29 14:53:48 +03:00
Christoph M. Becker
725cb4e8ad
Revert "Fix GH-9296: ksort behaves incorrectly on arrays with mixed keys"
...
This reverts commit cd1aed8edd , as
discussed on internals (<https://externals.io/message/118483 >).
2022-08-29 12:41:36 +02:00
Dmitry Stogov
ce42dcf483
Fix ext/opcache/tests/jit/inc_obj_004.phpt failure introduced by fd74ee7e90
...
This should fix GH-9445
2022-08-29 12:30:14 +03:00
Michael Voříšek
f86629569c
Fix pdo_dblib ext test conflicts when run in parallel
...
Closes GH-9430.
2022-08-26 14:57:13 +02:00
Michael Voříšek
be4dd60c55
Fix oci8/pdo_oci random test failures when run in parallel
...
Closes GH-9424.
2022-08-25 15:20:50 +02:00
Christoph M. Becker
f59754694e
xmlRelaxNGCleanupTypes() is deprecated as of libxml2 2.10.0
...
The documentation[1] suggest to call `xmlCleanupParser()` instead, but
we are not doing that for reasons[2]. Thus, we do no longer call
`xmlRelaxNGCleanupTypes()` for libxml2 ≥ 2.10.0.
[1] <https://gnome.pages.gitlab.gnome.org/libxml2/devhelp/libxml2-relaxng.html#xmlRelaxNGCleanupTypes >
[2] <8742276eb3 >
Closes GH-9417.
2022-08-25 15:10:30 +02:00
Dmitry Stogov
fd74ee7e90
JIT: Make code generation to be consistent with register allocation
...
Fixes ext/opcache/tests/jit/add_014.phpt with opcache.jit=1205
2022-08-22 19:53:33 +03:00
Dmitry Stogov
c9c51eb1f1
Tracing JIT: Fix incorrect guard elimination
...
Fixes oss-fuzz #49917
2022-08-22 15:38:41 +03:00
Michael Voříšek
305892580e
Fix pdo_oci tests for PHP 8.0
2022-08-22 09:25:43 +02:00
NathanFreeman
6027d441c1
Fix #79451 : DOMDocument->replaceChild on doctype causes double free
...
We have to reset intSubset if replacing doctype with another doctype node.
Closes GH-9201.
Closes GH-9376.
2022-08-19 18:10:06 +02:00
David Carlier
52e312afb8
opcache jit fix message format for OpenBSD.
...
like macOs it requires `ll`.
Closes #9380 .
2022-08-19 16:40:29 +01:00
George Peter Banyard
d6831e9a5c
Revert Fixed bug #79451
...
The fix for 8.1 and above is not identical and I don't know how to fix without breaking the whole build apparently
2022-08-19 13:54:54 +01:00
Tim Starling
410e5d48a3
Fix GCC 9.4 uninitialized variable warning
...
ext/opcache/zend_accelerator_blacklist.c:295:4: error: ‘blacklist_path_length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
2022-08-19 12:46:55 +01:00
NathanFreeman
1d4300d870
Fix bug #79451 : Using DOMDocument->replaceChild on doctype causes double free
...
Closes GH-9201
2022-08-19 12:46:23 +01:00
Christoph M. Becker
72da418719
Fix GH-9316: $http_response_header is wrong for long status line
...
While the reason-phrase in a HTTP response status line is usually
short, there is no actual limit specified by the RFCs. As such, we
must not assume that the line fits into the buffer (which is currently
128 bytes large).
Since there is no real need to present the complete status line, we
simply read and discard the rest of a long line.
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com >
Closes GH-9319.
2022-08-18 12:27:54 +02:00
Jakub Zelenka
84dcf578b1
Fix GH-9339: OpenSSL oid_file path check warning contains uninitialized path
2022-08-17 19:49:36 +01:00
Gert de Pagter
05ed47ef12
Correct IntlDateFormatter::formatObject params
...
Closes GH-9341.
2022-08-15 17:56:34 +02:00
twosee
b8d07451d4
Re-fix GH-8409: SSL handshake timeout persistent connections hanging
...
This fix is another solution to replace d0527427be , use zend_try and zend_catch to make sure persistent stream will be released when error occurred.
Closes GH-9332.
2022-08-14 20:13:36 +08:00
Denis Vaksman
cd1aed8edd
Fix GH-9296: ksort behaves incorrectly on arrays with mixed keys
...
The comparator function used at ksort in SORT_REGULAR mode
need to be consistent with basic comparison rules. These rules
were changed in PHP-8.0 for numeric strings, but comparator
used at ksort kept the old behaviour. It leads to inconsistent
situations, when after ksort the first key is GREATER than some
of the next ones by according to the basic comparison operators.
Closes GH-9293.
2022-08-12 11:32:23 +02:00
Derick Rethans
962d8bd0b6
The data for Tehran has changed, update test
2022-08-11 16:26:33 +01:00
Derick Rethans
c6992121cc
Updated to version 2022.2 (2022b)
2022-08-11 15:54:28 +01:00
Jakub Zelenka
d9ff5e079f
Fix GH-8472: stream_socket_accept result may have incorrect metadata
2022-08-07 14:17:38 +01:00
Dmitry Stogov
2758ff2a77
Tracing: Prevent recording types of variables used to pass zend_class_entry
2022-08-01 17:02:53 +03:00
Dmitry Stogov
af1a7b7b72
Fix SSA reconstruction when body of "foreach" loop is removed
...
Fixes oss-fuzz #49483
2022-08-01 14:00:19 +03:00
Derick Rethans
001e7dbb04
Fixed bug #80047 (DatePeriod doesn't warn with custom DateTimeImmutable)
2022-07-28 10:28:10 +01:00
Derick Rethans
85f3a969dc
Revert "Fixed #80047 : DatePeriod doesn't warn with custom DateTimeImmutable"
...
This reverts commit 973c3f6e24 .
2022-07-28 10:13:54 +01:00
Christoph M. Becker
8ed21a89f3
Fix GH-9032: SQLite3 authorizer crashes on NULL values
...
The arguments 3 to 6 of the authorizer callback may be `NULL`[1], and
we have to properly deal with that. Instead of causing a segfault, we
deny authorization, which is still better than a crash, and apparently,
we cannot do better anyway.
[1] <https://www.sqlite.org/c3ref/set_authorizer.html >
Closes GH-9040.
2022-07-27 12:49:16 +02:00
Christoph M. Becker
a442e29485
Fix GH-9155: dba_open("non-existing", "c-", "flatfile") segfaults
...
We must not assume that the lock file has been opened.
Closes GH-9156.
2022-07-27 12:08:36 +02:00
Christoph M. Becker
35fd97c3c9
Fix GH-9033: Loading blacklist file can fail due to negative length
...
If the blacklist file contains a line with a single double-quote, we
called `zend_strndup(pbuf, -1)` what causes an unnecessary bail out;
instead we just ignore that line.
If the blacklist file contains an empty line, we may have caused an OOB
read; instead we just ignore that line.
Closes GH-9036.
2022-07-25 16:30:19 +02:00
Dmitry Stogov
44b86aee31
Fix memory leak
...
Fixes oss-fuzz #49272
2022-07-25 12:04:46 +03:00
Ilija Tovilo
3962f00b01
Fix spl test cleanup
2022-07-21 17:20:30 +02:00
George Peter Banyard
5b83b3a933
Fix memory leak in LMDB driver
2022-07-21 14:05:48 +01:00
Heiko Weber
3b7babf9b3
Fix GH-9017: php_stream_sock_open_from_socket could return NULL
...
Closes GH-9020.
2022-07-19 17:06:02 +02:00
Dmitry Stogov
bd30eff5de
Fix type inference for FETCH_DI_UNSET
...
Fixes oss-fuzz #48507
2022-07-18 13:14:15 +03:00
David CARLIER
d830a1f6f0
random extension macOs handling update.
...
Not such as fix but taking more precautions.
Indeed, the arc4random has two little flaws in this platform,
one already caught upfront by the extension (ie size 0), also
internal use of ccrng_generate which can silently fail in few rare
cases.
Closes #7824 .
2022-07-15 12:43:43 +01:00
David Carlier
7c3dfbb845
intl extension, build fix for icu >= 69.x release. ubrk/ucnv_safeClone had been deprecated in favor of ubrk/ucnv_clone which does not use user provided stacks but remain thread safe.
2022-07-08 17:38:31 +01:00
George Peter Banyard
79a283240e
Revert "Fix GH-8563 Different results for seek() on SplFileObject and SplTempFileObject"
...
Although the fix is partially correct it also breaks long standing behaviour which has been produced since PHP 5.3.
This reverts commit 6f87a5c633 .
2022-07-05 21:28:59 +01:00
George Peter Banyard
8fce70ae7b
Abort LMDB transaction whe trying to delete non-existing key
2022-07-01 17:26:27 +01:00
David Carlier
b3569865b3
Fix the crypt sha apis build (with recent clang versions).
...
Removing the said subtraction by casting instead.
While at it fixing werror level on phpdbg too.
Closes #8897 .
2022-07-01 05:33:12 +01:00