php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-04-29 11:13:36 +02:00
Code Issues Packages Projects Releases Wiki Activity
120,327 Commits 549 Branches 1,486 Tags
f0dfdca0ae67940ce23703a2354b4fca08e4eab8
Commit Graph

56208 Commits

Author SHA1 Message Date
George Peter Banyard fa8d9b1183 Improve type declarations for Zend APIs 
Voidification of Zend API which always succeeded
Use bool argument types instead of int for boolean arguments
Use bool return type for functions which return true/false (1/0)
Use zend_result return type for functions which return SUCCESS/FAILURE as they don't follow normal boolean semantics

Closes GH-6002
 2020-08-28 15:41:27 +02:00
Dmitry Stogov 7690439edd Don't load IP when entering inlined function 2020-08-28 13:27:35 +03:00
Nikita Popov 32315c247f Promote incomplete class to modification to Error 
In line with engine diagnostic promotions, property writes throw
an Error exception, while reads throw a warning.
 2020-08-28 11:14:43 +02:00
Nikita Popov f965e20059 Promote ArrayObject modification during sorting to Error exception 2020-08-28 10:42:14 +02:00
Nikita Popov 99c5e083ca Throw Error instead of E_ERROR when calling method on incomplete class 
There's no reason for this to abort execution completely.
 2020-08-28 10:34:21 +02:00
Nikita Popov 4ce38304bb Remove unused BG(str_ebuf) global 
Also change BG(strtok_len) to size_t. This stores a string length,
so it should be size_t rather than zend_ulong.
 2020-08-28 10:14:41 +02:00
Nikita Popov df5011f56c Export and reuse zend_is_valid_class_name API 
Unserialization does the same check as zend_lookup_class, so let's
share the same optimized implementation.
 2020-08-28 10:06:01 +02:00
Nikita Popov c47011ba05 Use zend_string when storing incomplete class name 
No need to copy the string here...
 2020-08-28 10:01:46 +02:00
Nikita Popov 1d0f55315e Store incomplete_class entry as normal global 
I don't see any reason why this needs to live in a thread-safe
global, unlikely all other class entries.
 2020-08-28 09:57:54 +02:00
Dmitry Stogov 1c1165f8cd Avoid useless IP load 2020-08-28 00:53:09 +03:00
Dmitry Stogov 0866208988 Remove useless register allocations 2020-08-28 00:02:10 +03:00
Dmitry Stogov 972041d68d Replace "mov %eax, %ecx; shl $1, $ecx" by "lea (%eax,%eax), %ecx" 2020-08-27 22:59:30 +03:00
Nikita Popov ac98ac7225 Merge branch 'PHP-7.4' 
* PHP-7.4:
  Don't assert when comparing uninit DateTimeZone objects
 2020-08-27 16:20:24 +02:00
Nikita Popov 5ae657b296 Don't assert when comparing uninit DateTimeZone objects 
Nothing guarantees that the objects are initialized here... just
check as usual.
 2020-08-27 16:18:45 +02:00
Nikita Popov e083cfaf6d Merge branch 'PHP-7.4' 
* PHP-7.4:
  Require non-negative length in stream_get_contents()
 2020-08-27 15:51:58 +02:00
Nikita Popov 8daf79215d Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Require non-negative length in stream_get_contents()
 2020-08-27 15:51:35 +02:00
Nikita Popov 62dce97973 Require non-negative length in stream_get_contents() 
If the length is not -1, require it to be non-negative.

Using such lengths doesn't make sense (as only -1 is special-case
to read in chunks, anything else will end up doing a huge upfront
allocation) and can lead to string allocation overflow.

A similar check is already in place for file_get_contents(). That
one does not allow -1 (and uses null instead), but this function
is explicitly specified to accept -1, so stick to that behavior.
 2020-08-27 15:50:49 +02:00
Nikita Popov a3d0d947bd Use zend_dval_to_lval() in spl_offset_convert_to_long() 
Avoid fptoi UB and use the standard PHP conversion behavior.
 2020-08-27 14:53:56 +02:00
Dmitry Stogov e701146070 Update operands range information accoring to the taken branches and use this indormation to eliminate useless overflow checks. 2020-08-27 15:29:11 +03:00
Nikita Popov 988fc94bbb Fix leak on failed DatePeriod initialization 
We need to free not only p here, but also b and e.
 2020-08-27 12:54:43 +02:00
Nikita Popov ce83ec8790 Clean up strtok implementation 
Store the zend_string instead of performing a copy and storing
in a zval. Also make sure the string is released immediately if
it's no longer needed. Finally, avoid null pointer offset UB if
no string has been set -- though I'm wondering if this case
shouldn't be generating a warning?
 2020-08-27 12:24:58 +02:00
Dmitry Stogov 9d409f2c1e Eliminate ZSTR_IS_INTERNED() check 2020-08-27 11:38:15 +03:00
Christoph M. Becker f956434df2 Merge branch 'PHP-7.4' into master 
* PHP-7.4:
  Catch potential exceptions during to string conversion
 2020-08-27 10:26:15 +02:00
Christoph M. Becker 296030119c Catch potential exceptions during to string conversion 
As of PHP 7.4.0, exceptions are allowed to be thrown from inside
`__toString()` methods; we have to cater to that, and catch these
exceptions early.

Closes GH-6042
 2020-08-27 10:23:18 +02:00
Dmitry Stogov 3ead24ecfa Check interrupt only if the link is a part of the loop. 2020-08-27 11:04:23 +03:00
Dmitry Stogov c4fc453771 Rename zend_jit_var_may_be_modified_indirectly() into zend_jit_var_may_alias() 2020-08-27 10:31:39 +03:00
Dmitry Stogov 16b3b339ed Check reference guard once 2020-08-27 00:40:55 +03:00
Dmitry Stogov b9e3de0a32 Use "movaps" instead of "movsd" to copy the whole %xmm register. 2020-08-26 21:13:55 +03:00
Dmitry Stogov c1f14b8a49 Fixed reference-counting 2020-08-26 18:56:54 +03:00
Christoph M. Becker 00edc3f4bc Merge branch 'PHP-7.4' into master 
* PHP-7.4:
  Fix com_safearray_proxy related memory management issues
 2020-08-26 15:43:43 +02:00
Christoph M. Becker 8e2f219fad Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix com_safearray_proxy related memory management issues
 2020-08-26 15:40:57 +02:00
Christoph M. Becker 1b7ee6db88 Fix com_safearray_proxy related memory management issues 2020-08-26 15:39:32 +02:00
Christoph M. Becker 2f9e9d4d97 Merge branch 'PHP-7.4' into master 
* PHP-7.4:
  Separate COM::__construct()s $server_name array
 2020-08-26 15:02:34 +02:00
Christoph M. Becker b087bd2404 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Separate COM::__construct()s $server_name array
 2020-08-26 15:01:22 +02:00
Christoph M. Becker 75ac3f1cba Separate COM::__construct()s $server_name array 
This may otherwise be modified.
 2020-08-26 15:00:02 +02:00
Christoph M. Becker fc4a6cda4b Merge branch 'PHP-7.4' into master 
* PHP-7.4:
  Fix #64130: COM obj parameters passed by reference are not updated
 2020-08-26 14:55:34 +02:00
Christoph M. Becker 1ff981d7a6 Merge branch 'PHP-7.3' into PHP-7.4 
* PHP-7.3:
  Fix #64130: COM obj parameters passed by reference are not updated
 2020-08-26 14:53:46 +02:00
Christoph M. Becker 5ff15e2651 Fix #64130: COM obj parameters passed by reference are not updated 
`ITypeInfo_GetIDsOfNames()` is supposed to fail with `E_NOTIMPL` for
out-of-process servers, thus we should not remove the already available
typeinfo of the object in this case.

We also properly free the `byref_vals`.
 2020-08-26 14:50:04 +02:00
George Peter Banyard 1b2ec73c1d Drop various unused macros/APIs 
Also convert_libmagic_pattern() to return a zend_string*

Closes GH-6029
 2020-08-26 12:59:43 +02:00
Nikita Popov ebbe333ede Merge branch 'PHP-7.4' 
* PHP-7.4:
  Fix file name clash in test
 2020-08-26 12:32:22 +02:00
Nikita Popov 358721bcf7 Fix file name clash in test 2020-08-26 12:32:06 +02:00
Nikita Popov eb17f996fb Merge branch 'PHP-7.4' 
* PHP-7.4:
  Avoid socket path clash in test
 2020-08-26 12:12:23 +02:00
Nikita Popov 0487bcfac7 Avoid socket path clash in test 2020-08-26 12:11:22 +02:00
Dmitry Stogov 083f5f2005 Improved JIT for FETCH_DIM_R/IS and ISSET_DIM_OBJ 2020-08-26 13:09:16 +03:00
Nikita Popov f593019819 Prevent ResourceBundle double-construction 2020-08-26 10:25:15 +02:00
Nikita Popov 6b554251f7 Prevent double-construction of NumberFormatter 2020-08-26 10:25:09 +02:00
Nikita Popov 72eaf509d3 Prevent double-construction of IntlGregorianCalendar 2020-08-26 10:24:57 +02:00
Nikita Popov f6e5cc3391 Prevent double-construction of IntlRuleBasedBreakIterator 2020-08-26 10:03:28 +02:00
Dmitry Stogov d4383be6fa Use guard to check if array is packed or hash 2020-08-26 02:34:31 +03:00
Dmitry Stogov 5948a6674a Prevent negative array index access 2020-08-26 01:07:34 +03:00