Gustavo André dos Santos Lopes
f07dd29fdc
Fixed problem introduced in a763929 (fixing bug #61347 ).
...
The test added in 8c44c85 should now pass.
2012-03-28 13:04:41 +01:00
Shein Alexey
ddac4688e8
Added failing test for ArrayObject::offsetExists().
2012-03-27 18:59:04 +05:00
Gustavo André dos Santos Lopes
372801d94c
Fixed tests that var_dump/print_r DOM objects.
2012-03-23 22:08:33 +00:00
Gustavo André dos Santos Lopes
3960def881
Fixed bug #61482 , caused by the fix to bug #61418 .
...
Turns out I'd forgotten to also update the destructor for the iterator
returned by DirectoryIterator.
The iterator for DirectoryIterator maintains the same ->current pointer
throughout its existence (the DirectoryIterator itself) and returns it
(the same object) everytime a value is requested from the iterator.
Moving forward the iterator only changes the object. Previous code
added two references to the object in get_iterator on the account of
1) the iterator memory living in its DirectoryIterator object and
2) the object being stored in iterator->current. This seems to be
unnecessary. Iterators are not responsible for incrementing the refcount
of the values they yield, that's up to the caller (the engine). What
matters for the iterator is that the object exists as long as the
iterator exists and this can be guaranteed by incremented the refcount
only once. Consequently, I only add one reference in get_iterator
(and reclaim it in the iterator destructor).
2012-03-23 11:19:19 +00:00
Gustavo André dos Santos Lopes
85725337d5
Revert "Revert "- Fixed bug #61418 (Segmentation fault when DirectoryIterator's or" - causes bug #61482 "
...
This reverts commit a89c4a34ee .
2012-03-23 09:40:27 +00:00
Stanislav Malyshev
a89c4a34ee
Revert "- Fixed bug #61418 (Segmentation fault when DirectoryIterator's or" - causes bug #61482
...
This reverts commit 714f1ff4b3 .
2012-03-22 22:29:50 -07:00
Dmitry Stogov
672fe54a00
Revert "Fixed reference counting"
...
This reverts commit 14af1fe692 .
2012-03-22 15:51:58 +04:00
Dmitry Stogov
14af1fe692
Fixed reference counting
2012-03-22 15:03:16 +04:00
Gustavo André dos Santos Lopes
714f1ff4b3
- Fixed bug #61418 (Segmentation fault when DirectoryIterator's or
...
FilesystemIterator's iterators are requested more than once without
having had its dtor callback called in between).
2012-03-18 15:07:20 +00:00
Felipe Pena
af2fc625df
- Fixed memory leak when calling SplFileInfo's constructor twice
2012-03-11 15:42:57 +00:00
Xinchen Hui
533d90066e
Fix test
2012-03-11 08:30:30 +00:00
Xinchen Hui
a7639291b4
Fixed bug #61347 (inconsist isset behavior of Arrayobject)
2012-03-11 08:27:55 +00:00
Gustavo André dos Santos Lopes
7bbf5fe650
- Fixed bug #61326 (ArrayObject comparison).
2012-03-10 17:19:39 +00:00
Nikita Popov
3bc1455496
Fix bug #60596 : Code Cleanup Removing Superfluous If Statement
...
Cleanup only, no function change. Patch by ircmaxell.
2012-03-04 13:52:48 +00:00
Olivier DOUCET
ce535f1819
more verbose skip reason in test files with not so obvious extension requirements
2012-02-25 12:10:41 +00:00
Etienne Kneuss
78c8b4c8ff
Fix test
2012-02-01 13:25:32 +00:00
Rasmus Lerdorf
ac5718cdd3
These tests don't work if run as root
2012-01-08 18:43:30 +00:00
Rasmus Lerdorf
adc8c296ac
Make sure gc is enabled
2012-01-08 18:22:50 +00:00
Felipe Pena
e4ca0ed09f
- Year++
2012-01-01 13:15:04 +00:00
Patrick Allaert
183493d624
Added tests contributions on spl_autoload and stream_context_set_option()
...
Thank you Jean-Marc Fontaine and Alter Way
2011-12-09 11:23:19 +00:00
Antony Dovgal
c3b83e833d
fix bug #60082 (Crash in ArrayObject() when using recursive references)
...
--Tis line, and those below, will be ignored--
M trunk/ext/spl/spl_array.c
M branches/PHP_5_4/ext/spl/spl_array.c
M branches/PHP_5_3/ext/spl/spl_array.c
M branches/PHP_5_3/NEWS
2011-11-18 05:22:35 +00:00
Felipe Pena
72a133f155
- Fixed bug #60261 (phar dos null pointer)
2011-11-11 21:39:11 +00:00
Ferenc Kovacs
28faed47c4
ignore this test on FreeBSD per #60186
2011-11-01 10:25:47 +00:00
Ferenc Kovacs
bb4f96b2a1
duh
2011-11-01 10:20:39 +00:00
Ferenc Kovacs
5a2a02f655
marking ext/spl/tests/bug60082.phpt as slow test
2011-11-01 10:10:24 +00:00
Xinchen Hui
d2c8d30bb9
Test for #60082
2011-10-19 02:28:53 +00:00
Felipe Pena
83ca3c8ff9
- Fixed bug #60042 (spl_autoload_call may manipulate a dangling pointer)
...
patch by: tom at punkave dot com
2011-10-12 01:03:15 +00:00
Hannes Magnusson
f40e5204d4
Fixed bug #55807 (Wrong value for splFileObject::SKIP_EMPTY)
2011-09-30 14:17:23 +00:00
Hannes Magnusson
f19a112185
Test for non-string replacement, bug#54304
2011-09-12 17:20:44 +00:00
Hannes Magnusson
75c4d6f888
Allow replacement to be any scalar value
2011-09-12 13:21:57 +00:00
Hannes Magnusson
a6c07ae0d3
Fix cleanup routines
2011-09-07 12:05:19 +00:00
Xinchen Hui
16d0023daf
fix skipif description
2011-09-07 00:59:10 +00:00
Pierre Joye
f438a87d90
- use something we know it exists...
2011-09-06 07:26:05 +00:00
Pierre Joye
c97a56e77f
- skip on win, name.. name. are not valid names
2011-09-06 07:23:20 +00:00
Hannes Magnusson
850d865551
Add skipifs for bug#54971 (patch by datibbaw@)
2011-08-30 13:46:24 +00:00
Felipe Pena
23e438594d
- Make usage of new PHP_FE_END macro
2011-07-25 11:42:53 +00:00
Pierrick Charron
1b416caeb1
Fixed bug #54971 (Wrong result when using iterator_to_array with use_keys on true)
2011-06-28 11:09:06 +00:00
Knut Urdalen
778edca904
fixed temp directory names in spl tests
2011-06-25 07:45:41 +00:00
Knut Urdalen
f8e21c395b
fixed/refactored some spl tests related to owner/group retrieval
2011-06-25 04:50:42 +00:00
Felipe Pena
0afd4bd18b
- Possible fix for bug #54609 (Certain implementation(s) of SplFixedArray cause hard crash)
2011-06-05 01:38:12 +00:00
Felipe Pena
47315dfdf6
- Fixed bug #54970 (SplFixedArray::setSize() isn't resizing)
2011-06-02 00:40:27 +00:00
Gustavo André dos Santos Lopes
cd2cdd256a
- Make SplFileInfo::_bad_state_ex final.
2011-04-05 08:38:09 +00:00
Gustavo André dos Santos Lopes
2975308e1a
- Fixed bug #54384 (Dual iterators, GlobIterator, SplFileObject and
...
SplTempFileObject crash when user-space classes don't call the paren
constructor).
2011-04-04 02:50:27 +00:00
Pierrick Charron
e8486cc374
Fix common typos in the source code (Reported in Bug #54065 )
...
# External libraries were excluded
# Thanks eitan at eitanadler dot com for the first patch :)
2011-04-03 21:46:52 +00:00
Felipe Pena
0ab7f1cebf
- Fixed bug #54292 (Wrong parameter causes crash in SplFileObject::__construct())
2011-03-23 22:46:04 +00:00
Felipe Pena
0dd448cbf1
- Fixed bug #54281 (Crash in non-initialized RecursiveIteratorIterator)
2011-03-22 22:41:16 +00:00
Gustavo André dos Santos Lopes
f06e3ba5c1
- Fixed bug #54291 (Crash iterating DirectoryIterator for dir name starting
...
with \0).
2011-03-19 23:15:04 +00:00
Felipe Pena
c7e7de3485
- Fixed bug #49608 (Using CachingIterator on DirectoryIterator instance segfaults)
2011-03-08 19:56:29 +00:00
Felipe Pena
53b1c76efe
- Fixed SplObjectStorage::offsetSet arginfo, reported in bug #54118
2011-03-01 00:13:23 +00:00
Felipe Pena
54a7e5d7c3
- Fixed memory leak in DirectoryIterator::getExtension() and SplFileInfo::getExtension()
2011-02-20 16:33:53 +00:00