Máté Kocsis
5770b66722
Cleanup argument handling of Zend functions and methods
...
Closes GH-5847
2020-07-21 14:47:03 +02:00
Nikita Popov
be9c5daf28
Remove null from highlight_* return types
...
Also fix show_source() discrepancy in func_info.
2020-07-21 10:40:08 +02:00
Nikita Popov
9d37a57411
Remove bool return type from assert_options
...
Not seeing any way this function can return bool.
2020-07-21 10:18:33 +02:00
Nikita Popov
6f8d0ba0dd
Fix bug #79868
...
This simply restores the code from PHP 7.4 which I incorrectly
"simplified" in master.
2020-07-20 15:15:23 +02:00
Nikita Popov
9002e95f7c
Use proper methods for php_user_filter implementation
...
These are dummy methods, but should at least check zpp for
arginfo consistency.
2020-07-17 17:01:47 +02:00
Nikita Popov
895a22c03c
Add missing image_type_to_extension() argument
2020-07-17 15:24:41 +02:00
Nikita Popov
857166c351
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79839
2020-07-17 14:51:16 +02:00
Nikita Popov
0c28b47154
Fixed bug #79839
...
Add reference type sources in array_walk.
2020-07-17 14:50:22 +02:00
Christoph M. Becker
ae7554270f
Fix #79805 : sapi_windows_vt100_support throws TypeError
...
It does not make sense to throw a `TypeError` when the stream can't be
analyzed. If `sapi_windows_vt100_support()` is used as getter, we just
return `false` in that case; if the function is used as setter, we
additionally trigger a warning.
We also fix the test cases for this function, which have been broken
before. Note that these tests are still whitespace sensitive.
2020-07-16 18:36:02 +02:00
Christoph M. Becker
7e357f470d
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Enable further tests on Windows
2020-07-16 16:08:07 +02:00
Christoph M. Becker
c1b5e7a9ab
Enable further tests on Windows
2020-07-16 16:07:23 +02:00
Christoph M. Becker
371e29ef3a
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix tests regarding negative fileinode()
2020-07-15 16:39:54 +02:00
Christoph M. Becker
dd1d1191e1
Fix tests regarding negative fileinode()
...
The results of `fileinode()` may be negative due to wrap-around
behavior (at least on Windows as of PHP 7.4.0).
2020-07-15 16:38:38 +02:00
Nikita Popov
1c0ee68b83
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix bug #78008 : dns_check_record() always return true on Alpine
2020-07-15 15:10:50 +02:00
Nikita Popov
2053329b1a
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix bug #78008 : dns_check_record() always return true on Alpine
2020-07-15 15:10:40 +02:00
Andy Postnikov
2c57378bd3
Fix bug #78008 : dns_check_record() always return true on Alpine
...
- free handle before return result
- cleaned up remaining usage of MAXPACKET
- update dns_get_mx() to use the same approach
Closes GH-5854.
2020-07-15 15:10:19 +02:00
Nikita Popov
f855b59994
Merge remote-tracking branch 'upstream/PHP-7.4' into PHP-7.4
...
* upstream/PHP-7.4:
Fix test for x86 Windows
2020-07-14 12:43:58 +02:00
Nikita Popov
745bc4c2ea
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79849
2020-07-14 12:43:03 +02:00
Nikita Popov
162776a132
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79849
2020-07-14 12:42:46 +02:00
Evgeny Stepanischev
ce149b0cb8
Fixed bug #79849
...
Closes GH-5853.
2020-07-14 12:41:43 +02:00
Martin Schröder
547d98b81d
Support socketpairs in proc_open()
...
Closes GH-5777.
2020-07-14 10:35:45 +02:00
Christoph M. Becker
99c78963c8
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix test for x86 Windows
2020-07-13 10:53:55 +02:00
Christoph M. Becker
e2c17cef4b
Fix test for x86 Windows
...
`st_dev` deliberately overflows on such systems, cf.
<http://svn.php.net/viewvc?view=revision&revision=350100 >.
2020-07-13 10:52:26 +02:00
twosee
c0172aa2bd
debug_zval_dump(): Don't skip recursion detection on first level
...
A complement to ae6f45ad45
Closes GH-5843.
2020-07-12 03:08:42 +08:00
twosee
614b2191bd
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed BC break of php_debug_zval_dump
2020-07-11 18:32:18 +08:00
twosee
7a39e174aa
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed BC break of php_debug_zval_dump
2020-07-11 18:31:30 +08:00
twosee
f0b2c2cb98
Fixed BC break of php_debug_zval_dump
...
It introduced by fixing bug #79830
2020-07-11 18:30:28 +08:00
twosee
40efb7ad61
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79830 introduced by fixing bug #79821
# Conflicts:
# ext/standard/var.c
2020-07-11 14:40:17 +08:00
twosee
6ef08b1903
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79830 introduced by fixing bug #79821
2020-07-11 14:38:27 +08:00
twosee
56dec3cc73
Fixed bug #79830 introduced by fixing bug #79821
...
This also fixes memory error in debug_zval_dump and var_export.
2020-07-11 14:37:25 +08:00
twosee
342fe094b5
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79821
2020-07-11 06:19:41 +08:00
twosee
8db2ae8ffb
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79821
2020-07-11 06:15:28 +08:00
twosee
150504e6b1
Fixed bug #79821
...
HashTable was reallocated (zend_hash_packed_grow) during php_var_dump, so we should call GC_ADDREF to make SEPARATE_ARRAY work.
Closes GH-5837.
2020-07-11 06:14:22 +08:00
Máté Kocsis
d30cd7d7e7
Review the usage of apostrophes in error messages
...
Closes GH-5590
2020-07-10 21:05:28 +02:00
Christoph M. Becker
2ad75ba784
Fix test cases
...
These tests are not supposed to check the result of `fclose(false)`.
2020-07-10 18:27:18 +02:00
Nikita Popov
12214e1d46
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79817
2020-07-10 14:07:59 +02:00
Nikita Popov
3f8d71d37f
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79817
2020-07-10 14:07:17 +02:00
Nikita Popov
a72c53a070
Fixed bug #79817
...
Use *_IND macros in a few places in string.c.
2020-07-10 14:06:41 +02:00
Christoph M. Becker
9a5695bfc3
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Enable further ext/standard/tests/file tests on Windows
2020-07-10 13:42:13 +02:00
Christoph M. Becker
99aa5484e2
Enable further ext/standard/tests/file tests on Windows
2020-07-10 13:36:41 +02:00
Christoph M. Becker
ef1de5e973
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix skip reasons
2020-07-10 11:28:28 +02:00
Christoph M. Becker
7edc5e5e39
Fix skip reasons
...
These tests fail on Windows for different reasons, but not because
symlinks, links, or lstat() would not be supported on Windows
generally.
2020-07-10 11:26:48 +02:00
Christoph M. Becker
bdcda50304
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Enable symlink_link_linkinfo_is_link_* tests on Windows
2020-07-10 10:10:30 +02:00
Christoph M. Becker
68293b19d4
Enable symlink_link_linkinfo_is_link_* tests on Windows
...
We mark symlink_link_linkinfo_is_link_error2.phpt as XFAIL on Windows
ZTS. Several Windows API file system functions ignore trailing spaces
in absolute filenames after the final directory separator, which causes
`link(' ', $link)` to actually call `CreateHardLink()` which then
fails, because linking folders is not supported. However, with NTS
builds (as well as on other systems), the $target is found to not
exist, so the function fails without actually attempting to create the
link. This needs further investigation.
2020-07-10 10:08:12 +02:00
Ilija Tovilo
9fa1d13301
Implement match expression
...
RFC: https://wiki.php.net/rfc/match_expression_v2
Closes GH-5371.
2020-07-09 23:52:17 +02:00
George Peter Banyard
af1de14802
Use ZPP string|array union check in PCRE extension
2020-07-09 14:17:19 +02:00
Christoph M. Becker
e33dd6ab1f
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Prevent parallel test conflicts
2020-07-09 12:36:57 +02:00
Christoph M. Becker
db484b612d
Prevent parallel test conflicts
...
Both tests used the same folder, which could clash in case the tests
are run simultaneously.
2020-07-09 12:35:31 +02:00
Nikita Popov
302933daea
Remove no_separation flag
2020-07-07 09:30:24 +02:00
Nikita Popov
dadb92ea35
Don't allow separation in array functions
...
The only case here that might be *somewhat* sensible is the userdata
argument of array_walk(), which could be used to keep persistent state
between callback invokations -- with the WTF moment that the final
result after the walk finishes will be unchanged. Nowdays, this is
much better achieved using a closure with a use-by-reference.
2020-07-07 09:15:43 +02:00