php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity
145,193 Commits 545 Branches 1,479 Tags
e045b881cf835287dd3fdbd06b72b01e960fed9a
Commit Graph

1302 Commits

Author SHA1 Message Date
David Carlier
297b25316b Merge branch 'PHP-8.5' 
* PHP-8.5:
  ext/pgsql: fix GH-21165 unit test.
 2026-02-17 04:27:35 +00:00
David Carlier
8ca6e13c2d Merge branch 'PHP-8.4' into PHP-8.5 
* PHP-8.4:
  ext/pgsql: fix GH-21165 unit test.
 2026-02-17 04:27:21 +00:00
David Carlier
f7af877cfe ext/pgsql: fix GH-21165 unit test. 
making it fails early instead.

close GH-21234
 2026-02-17 04:26:42 +00:00
David Carlier
49f903ccc2 Merge branch 'PHP-8.5' 
* PHP-8.5:
  Fix GH-21162: pg_connect() on error memory leak.
 2026-02-15 21:27:29 +00:00
David Carlier
6c8a71b3b7 Merge branch 'PHP-8.4' into PHP-8.5 
* PHP-8.4:
  Fix GH-21162: pg_connect() on error memory leak.
 2026-02-15 21:27:19 +00:00
David Carlier
539c5d9f76 Fix GH-21162: pg_connect() on error memory leak. 
The PHP_PQ_ERROR macro calls php_error_docref() which triggers user error handlers
thus libpq does not have the chance to clean the resources (and empty
connections string are allowed) on failure thus we avoid this macro
and delay the error handling after.

close GH-21165
 2026-02-15 21:26:23 +00:00
Arshid
daa3513c32 ext/pgsql: pg_lo_export/pg_connection_reset returning a boolean value using RETURN_BOOL (#21150) 2026-02-06 06:59:33 +00:00
Khaled Alam
32bd33983d Remove unreachable code after zend_error_noreturn calls (GH-20983) 2026-02-02 14:14:15 +01:00
Arnaud Le Blanc
65b4073922 Include the actual stub name in generated arginfo headers (#20993) 2026-01-21 20:57:00 +01:00
David Carlier
e9e0fe45e5 Merge branch 'PHP-8.5' 
* PHP-8.5:
  exp/pgsql: insert/update query string build possible UB fix.
 2026-01-19 06:18:26 +00:00
David Carlier
709c2f73aa Merge branch 'PHP-8.4' into PHP-8.5 
* PHP-8.4:
  exp/pgsql: insert/update query string build possible UB fix.
 2026-01-19 06:17:40 +00:00
David Carlier
5785ff7728 exp/pgsql: insert/update query string build possible UB fix. 
From PQescapeIdentifier() docs

```
A terminating zero byte is not required, and should not be counted in
length
```
 2026-01-19 06:17:23 +00:00
Niels Dossche
ef87a146fb pgsql: Don't allocate memory for default arguments (#20757) 2025-12-23 00:39:09 +01:00
Gina Peter Banyard
0953e898db Fix pg_fetch_object() when an error occurs in subroutine (#20407) 
This is a follow-up of GH-20068
 2025-11-06 22:47:28 +00:00
Gina Peter Banyard
129f6e536d ext/pgsql: Refactor parameter parsing for a few functions (#20068) 2025-11-05 22:33:25 +00:00
Niels Dossche
5b5fe437f5 Merge branch 'PHP-8.5' 
* PHP-8.5:
  Fix GH-20374: PHP with tidy and custom-tags
  pgsql: Fix memory leak when object init fails (#20387)
 2025-11-04 20:21:17 +01:00
Niels Dossche
b8e9f7c44c Merge branch 'PHP-8.4' into PHP-8.5 
* PHP-8.4:
  Fix GH-20374: PHP with tidy and custom-tags
  pgsql: Fix memory leak when object init fails (#20387)
 2025-11-04 20:21:09 +01:00
Niels Dossche
07aab0c356 Merge branch 'PHP-8.3' into PHP-8.4 
* PHP-8.3:
  Fix GH-20374: PHP with tidy and custom-tags
  pgsql: Fix memory leak when object init fails (#20387)
 2025-11-04 20:20:26 +01:00
Niels Dossche
04323955c1 pgsql: Fix memory leak when object init fails (#20387) 
The return value is already overwritten by this point so we do have to
clean up the old return value (i.e. dataset) after all.
 2025-11-04 19:59:38 +01:00
Gina Peter Banyard
00f42bb61d Merge branch 'PHP-8.5' 
* PHP-8.5:
  Fix include paths for new pgsql tests
 2025-11-04 04:43:04 +00:00
Gina Peter Banyard
3afac4c7f1 Merge branch 'PHP-8.4' into PHP-8.5 
* PHP-8.4:
  Fix include paths for new pgsql tests
 2025-11-04 04:42:53 +00:00
Gina Peter Banyard
14ed75e560 Fix include paths for new pgsql tests 2025-11-04 04:42:42 +00:00
Gina Peter Banyard
67e5d6cc2d Merge branch 'PHP-8.5' 
* PHP-8.5:
  Update NEWS for recent pgsql bugfix
  ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name (#20180)
 2025-11-04 00:10:03 +00:00
Gina Peter Banyard
7c6affd617 Merge branch 'PHP-8.4' into PHP-8.5 
* PHP-8.4:
  Update NEWS for recent pgsql bugfix
  ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name (#20180)
 2025-11-04 00:09:44 +00:00
Gina Peter Banyard
afca514c3b Merge branch 'PHP-8.3' into PHP-8.4 
* PHP-8.3:
  Update NEWS for recent pgsql bugfix
  ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name (#20180)
 2025-11-04 00:08:42 +00:00
Gina Peter Banyard
94dc6ae871 ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name (#20180) 
Also fix Windows CI with Postgres and CLEAN sections

---------

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
 2025-11-04 00:04:30 +00:00
Niels Dossche
5eec4d8001 pgsql: Avoid duplicating strings and factor out parameter building code 2025-10-20 20:41:38 +02:00
Niels Dossche
da9638298c pgsql: Avoid unnecessary work in pgsql_copy_from_query() if the input already ends in a newline 2025-10-20 20:41:38 +02:00
Niels Dossche
e2396a6ffb pgsql: Simplify pgsql_copy_from_query() by using character buffers 
This also avoids some unnecessary zend_string overhead.
 2025-10-20 20:41:38 +02:00
Niels Dossche
8e84e9a551 pgsql: Use cheaper string conversion functions 2025-10-20 20:41:38 +02:00
Niels Dossche
81fef09d01 Merge branch 'PHP-8.5' 
* PHP-8.5:
  pgsql: Fix memory leak when first string conversion fails
 2025-10-18 23:59:54 +02:00
Niels Dossche
9282111d9f Merge branch 'PHP-8.4' into PHP-8.5 
* PHP-8.4:
  pgsql: Fix memory leak when first string conversion fails
 2025-10-18 23:59:48 +02:00
Niels Dossche
d992cd8315 Merge branch 'PHP-8.3' into PHP-8.4 
* PHP-8.3:
  pgsql: Fix memory leak when first string conversion fails
 2025-10-18 23:59:41 +02:00
Niels Dossche
cf3b70d23c pgsql: Fix memory leak when first string conversion fails 
If the first string conversion fails, then i==0, but memory was still
allocated for `params`. However, we skip freeing `params` when i==0.

Closes GH-20213.
 2025-10-18 23:59:15 +02:00
Tim Düsterhus
985d681501 tree-wide: Replace zval_is_true() by zend_is_true() (#20065) 
* tree-wide: Replace `zval_is_true()` by `zend_is_true()`

The former is a direct alias of the latter which is much more often used.

* zend_operators: Remove `zval_is_true()`
 2025-10-07 20:44:32 +02:00
Tim Düsterhus
d793de1a8c pgsql: Use true / false instead of 1 / 0 for bool parameters 
Changes done with Coccinelle:

    @r1@
    identifier F;
    identifier p;
    typedef bool;
    parameter list [n1] PL1;
    parameter list [n2] PL2;
    @@

    F(PL1, bool p, PL2) {
    ...
    }

    @r2@
    identifier r1.F;
    expression list [r1.n1] EL1;
    expression list [r1.n2] EL2;
    @@

    F(EL1,
    (
    - 1
    + true
    |
    - 0
    + false
    )
    , EL2)
 2025-09-24 18:51:40 +02:00
David Carlier
b73d8b373a Merge branch 'PHP-8.4' 2025-08-15 08:08:16 +01:00
David Carlier
fd4db3e178 Merge branch 'PHP-8.3' into PHP-8.4 2025-08-15 08:05:14 +01:00
Mark Karpeles
987a3a5c8e Fix GH-19484 i: potential use after free when using persistent pgsql connections. 
By setting the notice processor to a no-op when a persistent connection is cleaned for future use.

Close GH-19485
 2025-08-15 08:04:14 +01:00
Gina Peter Banyard
841afdc486 streams: use type zend_result instead of type int 2025-08-04 15:30:57 +01:00
DanielEScherzer
1eadf553f1 Arginfo: avoid using temporary zvals for initializing attribute values (#19141) 
Instead of
* adding a zval on the stack
* initializing it
* copying the value to the attribute

Just initialize the value directly in the zend_attribute_arg
 2025-07-21 13:33:51 -07:00
Niels Dossche
30f03021d1 [ci skip] Remove obsolete todo (#19195) 
All arguments are documented on php.net, although result_type is called
mode in the docs and stub.
 2025-07-21 10:57:54 +02:00
Daniel Scherzer
142e378618 Arginfo: add and use known strings for attribute values 2025-07-14 17:31:22 -07:00
DanielEScherzer
9225cb45ac Make zend_register_*_constant() functions return pointers, use them (#19029) 
Have each of the specialized methods for registering a constant return a
pointer to the registered constant the same way that the generic
`zend_register_constant()` function does, and use those in the generated
arginfo files to avoid needing to search for a constant that was just
registered in order to add attributes to it.
 2025-07-07 12:23:52 -07:00
Jakub Zelenka
545d1536d8 Fix GHSA-hrwm-9436-5mv3: pgsql escaping no error checks 
This adds error checks for escape function is pgsql and pdo_pgsql
extensions. It prevents possibility of storing not properly escaped
data which could potentially lead to some security issues.
 2025-07-01 09:34:49 -07:00
Ilija Tovilo
49d94cced0 Merge branch 'PHP-8.4' 
* PHP-8.4:
  Fix GHSA-453j-q27h-5p8x
  Fix GHSA-hrwm-9436-5mv3: pgsql escaping no error checks
  Fix GHSA-3cr5-j632-f35r: Null byte in hostnames
 2025-07-01 17:48:00 +02:00
Jakub Zelenka
66bd809ac9 Fix GHSA-hrwm-9436-5mv3: pgsql escaping no error checks 
This adds error checks for escape function is pgsql and pdo_pgsql
extensions. It prevents possibility of storing not properly escaped
data which could potentially lead to some security issues.
 2025-07-01 23:01:16 +09:00
DanielEScherzer
171501b93f Replace @deprecated with #[\Deprecated] for internal constants (#18780) 
Only covers constants declared via stub files, others will be handled
separately in a later commit.

Does not include the intl extension, since that had some errors relating to the
cpp code; that extension will be updated separately.
 2025-06-26 11:27:15 -07:00
Gina Peter Banyard
0cdd3c32de ext/pgsql: Stop using useless convert_to_boolean() API (#18683) 
There are better ways of handling this than casting the zval in place
 2025-05-29 19:09:11 +01:00
Gina Peter Banyard
2b22ea9630 Merge branch 'PHP-8.4' 
* PHP-8.4:
  ext/pgsql: Fix warning not being emittedd when failure to cancel a query
 2025-05-29 15:44:08 +01:00