ea03cbebbc
Update PDO parameters for named arguments.
...
Closes GH-6220
2020-09-28 23:02:05 +01:00
7553c696c3
Another pass making some failure states unconditional erros in PDO
...
Also make internal function return type more accurate to inform usage
2020-09-28 19:35:31 +01:00
a5cf82802d
Make various failure conditions in PDO unconditional errors
...
This includes TypeErrors, ValueErrors, Error for uninitialized objects
and invalid user classes/callable instanciation
Closes GH-6212
2020-09-28 18:51:36 +01:00
9fab1b90ab
Drop ZPP check in PDO MySQLi test
...
This test is marked as XFAIL so it doesn't get looked at.
It checks that the method is called without arguments which is a ZPP concern
2020-09-28 18:51:35 +01:00
6a4eeb1c47
Improve PDO::inTransaction() support for MySQL
...
Closes GH-4996.
2020-09-23 11:50:06 +02:00
19314ff887
Fix some tests for libmysql
2020-09-18 18:01:04 +02:00
9962ad6444
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Support NO_BACKSLASH_ESCAPES with newer libmysqlclient
2020-09-18 15:26:04 +02:00
e6dc9abdb7
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Support NO_BACKSLASH_ESCAPES with newer libmysqlclient
2020-09-18 15:25:35 +02:00
70cba36fc9
Support NO_BACKSLASH_ESCAPES with newer libmysqlclient
...
Requires the use of mysql_real_escape_string_quote().
2020-09-18 15:24:57 +02:00
c5401854fc
Run tidy
...
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
2020-09-18 14:28:32 +02:00
86e002729f
Fix some tests for libmysql
2020-09-17 15:27:02 +02:00
b0661a9667
Fix warnings when building against libmysqlclient
...
At least for version 8.0 this is warning free now.
2020-09-17 15:02:35 +02:00
3ad57f9f31
Merge branch 'PHP-7.4'
...
* PHP-7.4:
pdo_mysql/mysqli (native) libmysqlclient_r no-longer used
mysql: native mysql-8.0 uses _Bool
mysqli: use native api
2020-09-17 11:35:03 +02:00
d591e1c4f5
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
pdo_mysql/mysqli (native) libmysqlclient_r no-longer used
mysql: native mysql-8.0 uses _Bool
mysqli: use native api
2020-09-17 11:32:01 +02:00
1aab7db6c8
pdo_mysql/mysqli (native) libmysqlclient_r no-longer used
...
The mysqlclient_r library exists in mysql-5.6 for compatibility only.
Later versions have it removed.
2020-09-17 11:27:31 +02:00
c9abb0c0ac
mysql: native mysql-8.0 uses _Bool
...
MySQL-8.0 removes option MYSQLI_OPT_SSL_VERIFY_SERVER_CERT
2020-09-17 11:27:31 +02:00
4fc7026630
Convert warning to assetion in MySQL PDO driver
...
Closes GH-6120
2020-09-15 12:49:59 +02:00
9975986b7e
Improve error messages mentioning parameters instead of arguments
...
Closes GH-5999
2020-09-09 10:47:43 +02:00
42b6b8a3ae
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #80027 Terrible performance using $query->fetch on queries with many bind parameters
2020-08-31 11:08:26 +02:00
44ade0e875
Fix #80027 Terrible performance using $query->fetch on queries with many bind parameters
...
Added new flags that allow skipping param_evt(s) that are not used by drivers,
in a backwards and forward compatible manner. Updated the pgsql, mysql, sqlite
and oci drivers to properly use the new flags. I've left out pdo_dblib, which
doesn't have a param_hook, and pdo_firebird, which seems to be using
PARAM_EVT_NORMALIZE in a wrong context (param type vs event type).
2020-08-31 11:03:03 +02:00
ee2506cc02
Fix #80027 Terrible performance using $query->fetch on queries with many bind parameters
...
Added new flags that allow skipping param_evt(s) that are not used by drivers,
in a backwards and forward compatible manner. Updated the pgsql, mysql, sqlite
and oci drivers to properly use the new flags. I've left out pdo_dblib, which
doesn't have a param_hook, and pdo_firebird, which seems to be using
PARAM_EVT_NORMALIZE in a wrong context (param type vs event type).
2020-08-31 11:02:34 +02:00
cfaa270da5
Use variadic signature for PDOStatement::fetchAll()
...
The current signature is incorrect, because the $ctor_args parameter
is not required to be an array (it can at least also be null, and
isn't enforced by an exception anyway).
I'm going for the variadic signature here, because we already use
the same variadic signature in PDO::query() and
PDOStatement::setFetchMode(), all of them accepting essentially the
same arguments.
2020-08-14 15:19:18 +02:00
670036e2a9
Use Z_PARAM_CLASS in PDOStatement::fetchObject()
...
Instead of implementing custom logic.
2020-08-13 16:20:29 +02:00
2803c8fb8d
Add all the missing parameter types to stubs
...
Closes GH-5955
2020-08-13 14:47:18 +02:00
33028bf014
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #64705 errorInfo property of PDOException is null when PDO::__construct() fails
2020-08-11 17:16:38 +02:00
981af26d7b
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #64705 errorInfo property of PDOException is null when PDO::__construct() fails
2020-08-11 17:13:28 +02:00
2fe2e5b48f
Fix #64705 errorInfo property of PDOException is null when PDO::__construct() fails
...
PDO driver constructors are throwing PdoException without setting
errorInfo, so create a new reusable function that throws exceptions
for PDO and will also set the errorInfo. Use this function in
pdo_mysql, pdo_sqlite, and pdo_pgsql.
2020-08-11 17:12:48 +02:00
7aacc705d0
Add many missing closing PHP tags to tests
...
Closes GH-5958
2020-08-09 22:03:36 +02:00
ec22e5aa38
Get rid of empty function entries
...
Closes GH-5917
2020-08-01 10:07:05 +02:00
9ee16a3c12
Update method signature in test
2020-07-20 16:16:37 +02:00
d30cd7d7e7
Review the usage of apostrophes in error messages
...
Closes GH-5590
2020-07-10 21:05:28 +02:00
2b5de6f839
Remove proto comments from C files
...
Closes GH-5758
2020-07-06 21:13:34 +02:00
c932cc841a
Fix [-Wundef] warning in PDO MySQL extension
2020-05-20 16:29:52 +02:00
1179686f62
Improve error messages for invalid property access
...
Closes GH-5446
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com >
2020-05-18 08:27:00 +02:00
2393692937
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #79596 : MySQL FLOAT truncates to int some locales
2020-05-15 09:13:22 +02:00
844a1245ef
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #79596 : MySQL FLOAT truncates to int some locales
2020-05-15 09:11:44 +02:00
d1cd489a53
Fix #79596 : MySQL FLOAT truncates to int some locales
...
We must not do locale aware float to string conversion here; instead
we using our `snprintf()` implementation with the `F` specifier.
2020-05-15 09:09:41 +02:00
50752401a7
Change the default PDO error mode to exceptions
...
According to <https://www.php.net/manual/en/pdo.error-handling.php >.
2020-05-04 22:51:47 +02:00
8597ec00d4
Remove support for libmysqlclient 5.0
...
Closes GH-5391.
2020-04-23 10:38:20 +02:00
a866ef88ed
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix MySQL local infile / attr handling on big endian systems
2020-04-16 11:23:11 +02:00
f684553c2c
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix MySQL local infile / attr handling on big endian systems
2020-04-16 11:22:43 +02:00
a1c1736bfb
Fix MySQL local infile / attr handling on big endian systems
...
Make sure pointer types match what is used by libmysql everywhere.
Closes GH-5380.
2020-04-16 11:22:17 +02:00
01b266aac4
Improve error messages of various extensions
...
Closes GH-5278
2020-03-23 18:59:04 +01:00
f8d795820e
Reindent phpt files
2020-02-03 22:52:20 +01:00
169805777c
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Apply tidy formatting
2020-02-03 13:42:08 +01:00
58b17906f5
Apply tidy formatting
...
Mostly reindent PHP scripts to spaces.
2020-02-03 13:41:31 +01:00
99db00b1f2
Fix #78880 Another round
2020-01-19 18:28:43 +01:00
afdaa91170
Fix #78880 : Final spelling fixes
2020-01-16 19:14:31 +01:00
0b4778c377
Fix #78880 : Another bunch of spelling errors
2020-01-16 09:46:47 +01:00
7232779fca
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #79106 : PDO may fetch wrong column indexes with PDO::FETCH_BOTH
2020-01-13 18:49:38 +01:00
Larry Garfield