7 Commits

Author	SHA1	Message	Date
Nikita Popov	614c0b846e	Allow removing non-existing key from WeakMap ... In line with usual PHP semantics. This previously triggered an assertion failure.	2020-08-27 12:42:08 +02:00
Nikita Popov	0026d8a783	Fix use-after-free is WeakMap key and value are the same ... Drop the object from the WeakMap as the last step, as this might end up destroying the object.	2020-08-27 12:05:06 +02:00
Máté Kocsis	d30cd7d7e7	Review the usage of apostrophes in error messages ... Closes GH-5590	2020-07-10 21:05:28 +02:00
Nikita Popov	653e4ea1c5	Add flag to forbid dynamic property creation on internal classes ... While performing resource -> object migrations, we're adding defensive classes that are final, non-serializable and non-clonable (unless they are, of course). This path adds a ZEND_ACC_NO_DYNAMIC_PROPERTIES flag, that also forbids the creation of dynamic properties on these objects. This is a subset of #3931 and targeted at internal usage only (though may be extended to userland at some point in the future). It's already possible to achieve this (what the removed WeakRef/WeakMap code does), but there's some caveats: First, this simple approach is only possible if the class has no declared properties, otherwise it's necessary to special-case those properties. Second, it's easy to make it overly strict, e.g. by forbidding isset($obj->prop) as well. And finally, it requires a lot of boilerplate code for each class. Closes GH-5572.	2020-06-24 11:52:36 +02:00
Nikita Popov	f8d795820e	Reindent phpt files	2020-02-03 22:52:20 +01:00
Nikita Popov	d8c9902567	Implement WeakMap ... RFC: https://wiki.php.net/rfc/weak_maps	2020-01-03 10:43:24 +01:00
Joe Watkins	6529d7acd9	zend_weakrefs	2019-03-12 00:35:35 +01:00