David CARLIER
9a8ae45c4b
Revert "FPM: Downgrade occasional "failed to acquire scoreboard" warning"
...
This reverts commit 3040f75f43 .
2022-07-18 14:21:54 +01:00
David Carlier
edb173c200
Merge branch 'PHP-8.0' into PHP-8.1
2022-07-18 12:40:47 +01:00
Felix Wiedemann
3040f75f43
FPM: Downgrade occasional "failed to acquire scoreboard" warning
...
With request timeouts configured, php-fpm occasionally prints the
following warning:
WARNING: failed to acquire scoreboard
This is happens when php-fpm checks the child scoreboards for timeouts,
but fails to acquire a lock immediately. As this can (and does) occur
during normal operation, this commit downgrades this to a notice.
Closes #9019 .
2022-07-18 12:40:16 +01:00
David Carlier
9b5a2635d6
Merge branch 'PHP-8.0' into PHP-8.1
2022-07-08 13:12:30 +01:00
Heiko Weber
bd6793372b
FPM: Fix possible double free on configuration load failure.
...
Closes #8948 .
2022-07-08 13:11:37 +01:00
David Carlier
3eead43b6d
Merge branch 'PHP-8.0' into PHP-8.1
2022-06-27 23:36:05 +01:00
Heiko Weber
325ca31dcf
FPM: zlog, fix free on wrong address for message prepend.
2022-06-27 23:34:58 +01:00
Jakub Zelenka
b3e6faed48
Merge branch 'PHP-8.0' into PHP-8.1
2022-06-19 20:09:37 +01:00
Jakub Zelenka
e330f443c9
Fix bug #67764 : fpm: syslog.ident does not work
2022-06-19 20:05:49 +01:00
David Carlier
75743eaf1b
Merge branch 'PHP-8.0' into PHP-8.1
2022-06-16 12:41:51 +01:00
Heiko Weber
a83363e361
FPM: Fix use after free in fpm_evaluate_full_path
...
Closes #8796 .
2022-06-16 12:18:01 +01:00
Jakub Zelenka
82eea0efc9
Merge branch 'PHP-8.0' into PHP-8.1
2022-05-10 21:39:31 +01:00
Jakub Zelenka
23a2030438
Fix bug #72185 : php-fpm writes empty fcgi record causing nginx 502
...
This issue might happen if there is change of the fcgi stream when
the buffer is full. Then the empty record is created which signals
end of stream which is incorrect.
The actual fix without a test was contributed by GitHub user @loveharmful
in GH-3198.
2022-05-10 21:36:55 +01:00
Jakub Zelenka
0332b62c35
Merge branch 'PHP-8.0' into PHP-8.1
2022-04-29 20:41:13 +01:00
David CARLIER
ef06f0f50b
Fix FPM ACL build check on MacOS
...
MacOS has got ACL support but without user/group support.
2022-04-29 20:39:22 +01:00
Jakub Zelenka
21d551ad0f
Merge branch 'PHP-8.0' into PHP-8.1
2022-04-27 19:14:47 +01:00
Jakub Zelenka
0df28869f6
Add skip for FPM resource heavy tests
2022-04-27 19:11:47 +01:00
Jakub Zelenka
8da14a3062
Merge branch 'PHP-8.0' into PHP-8.1
2022-04-23 15:16:00 +01:00
David Carlier
ff90d42b8b
Fix FPM kqueue handler fix remove callback typo
...
It avoids confusion on failed event.
2022-04-23 15:11:53 +01:00
Jakub Zelenka
abd56aeb9a
Merge branch 'PHP-8.0' into PHP-8.1
2022-04-22 23:07:01 +01:00
Jakub Zelenka
d8612fb6b7
Fix bug #77023 : FPM cannot shutdown processes
...
This change introduces subsequent kill of the process when idle process quit
(SIGQUIT) does not succeed. It can happen in some situations and means that FPM
is not able to scale down in dynamic pm. Using SIGKILL fixes the issue.
2022-04-22 20:51:02 +01:00
Jakub Zelenka
a57625374d
Merge branch 'PHP-8.0' into PHP-8.1
2022-04-15 22:21:18 +01:00
David Carlier
2f0918c638
Fix FPM socket clean up reallocation clang build warning
2022-04-15 22:20:15 +01:00
David Carlier
fc9fecbd09
Fix FPM zlog warning with var being uninitialized
2022-04-15 22:19:36 +01:00
Jakub Zelenka
62b676ff0f
Merge branch 'PHP-8.0' into PHP-8.1
2022-04-12 23:15:34 +01:00
Jakub Zelenka
33bb201b3e
Fix bug #76003 : FPM /status reports wrong number of active processe
...
The fix introduces early locking of scoreboard when it is updated
which prevents the race condition causing an incorrect number of
active processes being set.
2022-04-12 23:12:11 +01:00
Christoph M. Becker
720d6faa29
Merge branch 'PHP-8.0' into PHP-8.1
...
* PHP-8.0:
Fix bugtracker URL
2022-02-15 19:15:24 +01:00
Christoph M. Becker
e98a7a68b7
Fix bugtracker URL
...
The php-src bugtracker is now on Github.
Closes GH-8102.
2022-02-15 19:14:07 +01:00
Jakub Zelenka
49087a65ee
Merge branch 'PHP-8.0' into PHP-8.1
2022-02-09 23:23:05 +00:00
Till Backhaus
29fe06fa59
Fix bug #76109 : Implement fpm_scoreboard_copy
...
fpm_scoreboard_copy locks the scoreboard while copying the scoreboard and all
proc scoreboards. proc scoreboards are locked one by one while copying each
struct. The old implementation (inside fpm_handle_status_request) only briefly
locked the scoreboard while copying the scorebard.
Closes GH-7931
Co-authored-by: Jakub Zelenka <bukka@php.net >
2022-02-09 23:02:45 +00:00
Christoph M. Becker
2b07513192
Merge branch 'PHP-8.0' into PHP-8.1
...
* PHP-8.0:
Fix memory leak on invalid port
2022-01-08 21:06:39 +01:00
David Carlier
c99a026c9c
Fix memory leak on invalid port
...
Closes GH-7911.
2022-01-08 21:04:55 +01:00
Stefano Arlandini
46bec6de42
Fix the OpenMetrics response format returned by the FPM status page
...
Closes GH-7843, closes GH-7842
2022-01-04 23:01:10 +00:00
Christoph M. Becker
5d4bef0d0c
Merge branch 'PHP-8.0' into PHP-8.1
...
* PHP-8.0:
Fix buffer allocations in zlog_stream_set_msg_suffix()
2021-12-28 13:28:55 +01:00
David Carlier
cb3d858745
Fix buffer allocations in zlog_stream_set_msg_suffix()
...
If that code was used, there would be a UAF scenario.
Closes GH-7835.
2021-12-28 13:27:54 +01:00
Jakub Zelenka
a529d0dd15
Merge branch 'PHP-8.0' into PHP-8.1
2021-11-27 22:39:51 +00:00
Jakub Zelenka
81513e6285
Add skip for FPM process idle flaky test
2021-11-27 22:37:43 +00:00
Jakub Zelenka
435a5aca89
Add FPM test for php_admin_value doc_root usage
...
Closes GH-7673.
2021-11-23 18:36:04 +01:00
Jakub Zelenka
79f0e486fd
Merge branch 'PHP-8.0' into PHP-8.1
2021-11-20 20:44:02 +00:00
Jakub Zelenka
2f8407f185
Increase read timeout in FPM process idle test
2021-11-20 20:42:19 +00:00
Jakub Zelenka
fc67967190
Increase script sleep in FPM process idle test
2021-11-20 20:42:19 +00:00
Jakub Zelenka
48bc4ea758
Merge branch 'PHP-8.0' into PHP-8.1
2021-11-14 20:14:22 +00:00
Jakub Zelenka
ec3d4409a4
Merge branch 'PHP-7.4' into PHP-8.0
2021-11-14 20:10:42 +00:00
Jakub Zelenka
b2cf9b7ec7
Fix bug #81513 (Future possibility for heap overflow in FPM zlog)
...
This fixes currently unused code path in zlog that could lead to
the heap overflow in the future.
2021-11-14 20:08:57 +00:00
Nikita Popov
4a5d75e3ec
Merge branch 'PHP-8.0' into PHP-8.1
...
* PHP-8.0:
Fix leaks for AppArmor based distros in case the profile creation fails
2021-11-12 14:26:03 +01:00
David Carlier
b1e6fdefd4
Fix leaks for AppArmor based distros in case the profile creation fails
...
Closes GH-7646.
2021-11-12 14:25:52 +01:00
Stanislav Malyshev
0acfd2d7b5
Merge branch 'PHP-8.0' into PHP-8.1
...
* PHP-8.0:
Fix bug #81026 (PHP-FPM oob R/W in root process leading to priv escalation)
Add FPM fix news
Fix bug #81026 (PHP-FPM oob R/W in root process leading to priv escalation)
2021-10-18 15:23:08 -07:00
Jakub Zelenka
fadb1f8c1d
Fix bug #81026 (PHP-FPM oob R/W in root process leading to priv escalation)
...
The main change is to store scoreboard procs directly to the variable sized
array rather than indirectly through the pointer.
Signed-off-by: Stanislav Malyshev <stas@php.net >
2021-10-18 15:06:36 -07:00
David Carlier
f71810fb6f
Fix some FPM printf warnings on openbsd
...
Closes GH-7585.
2021-10-18 11:11:33 +02:00
Jakub Zelenka
cb2021e5f6
Fix bug #81026 (PHP-FPM oob R/W in root process leading to priv escalation)
...
The main change is to store scoreboard procs directly to the variable sized
array rather than indirectly through the pointer.
Signed-off-by: Stanislav Malyshev <stas@php.net >
2021-10-17 20:16:10 -07:00