1179686f62
Improve error messages for invalid property access
...
Closes GH-5446
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com >
2020-05-18 08:27:00 +02:00
bbda71b63d
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Revert "Fix #79065 : DOM classes do not expose properties to Reflection"
2020-04-28 15:10:23 +02:00
75470bc312
Revert "Fix #79065 : DOM classes do not expose properties to Reflection"
...
This reverts commit 6bc8f7e5a9
2020-04-28 15:09:41 +02:00
ecc6b8cc29
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #79065 : DOM classes do not expose properties to Reflection
2020-04-27 10:28:00 +02:00
6bc8f7e5a9
Fix #79065 : DOM classes do not expose properties to Reflection
...
We add a `get_properties` handler which complements the already
existing `has_property` and `read_property`handlers.
2020-04-27 10:04:29 +02:00
68139dbdd8
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #78221 : DOMNode::normalize() doesn't remove empty text nodes
2020-04-07 13:09:10 +02:00
13c9572a79
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #78221 : DOMNode::normalize() doesn't remove empty text nodes
2020-04-07 13:07:33 +02:00
efec22b7be
Fix #78221 : DOMNode::normalize() doesn't remove empty text nodes
...
If a text node is not followed by another text node, we remove it, if
its textContent is empty.
2020-04-07 13:04:14 +02:00
01b266aac4
Improve error messages of various extensions
...
Closes GH-5278
2020-03-23 18:59:04 +01:00
0d913f9acf
Fix another memory leak in dom_zvals_to_fragment.
2020-03-06 00:03:13 +01:00
5acd86df8e
[RFC] Implement new DOM Living Standard APIs in ext/dom
2020-02-28 16:13:39 +01:00
406c5d5956
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #79271 : DOMDocumentType::$childNodes is NULL
2020-02-17 09:10:39 +01:00
73a4c50309
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #79271 : DOMDocumentType::$childNodes is NULL
2020-02-17 09:09:30 +01:00
0966941130
Fix #79271 : DOMDocumentType::$childNodes is NULL
...
Dom level 2 core, DOM level 3 core and the DOM living standard agree
that `childNodes` always return a `NodeList`, and never `null`.
2020-02-17 09:07:54 +01:00
95ea8b08b8
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix typo in recent bugfix
2020-02-14 09:24:38 +01:00
8ec76366d0
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix typo in recent bugfix
2020-02-14 09:23:43 +01:00
392dada1d6
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
Fix typo in recent bugfix
2020-02-14 09:22:51 +01:00
8308196c97
Fix typo in recent bugfix
2020-02-14 09:21:13 +01:00
a957e84c58
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #77569 : Write Acess Violation in DomImplementation
2020-02-13 15:17:25 +01:00
bf8c6519fb
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #77569 : Write Acess Violation in DomImplementation
2020-02-13 15:16:09 +01:00
8ebadd1128
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
Fix #77569 : Write Acess Violation in DomImplementation
2020-02-13 15:15:05 +01:00
cec8b24c84
Fix #77569 : Write Acess Violation in DomImplementation
...
We must not assume that the zval IS_STRING.
2020-02-13 15:13:26 +01:00
74da772933
Fix stub for DomImplementation::createDocumentType()
2020-02-10 10:48:18 +01:00
e9b991d6a0
Fix ext/dom test helper method causing trailing whitespaces.
2020-02-06 22:24:37 +01:00
f8d795820e
Reindent phpt files
2020-02-03 22:52:20 +01:00
2015c7a48e
Fix another batch of indentation in tests
2020-02-02 23:33:40 +01:00
99db00b1f2
Fix #78880 Another round
2020-01-19 18:28:43 +01:00
afdaa91170
Fix #78880 : Final spelling fixes
2020-01-16 19:14:31 +01:00
0b4778c377
Fix #78880 : Another bunch of spelling errors
2020-01-16 09:46:47 +01:00
4253ca486d
Convert ext/dom to use arginfo stub.
2019-11-08 15:05:35 +01:00
a555cc0b3d
Clean DONE tags from tests
...
Remove most of the `===DONE===` tags and its variations.
Keep `===DONE===` if the test output otherwise becomes empty.
Closes GH-4872.
2019-11-07 21:31:47 +01:00
32d3dbf789
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix test cases for libxml2 2.9.10
2019-10-31 16:10:18 +01:00
db14b78099
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix test cases for libxml2 2.9.10
2019-10-31 16:09:38 +01:00
e175a0a1c8
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
Fix test cases for libxml2 2.9.10
2019-10-31 16:08:38 +01:00
e29922f054
Fix test cases for libxml2 2.9.10
...
Since the error reporting has been slightly changed, we have to adapt
the two affected test cases.
2019-10-31 16:07:34 +01:00
8a88f72beb
Merge branch 'PHP-7.4'
2019-10-26 16:08:00 +02:00
601aef3468
Replace EXPECTF by EXPECT
...
In ext/dom all the tests with a EXPECTF section
starting by "Fatal error: Uncaught" have been updated
to use the faster EXPECT
2019-10-26 16:05:02 +02:00
23f3b54906
Merge branch 'PHP-7.4'
2019-10-19 15:44:57 +02:00
550a2df043
Add tests for DOMEntityReference
2019-10-19 15:42:16 +02:00
3d22c80fc2
Test an error case with DOMDocument::createEntityReference
2019-10-15 21:56:44 +02:00
6c963694b1
ext/dom: Add global registerNodeNS flag on DOMXPath ctor and property.
2019-10-05 18:56:58 +02:00
2f92957fd3
Convert some notices to warnings
...
Part of https://wiki.php.net/rfc/engine_warnings .
2019-10-02 10:34:08 +02:00
01fc1a3057
Remove most uses of the ERROR type
...
It is now only used to signal exceptions for property reads. ERROR
zvals are never returned back to the VM anymore, so there's no
need to check for them when receiving a VAR.
Also return MAY_BE_ERROR, as ERROR is now no longer relevant for
inference.
2019-09-30 11:35:07 +02:00
a66c60cce3
Throw Error when writing property of non-object
...
This removes object auto-vivification support.
This also means that we can remove the corresponding special
handling for typed properites: We no longer need to check that a
property is convertible to stdClass if such a conversion might
take place indirectly due to a nested property write.
Additionally OBJ_W style operations now no longer modify the
object operand, and as such we no longer need to treat op1 as a
def in SSA form.
The next step would be to actually compile the whole LHS of OBJ_W
operations in R rather than W mode, but that causes issues with
SimpleXML, whose object handlers depend on the current compilation
structure.
Part of https://wiki.php.net/rfc/engine_warnings .
2019-09-27 10:11:47 +02:00
c0c1f9d38c
Add missing SKIPIF
2019-09-04 08:36:11 +02:00
a31f46421d
Allow exceptions in __toString()
...
RFC: https://wiki.php.net/rfc/tostring_exceptions
And convert some object to string conversion related recoverable
fatal errors into Error exceptions.
Improve exception safety of internal code performing string
conversions.
2019-06-05 14:25:07 +02:00
d3c95db18c
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #78025 : segfault when accessing properties of DOMDocumentType
2019-05-17 13:32:53 +02:00
fd607635a4
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
Fix #78025 : segfault when accessing properties of DOMDocumentType
2019-05-17 13:32:13 +02:00
e246dea9fe
Fix #78025 : segfault when accessing properties of DOMDocumentType
...
Instead of following the NULL pointer, we return an empty string.
2019-05-17 13:31:18 +02:00
26dfce7f36
Replace dirname(__FILE__) by __DIR__ in tests
2019-03-15 22:55:30 +01:00
Máté Kocsis