Máté Kocsis
1bba691ecc
Generate method entries for ext/session and ext/reflection
...
Closes GH-5376
2020-04-13 13:04:06 +02:00
Máté Kocsis
ca006e54e3
Add missing visibility modifiers in stubs
2020-04-11 10:23:51 +02:00
Máté Kocsis
5868aced2e
Fix the default parameter values of session_set_save_handler()
...
Co-Authored-By: Christoph M. Becker <cmbecker69@gmx.de >
2020-04-10 17:07:26 +02:00
Máté Kocsis
3709e74b5e
Store default parameter values of internal functions in arg info
...
Closes GH-5353. From now on, PHP will have reflection information
about default values of parameters of internal functions.
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com >
2020-04-08 18:37:51 +02:00
Máté Kocsis
21cfa03f17
Generate function entries for another batch of extensions
...
Closes GH-5352
2020-04-05 21:15:30 +02:00
Máté Kocsis
a43bc33fb2
Annotate function aliases in stubs
2020-04-04 13:03:16 +02:00
Máté Kocsis
36935e42ea
Improve undefined variable error messages
...
Closes GH-5312
2020-03-31 13:02:32 +02:00
Christoph M. Becker
12ca4fe65d
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #79413 : session_create_id() fails for active sessions
2020-03-31 08:41:08 +02:00
Christoph M. Becker
d533fa15e6
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #79413 : session_create_id() fails for active sessions
2020-03-31 08:39:54 +02:00
Christoph M. Becker
b510250b8e
Fix #79413 : session_create_id() fails for active sessions
...
The comment on `PS_VALIDATE_SID_FUNC(files)` is very clear that the
function is supposed to return `SUCCESS` if the session already exists.
So to detect a collision, we have to check for `SUCCESS`, not
`FAILURE`.
We also fix the wrong condition in session_regenerate_id() as well.
2020-03-31 08:38:23 +02:00
Christoph M. Becker
b31f73b1c8
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Enclose INI values containing {TMP} in quotes
2020-03-09 22:53:23 +01:00
Christoph M. Becker
fea2994ff8
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Enclose INI values containing {TMP} in quotes
2020-03-09 22:51:11 +01:00
Christoph M. Becker
d5e206620b
Enclose INI values containing {TMP} in quotes
...
At least on Windows, the temporary directory may contain tilde signs,
which would result in an INI parse error.
2020-03-09 22:49:08 +01:00
Máté Kocsis
960318ed95
Change argument error message format
...
Closes GH-5211
2020-02-26 15:00:08 +01:00
Máté Kocsis
ac0853eb26
Make type error messages more consistent
...
Closes GH-5092
2020-02-17 14:22:17 +01:00
Stanislav Malyshev
90ae1818d5
Fix bug #79221 - Null Pointer Dereference in PHP Session Upload Progress
2020-02-17 00:20:31 -08:00
Stanislav Malyshev
282bfb109e
Fix bug #79221 - Null Pointer Dereference in PHP Session Upload Progress
2020-02-17 00:20:17 -08:00
Stanislav Malyshev
409965fe1c
Fix bug #79221 - Null Pointer Dereference in PHP Session Upload Progress
2020-02-17 00:19:30 -08:00
Nikita Popov
f8d795820e
Reindent phpt files
2020-02-03 22:52:20 +01:00
Stanislav Malyshev
545f77d313
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Update NEWS
Fix bug #79037 (global buffer-overflow in `mbfl_filt_conv_big5_wchar`)
Fix #79099 : OOB read in php_strip_tags_ex
Fix #79091 : heap use-after-free in session_create_id()
2020-01-20 22:47:28 -08:00
Stanislav Malyshev
a29c793381
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Update NEWS
Fix bug #79037 (global buffer-overflow in `mbfl_filt_conv_big5_wchar`)
Fix #79099 : OOB read in php_strip_tags_ex
Fix #79091 : heap use-after-free in session_create_id()
2020-01-20 22:47:01 -08:00
Stanislav Malyshev
25ec7eb346
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
Update NEWS
Fix bug #79037 (global buffer-overflow in `mbfl_filt_conv_big5_wchar`)
Fix #79099 : OOB read in php_strip_tags_ex
Fix #79091 : heap use-after-free in session_create_id()
2020-01-20 22:46:29 -08:00
Christoph M. Becker
f79c774274
Fix #79091 : heap use-after-free in session_create_id()
...
If the `new_id` is released, we must not use it again.
2020-01-20 21:43:42 -08:00
Máté Kocsis
d1764ca330
Make error messages more consistent by fixing capitalization
...
Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
2020-01-17 14:52:46 +01:00
Máté Kocsis
349a286461
Use RETURN_THROWS() after zend_throw_error()
2020-01-01 16:42:30 +01:00
Máté Kocsis
345703724c
Use RETURN_THROWS() during ZPP in most of the extensions
...
Except for some bigger ones: reflection, sodium, spl
2019-12-31 11:46:11 +01:00
Nikita Popov
d8bd113b51
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Add test for bug #79031
Revert "Increase serialize_lock while decoding session"
2019-12-30 11:31:56 +01:00
Nikita Popov
fcaf7cbd64
Add test for bug #79031
...
Fixed by preceding revert.
2019-12-30 11:31:27 +01:00
Nikita Popov
ed3811e781
Revert "Increase serialize_lock while decoding session"
...
This reverts commit b8ef7c35ab .
See bug #79031 . The semantics of serialize locking aren't quite
correct right now, and the use of the lock in this particular
place makes us hit the issue in a common case. I'm reverting this
commit for PHP 7.4 and will try to fix this properly for PHP 8,
as I believe it will require ABI breakage.
2019-12-30 11:27:13 +01:00
Máté Kocsis
27e83d0fb8
Add union return types for function stubs
2019-11-11 14:54:55 +01:00
Fabien Villepinte
a555cc0b3d
Clean DONE tags from tests
...
Remove most of the `===DONE===` tags and its variations.
Keep `===DONE===` if the test output otherwise becomes empty.
Closes GH-4872.
2019-11-07 21:31:47 +01:00
Máté Kocsis
2204dbde3b
Add missing ZPP checks
...
Closes GH-4878.
2019-11-01 15:26:52 +01:00
Máté Kocsis
9493893412
Cleanup return values when parameter parsing is unsuccessful
2019-10-30 16:05:20 +01:00
Nikita Popov
4802df5b3c
Merge branch 'PHP-7.4'
2019-10-07 16:44:44 +02:00
Nikita Popov
638ac2efc4
Merge branch 'PHP-7.3' into PHP-7.4
2019-10-07 16:44:39 +02:00
Nikita Popov
2624c9a505
Merge branch 'PHP-7.2' into PHP-7.3
2019-10-07 16:44:31 +02:00
Nikita Popov
7d19668f60
Set session.gc_probability=0 in bug78624.phpt
...
We only want to test manually triggered session GC.
Avoid spurious output due to automatic GC.
2019-10-07 16:43:19 +02:00
Joe Watkins
26baf5454b
Merge branch 'PHP-7.4'
...
* PHP-7.4:
fix #78624 : session_gc return value for user defined session handlers
2019-10-04 06:16:41 +02:00
Joe Watkins
74ca3a5cad
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
fix #78624 : session_gc return value for user defined session handlers
2019-10-04 06:16:18 +02:00
Joe Watkins
f45eb353d1
Merge branch 'PHP-7.2' into PHP-7.3
...
* PHP-7.2:
fix #78624 : session_gc return value for user defined session handlers
2019-10-04 06:12:29 +02:00
Brent Shaffer
a6d219630c
fix #78624 : session_gc return value for user defined session handlers
2019-10-04 06:12:02 +02:00
Nikita Popov
2f92957fd3
Convert some notices to warnings
...
Part of https://wiki.php.net/rfc/engine_warnings .
2019-10-02 10:34:08 +02:00
Nikita Popov
0ebf2bdba0
Convert "Illegal offset type" warnings to exceptions
2019-09-27 13:00:07 +02:00
Gabriel Caruso
5d6e923d46
Remove mention of PHP major version in Copyright headers
...
Closes GH-4732.
2019-09-25 14:51:43 +02:00
Nikita Popov
fb60ccc666
Merge branch 'PHP-7.4'
2019-09-25 11:03:19 +02:00
Nikita Popov
b8ef7c35ab
Increase serialize_lock while decoding session
...
Avoid leaking state between Serializable::unserialize() and
session_decode().
2019-09-25 11:02:23 +02:00
Craig Duncan
1fc2fec138
Convert session functions arginfo to php stubs
2019-09-18 10:59:57 +02:00
Fabien Villepinte
7e8f11531e
Make some session tests more robust
2019-09-16 15:20:32 +02:00
Christoph M. Becker
68edbbfe76
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Add the last missing SKIPIF
2019-09-04 08:54:07 +02:00
Fabien Villepinte
ced5bb7d88
Add the last missing SKIPIF
2019-09-04 08:53:35 +02:00