70a3a909cd
Add the Z_PARAM_PATH_OR_NULL() and Z_PARAM_ZVAL_OR_NULL() macros
2020-07-24 10:37:35 +02:00
0a5b7c81b7
Make nested ternary without parentheses a compile error
...
This was deprecated in PHP 7.4.
2020-07-24 10:35:42 +02:00
9bf119832d
Implement nullsafe ?-> operator
...
RFC: https://wiki.php.net/rfc/nullsafe_operator
Closes GH-5619.
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com >
2020-07-24 10:05:03 +02:00
1e938e8eba
Fix build
...
MSVC is pretty picky there, so we add the `ZEND_VOIDP` cast.
2020-07-22 22:57:58 +02:00
f1436c4832
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix minor memory leak of CG(script_encoding_list)
2020-07-22 20:34:21 +02:00
c1a80e075a
Fix minor memory leak of CG(script_encoding_list)
...
This only leaks at the end of the process, so per se not an issue, but
the leak is caught by MSVC's CRT leak checker, so we better properly
clean up to avoid false positives.
2020-07-22 20:32:48 +02:00
6e92487f66
Fix warnings of strict-prototypes
...
Closes GH-5887.
2020-07-23 00:59:00 +08:00
a65ec4c2db
Change type of max_num_args to uint32_t
...
Closes GH-5885.
2020-07-23 00:55:58 +08:00
e29ee65ec0
Export zend_register_error_notify_callback() with ZEND_API
2020-07-23 00:45:06 +08:00
7a3dcc3e33
Treat namespaced names as single token
...
Namespace names are now lexed as single tokens of type
T_NAME_QUALIFIED, T_NAME_FULLY_QUALIFIED or T_NAME_RELATIVE.
RFC: https://wiki.php.net/rfc/namespaced_names_as_token
Closes GH-5827.
2020-07-22 12:36:05 +02:00
acbf7802af
Improved number to string comparison semantics
...
RFC: https://wiki.php.net/rfc/string_to_number_comparison
Closes GH-3886.
2020-07-22 12:23:49 +02:00
4cf8b6f1c9
Support optional comma in closure use list
...
RFC: https://wiki.php.net/rfc/trailing_comma_in_closure_use_list
Discussion: https://externals.io/message/110715
The release manager has agreed to allow merging of RFCs that have near-unanimous
votes. If an RFC ends up not achieving the required 2/3 majority at the time the
announced voting period closes, this implementation commit will be reverted
in time for the feature freeze.
Closes GH-5793
2020-07-21 13:01:27 -04:00
e079e753dc
Give zend_pass_function an arginfo
...
Now that the ZEND_ACC_VARIADIC flag is set, we should also make
sure there is a variadic arg that can be looked up.
2020-07-21 16:01:45 +02:00
5770b66722
Cleanup argument handling of Zend functions and methods
...
Closes GH-5847
2020-07-21 14:47:03 +02:00
c9881fde7a
Run arginfo / zpp mismatch tests for methods as well
...
As a side-effect, this also catches issues where classes are not
prepared for use with newInstanceWithoutConstructor.
2020-07-21 14:17:29 +02:00
38fb1f8383
Check for missing arginfo arguments
...
Internal functions error when too many arguments are passed. Make
this part of the verification we do in debug builds. This will
help avoid cases where an argument is missing in the stubs,
as recently encountered in 6d96f0f
2020-07-21 14:17:29 +02:00
236ddc56a2
Preserve original ce_flags when registering class
...
Bug that regularly sneaks in: ZEND_ACC_FINAL is set before calling
zend_register_internal_class() and promptly gets ignored. Remove
this footgun by preserving flags from the original CE.
2020-07-20 17:00:04 +02:00
7fd4212cc0
Add common code for magic method assignment
...
This was repeated three times.
2020-07-20 14:57:10 +02:00
efce3694b7
Directly assign magic methods
...
Instead of going through intermediary variables.
2020-07-20 11:22:47 +02:00
91e5452b95
Remove unused lc_class_name variable
...
This is probably a leftover from "old style constructor" support.
2020-07-20 11:15:58 +02:00
19de727e04
Report magic method names as written
...
Report the name the way the user has written it, the same way we
always do.
2020-07-20 11:12:47 +02:00
149029b9d6
Unify magic method visibility check
...
This was missing entirely for the internal function case.
2020-07-20 11:12:47 +02:00
312fe2bdce
Unify magic method return type checks
2020-07-20 10:51:48 +02:00
fbbcf82ab7
Unify static/non-static check for magic methods
...
And promote it to be fatal.
2020-07-20 10:39:43 +02:00
b466e8b754
Add missing arg num check for __set_state
2020-07-20 10:20:29 +02:00
dcaf62f3d3
Clean up zend_check_magic_method_implementation
...
Let everything go through a common function, which fixes some
consistency issues.
2020-07-20 10:17:40 +02:00
f9ced0d4f7
Add missing zpp_none call in Exception::__wakeup
2020-07-17 16:06:54 +02:00
fa60f57be4
Drop unused param in zend_parse_arg_class_name_or_obj()
2020-07-17 17:00:27 +02:00
86a62eb1fc
Fixed bug #79867
...
In line with usual rules, give untyped properties a null default
value. Otherwise constructor promotion would give you a property
declaration that cannot be achieved through any other means.
2020-07-17 15:10:45 +02:00
6c8b94eb42
Introduce error notification callbacks that are run independant of zend_error_cb
2020-07-17 15:08:11 +02:00
6d96f0f9ce
Fix WeakReference::create() stub
2020-07-16 20:46:45 +02:00
272b887b7b
Ignore inheritance rules on private methods
...
Closes GH-5401
2020-07-15 17:09:57 +01:00
5785a15f4e
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79862
2020-07-15 15:00:45 +02:00
e8430b592f
Fixed bug #79862
...
While normally a private property in the active scope would take
priority, we should not use this if it has the wrong "staticness".
2020-07-15 14:59:55 +02:00
f60cf0cfe7
Remove type argument from zend_get_zval_ptr
...
As pointed out by Levi, this is unused, and we already changed
the signature of this function for PHP 8.
2020-07-15 09:51:51 +02:00
70501b81a7
Fixed bug #79852
2020-07-14 12:31:06 +02:00
4f3eccfd4d
Use consistent types
...
uint32_t type for argument count
size_t for length of char*
zend_bool for a zval bool arg
Closes GH-5845
2020-07-13 13:30:54 +02:00
55a15f32ce
Improve output of tokens in Parse Errors
...
Currently, unexpected tokens in the parser are shown as the text
found, plus the internal token name, including the notorious
"unexpected '::' (T_PAAMAYIM_NEKUDOTAYIM)".
This commit replaces that with a more user-friendly format, with
two main types of token:
* Tokens which always represent the same text are shown like
'unexpected token "::"' and 'expected "::"'
* Tokens which have variable text are given a user-friendly
name, and show like 'unexpected identifier "foo"', and
'expected identifer'.
A few tokens have special cases:
* unexpected token """ -> unexpected double-quote mark
* unexpected quoted string "'foo'" -> unexpected single-quoted
string "foo"
* unexpected quoted string ""foo"" -> unexpected double-quoted
string "foo"
* unexpected illegal character "_" -> unexpected character 0xNN
(where _ is almost certainly a control character, and NN is the
hexadecimal value of the byte)
The \ token has a special case in the implementation just to stop
bison making a mess of escaping it and it coming out as \\
2020-07-13 11:07:40 +02:00
213852de78
Fixed bug #79828
2020-07-13 09:55:13 +02:00
1c967df5a0
Fix free of uninitialized memory in MATCH_ERROR
...
As suggested by Tyson Andre:
https://github.com/php/php-src/pull/5371#issuecomment-657081464
Also fix line number of unhandled match error
Closes GH-5841.
2020-07-12 13:33:36 +02:00
d5a0370828
[skip ci] Consistent match test closing tags
2020-07-11 16:50:51 +02:00
95cff3ebf2
Retain the original formatting character in test
2020-07-10 23:15:08 +02:00
d30cd7d7e7
Review the usage of apostrophes in error messages
...
Closes GH-5590
2020-07-10 21:05:28 +02:00
2297a6d364
Use dedicated function for illegal offset type error
2020-07-10 16:49:52 +02:00
5fc70243d7
Add missing addref for MATCH_ERROR operand
2020-07-10 15:58:42 +02:00
6556846754
Fixed bug #79818
...
Only destroy the variable directly before reassigning it. The
value could be read in the meantime.
2020-07-10 14:36:50 +02:00
b284ba3943
Add zend_wrong_parameter_error to reduce the size of ZPP macro
...
Closes GH-5831.
2020-07-10 10:12:23 +02:00
9fa1d13301
Implement match expression
...
RFC: https://wiki.php.net/rfc/match_expression_v2
Closes GH-5371.
2020-07-09 23:52:17 +02:00
9839752a9c
Voidify some ZEND_API functions
...
Closes GH-5805
2020-07-09 14:15:57 +02:00
613a56d1cb
Remove FREE_UNFETCHED concept
...
In master normal FREE_OPs work like FREE_UNFETCHED_OP used to, so
there is no point in keeping this distinction anymore, it's just
confusing.
2020-07-09 11:58:33 +02:00
Máté Kocsis