archived-php-src

php/archived-php-src

Fork 0

mirror of https://github.com/php/php-src.git synced 2026-04-26 17:38:14 +02:00

Commit Graph

Author	SHA1	Message	Date
Christoph M. Becker	b510250b8e	Fix #79413 : session_create_id() fails for active sessions The comment on `PS_VALIDATE_SID_FUNC(files)` is very clear that the function is supposed to return `SUCCESS` if the session already exists. So to detect a collision, we have to check for `SUCCESS`, not `FAILURE`. We also fix the wrong condition in session_regenerate_id() as well.	2020-03-31 08:38:23 +02:00
Christoph M. Becker	f79c774274	Fix #79091 : heap use-after-free in session_create_id() If the `new_id` is released, we must not use it again.	2020-01-20 21:43:42 -08:00

Author

SHA1

Message

Date

Christoph M. Becker

b510250b8e

Fix #79413 : session_create_id() fails for active sessions

The comment on `PS_VALIDATE_SID_FUNC(files)` is very clear that the
function is supposed to return `SUCCESS` if the session already exists.
So to detect a collision, we have to check for `SUCCESS`, not
`FAILURE`.

We also fix the wrong condition in session_regenerate_id() as well.

2020-03-31 08:38:23 +02:00

Christoph M. Becker

f79c774274

Fix #79091 : heap use-after-free in session_create_id()

If the `new_id` is released, we must not use it again.

2020-01-20 21:43:42 -08:00

2 Commits