Nikita Popov
5bfa9598f4
Return false from failed mb_convert_variables()
...
If we fail to detect the encoding return false, just like
mb_convert_encoding() does, and the implementation here clearly
intended. Previously the "pass" pseudo-incoding was returned.
2020-05-07 10:16:46 +02:00
Christoph M. Becker
1a95ed0b33
Enable test on Windows
2020-05-07 09:20:15 +02:00
Dmitry Stogov
7977cd1c19
Fixed comment
2020-05-07 09:05:33 +03:00
Nikita Popov
71f48260af
Fix assertion failure when failing to detect encoding
...
Looks like prior to 7.3 this just passed the original string
through. Since 7.3 it returns false. Let's stick with that
behavior.
2020-05-06 22:56:01 +02:00
Dmitry Stogov
9d869f24d4
Avoid Program Counter guard in side trace started from Fake Init Fcall guard.
2020-05-06 23:16:45 +03:00
George Peter Banyard
038502b92a
Use int|string Fast ZPP macro in Reflection
...
Moreover, throw a more appropriate ValueError in case the integer
position provided is less than 0.
Closes GH-5513
2020-05-06 21:51:59 +02:00
Dmitry Stogov
b63eff17ff
Initial support for IS_INDIRECT. Avoid type guards for IS_INDIRECT.
2020-05-06 22:27:38 +03:00
Máté Kocsis
bce8c8fb27
Promote warning to exception in ZipArchive::extractTo()
...
Closes GH-5516
2020-05-06 19:22:52 +02:00
Máté Kocsis
650da66e2d
Fix UNKNOWN default values in ext/spl
2020-05-06 19:15:39 +02:00
Máté Kocsis
35a10fb8e8
Fix UNKNOWN default values in ext/sqlite3
2020-05-06 19:15:39 +02:00
Máté Kocsis
60412c37ae
Fix UNKNOWN default values in ext/xml
2020-05-06 19:15:39 +02:00
Máté Kocsis
89d1707587
Fix UNKNOWN default values in ext/xsl
2020-05-06 19:15:38 +02:00
Máté Kocsis
daa5b26456
Fix UNKNOWN default values in ext/zip
2020-05-06 19:15:34 +02:00
Máté Kocsis
78dda268eb
Fix ZPP order in ext/zip
2020-05-06 19:14:36 +02:00
George Peter Banyard
389c2b4303
Drop BF_ASM constant as it's always 0
...
Closes GH-5531
2020-05-06 17:55:32 +02:00
Christoph M. Becker
822c489961
Remove out-dated comments
2020-05-06 17:25:49 +02:00
Máté Kocsis
eab54d2382
Convert resource to object in ext/sysvsem
...
Closes GH-5508
2020-05-06 15:42:41 +02:00
Dmitry Stogov
776b1aefc8
Careful cleanup
2020-05-06 16:26:36 +03:00
Remi Collet
f987219c69
add myself as enchant maintainer
2020-05-06 13:18:35 +02:00
Christoph M. Becker
c1ad9163b8
Fix enchant stub
2020-05-06 13:16:50 +02:00
Remi Collet
5f5dd994d4
enchant: bump license version
2020-05-06 13:13:19 +02:00
Máté Kocsis
3ebce8e9fc
Fix UNKNOWN default values in various extensions
...
Closes GH-5514
2020-05-05 19:08:20 +02:00
Nikita Popov
5bc1e224db
Make numeric operations on resources, arrays and objects type errors
...
RFC: https://wiki.php.net/rfc/arithmetic_operator_type_checks
Closes GH-5331.
2020-05-05 16:11:13 +02:00
William Hudgins
31fb6a08b3
Add str_starts_with() and str_ends_with()
...
RFC: https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions
Closes GH-5300.
2020-05-05 16:03:47 +02:00
Christoph M. Becker
e749db4047
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #79566 : Private SHM is not private on Windows
2020-05-05 11:41:31 +02:00
Christoph M. Becker
80b5006196
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #79566 : Private SHM is not private on Windows
2020-05-05 11:41:04 +02:00
Christoph M. Becker
f33cf52faf
Fix #79566 : Private SHM is not private on Windows
...
We map the POSIX semantics of `IPC_PRIVATE` by creating unnamed file
mapping objects on Windows. While that is not particularly useful for
ext/shmop, which is the only bundled extension which uses `shmget()`,
it may be useful for external extensions.
2020-05-05 11:38:29 +02:00
Nikita Popov
901417f0ae
Fix mbfl default allocators
...
Forgot to remove the persistent allocators from here.
2020-05-04 23:41:39 +02:00
Nikita Popov
a0cae937c5
Spec mbfl allocators as infallible
...
And remove all NULL checks.
2020-05-04 23:19:07 +02:00
Nikita Popov
7d4ff8443e
Remove persistent allocators from libmbfl
...
These functions are not used, and I don't think we have any plans
to ever use them.
2020-05-04 23:19:07 +02:00
Christoph M. Becker
6086343a91
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fix #79561 : dns_get_record() fails with DNS_ALL
2020-05-04 23:02:00 +02:00
Christoph M. Becker
ed6bf0bc69
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fix #79561 : dns_get_record() fails with DNS_ALL
2020-05-04 23:00:56 +02:00
Christoph M. Becker
c40a494406
Fix #79561 : dns_get_record() fails with DNS_ALL
...
Since Windows has its own definitions of the `PHP_DNS_*` macros, we
have to use these when registering the PHP constants.
2020-05-04 22:59:38 +02:00
AllenJB
50752401a7
Change the default PDO error mode to exceptions
...
According to <https://www.php.net/manual/en/pdo.error-handling.php >.
2020-05-04 22:51:47 +02:00
Nikita Popov
4c24545aab
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79548
2020-05-04 16:30:34 +02:00
Nikita Popov
21a9ad910b
Fixed bug #79548
...
When duplicating user functions with static variables, make sure
that we init a new map ptr slot for the static variables.
2020-05-04 16:27:45 +02:00
Nikita Popov
2dc4481fa9
Extract one more function from proc_open() implementation
2020-05-04 15:24:23 +02:00
Alex Dowad
51b0494e2f
Clean up proc_open() implementation
...
Closes GH-5507.
2020-05-04 15:04:58 +02:00
Nikita Popov
66d57bf8d6
Remove unused is_persistent flag
...
I dropped the assignment to it before, but did not drop the
struct member.
2020-05-04 14:59:35 +02:00
Nikita Popov
f55b413d60
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Fixed bug #79535
2020-05-04 14:52:42 +02:00
Nikita Popov
733d84dbdf
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Fixed bug #79535
2020-05-04 14:52:18 +02:00
Nikita Popov
7c1316ec6a
Fixed bug #79535
...
We did not allocate a cache slot for FETCH_CLASS. This is already
fixed on newer PHP versions.
2020-05-04 14:51:18 +02:00
George Peter Banyard
8d346f7679
Use ZPP int|string and add ValueError for Windows codepages
...
Closes GH-5517
2020-05-04 12:44:54 +02:00
Christoph M. Becker
2787d0f8dd
Merge branch 'PHP-7.4'
...
* PHP-7.4:
Add basic sapi_windows_cp_conv() test
2020-05-04 11:52:01 +02:00
Christoph M. Becker
ef54899fd1
Merge branch 'PHP-7.3' into PHP-7.4
...
* PHP-7.3:
Add basic sapi_windows_cp_conv() test
2020-05-04 11:50:50 +02:00
Christoph M. Becker
d950969e59
Add basic sapi_windows_cp_conv() test
...
This function is lacking any tests so far.
2020-05-04 11:50:03 +02:00
Christoph M. Becker
54cf9a26c1
Use libenchant2 if available on Windows
...
This is basically the same as commit 3427545[1], but for Windows.
[1] <http://git.php.net/?p=php-src.git;a=commitdiff;h=342754575237da912874f781a24eefe76434ce5a >
2020-05-04 11:27:00 +02:00
Remi Collet
3427545752
Use libenchant-2 when available
2020-05-04 08:27:31 +02:00
Christoph M. Becker
69888c3ff1
Fix #79467 : data:// wrappers are writable
...
Despite the docs claiming that data: wrappers would not be writable[1],
they are implemented as writing to a memory stream. That does not seem
to be particularly sensible, so we disallow writing altogether.
[1] <https://www.php.net/manual/en/wrappers.data.php#refsect1-wrappers.data-options >
2020-05-03 12:19:37 +02:00
George Peter Banyard
34f727e637
Use ZPP check for string|int|null arguments in array_column()
2020-05-02 19:50:51 +02:00