archived-php-src

php/archived-php-src

Fork 0

mirror of https://github.com/php/php-src.git synced 2026-03-27 17:52:16 +01:00

Commit Graph

Author	SHA1	Message	Date
Christoph M. Becker	f1d11c118d	Fix #62004 : SplFileObject: fgets after seek returns wrong line As it is, `::seek(0)` sets the file pointer to the beginning of the file, but `::seek($n)` where `$n > 0` sets the file pointer to the beginning of the following line, having line `$n` already read into the line buffer. This is pretty inconsistent; we fix it by always seeking to the beginning of the line. We also add a test case for the duplicate bug #46569. Closes GH-6434.	2020-11-30 16:03:37 +01:00
donnut	2cb7a678a1	new tests from PHP TestFest June 2012	2012-07-14 19:21:34 -07:00

Author

SHA1

Message

Date

Christoph M. Becker

f1d11c118d

Fix #62004 : SplFileObject: fgets after seek returns wrong line

As it is, `::seek(0)` sets the file pointer to the beginning of the
file, but `::seek($n)` where `$n > 0` sets the file pointer to the
beginning of the following line, having line `$n` already read into the
line buffer.  This is pretty inconsistent; we fix it by always seeking
to the beginning of the line.

We also add a test case for the duplicate bug #46569.

Closes GH-6434.

2020-11-30 16:03:37 +01:00

donnut

2cb7a678a1

new tests from PHP TestFest June 2012

2012-07-14 19:21:34 -07:00

2 Commits