d8577d9bfb
Deprecate returning non-string values from a user output handler ( #18932 )
...
https://wiki.php.net/rfc/deprecations_php_8_4
2025-07-07 14:31:13 -07:00
7f80d4dc7d
ext/session: Remove bool type coercions in tests
2025-06-23 14:57:13 +02:00
84d6cb8cf0
Unify headers already sent/session already started error handler ( #16451 )
...
* Unify headers already sent errors
Now whenever we need to check where headers were already sent in
ext/session, we call a single location that prints where, keeping it
consistent output wise.
* Unify session aready started errors
Similar to the one for headers.
* Also change session active checks too
This usually go hand in hand with the headers already sent checks, but
is in a separate commit because of the amount of tests it changes.
2024-10-17 13:13:56 -03:00
217ea732fc
Use php_error_docref() instead of zend_error() in session.c (GH-15505)
...
Using `php_error_docref()` is preferable since it outputs additional
details (which function has been called and whether it is a startup or
shutdown error), uses HTML markup, and also provides a link to the
documentation, if configured.
Since these deprecation warnings have been introduced recently[1][2],
i.e. for PHP 8.4, there are no BC concerns.
[1] <https://github.com/php/php-src/commit/e8ff7c70f9669f1a54c47c018ccc0f80bc0c929b >
[2] <https://github.com/php/php-src/commit/b36eac94d26bdced150d9d2178f6209893d9961f >
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com >
2024-09-04 16:00:28 +02:00
3ed5eee5d3
[skip ci] Fix bug71162.phpt xfail message (GH-15506)
...
The test failure is unlikely to be caused by `SessionHandlerInterface`
not being available.
2024-08-20 14:48:52 +02:00
c4eccf33e9
ext/session: session.save_handler - add tests fortwo uncovered cases ( #15337 )
2024-08-11 15:39:56 +01:00
b36eac94d2
Deprecate calling session_set_save_handler() with more than 2 arguments
2023-12-04 22:35:30 +01:00
f39b5c4c25
Close PHP tags in tests
...
Closes GH-12422
2023-10-18 17:34:10 +02:00
886bf820c9
[skip ci] Fix typos discovered by codespell ( #12228 )
2023-09-18 11:07:17 +01:00
092e090cf0
ext/session/tests: more lenient expected output checks. ( #11631 )
...
Several session tests incidentally check the values of INI variables
like session.name and session.save_path. This isn't the point of the
tests, and it can cause spurious failures if (for example) you want to
override your temporary directory while testing. So here, we make the
expected output patterns more lenient.
2023-07-10 09:25:25 +01:00
8e9fa2bd23
Convert mod user FINISH macro to static function
2022-10-22 12:47:34 +01:00
5b40d06680
Refactor session_set_save_handler()
...
Use proper ZPP callables with FCI/FCC
2022-10-22 12:47:34 +01:00
15c0df76b5
Add regression test for not setting optional closures again
2022-10-22 12:47:34 +01:00
5465eff03c
Remove tests as they are identical to already existing basic tests
2022-10-22 12:47:34 +01:00
386892f1fe
Restructure ext-session tests
...
And small improvements to some
2022-10-22 12:47:34 +01:00
DanielEScherzer