Dmitry Stogov
0b90cf85a6
Removed "dead" code (zend_hash_update() never fails)
2018-06-01 11:58:57 +03:00
Dmitry Stogov
5eb1f92f31
Use zend_string_release_ex() instread of zend_string_release() in places, where we sure about string persistence.
2018-05-28 16:27:12 +03:00
Stanislav Malyshev
99f1d904a0
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Fix tsrm_ls
Fix #76129 - remove more potential unfiltered outputs for phar
Fix test
Fix bug #76248 - Malicious LDAP-Server Response causes Crash
Fix bug #76249 - fail on invalid sequences
Fix #76130 : Heap Buffer Overflow (READ: 1786) in exif_iif_add_value
Fix bug #75981 : prevent reading beyond buffer start
2018-04-23 22:04:22 -07:00
Stanislav Malyshev
4c06d929c0
Merge branch 'PHP-7.1' into PHP-7.2
...
* PHP-7.1:
Fix tsrm_ls
Fix #76129 - remove more potential unfiltered outputs for phar
Fix test
Fix bug #76248 - Malicious LDAP-Server Response causes Crash
Fix bug #76249 - fail on invalid sequences
Fix #76130 : Heap Buffer Overflow (READ: 1786) in exif_iif_add_value
Fix bug #75981 : prevent reading beyond buffer start
2018-04-23 22:03:33 -07:00
Stanislav Malyshev
95ee9efa57
Merge branch 'PHP-7.0' into PHP-7.1
...
* PHP-7.0:
Fix tsrm_ls
Fix #76129 - remove more potential unfiltered outputs for phar
Fix test
Fix bug #76248 - Malicious LDAP-Server Response causes Crash
Fix bug #76249 - fail on invalid sequences
Fix #76130 : Heap Buffer Overflow (READ: 1786) in exif_iif_add_value
Fix bug #75981 : prevent reading beyond buffer start
2018-04-23 22:00:24 -07:00
Stanislav Malyshev
5a18d7a0df
Merge branch 'PHP-5.6' into PHP-7.0
...
* PHP-5.6:
Fix tsrm_ls
Fix #76129 - remove more potential unfiltered outputs for phar
Fix test
Fix bug #76248 - Malicious LDAP-Server Response causes Crash
Fix bug #76249 - fail on invalid sequences
Fix #76130 : Heap Buffer Overflow (READ: 1786) in exif_iif_add_value
Fix bug #75981 : prevent reading beyond buffer start
2018-04-23 21:59:57 -07:00
Stanislav Malyshev
6e64aba47f
Fix #76129 - remove more potential unfiltered outputs for phar
2018-04-23 13:43:43 -07:00
Stanislav Malyshev
03108697b8
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Add a bit of defensive conding for bug #76155
2018-04-22 20:28:44 -07:00
Stanislav Malyshev
83e7618f05
Merge branch 'PHP-7.1' into PHP-7.2
...
* PHP-7.1:
Add a bit of defensive conding for bug #76155
2018-04-22 20:28:35 -07:00
Stanislav Malyshev
ff83c00715
Add a bit of defensive conding for bug #76155
...
Even though it should not be ever negative, since strlen() is size_t
better to be safe than sorry.
2018-04-22 20:27:42 -07:00
Anatol Belski
2e5ac355b9
Move to unsigned types in phar
...
Preventing integer overflows in principle, which allows to avoid additional
range checks. The phar format is based on 32-bit lengths, so the storage
sizes was kept same.
2018-04-18 20:15:05 +02:00
solotandem
94b4abdbc4
Be consistent in is_executable on a directory in any stream wrapper.
...
Current code treats the 'local files' stream wrapper ('php_plain_files_wrapper')
different than all other stream wrappers. For the 'local' stream wrapper,
is_executable only checks the mode key in the filestat array on the file or
directory in question. For other stream wrappers, is_executable always returns
FALSE on a directory. This treatment is inconsistent on its face.
Also, for a custom stream wrapper that also points to local files, the result
of is_executable is always FALSE even though it may be TRUE if the function were
called on the same item using the 'local' stream wrapper from PHP.
NOTE: patch does not attempt to add a test for this as there are no tests of
is_executable for stream wrappers.
2018-03-27 21:49:26 +02:00
Niklas Keller
e459d27315
Drop double CHECK_NULL_PATH check for PHARs
2018-03-23 19:04:47 +01:00
Xinchen Hui
f4da273c76
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Fixed bug #76085 (Segmentation fault in buildFromIterator when directory name contains a \n)
2018-03-13 12:56:27 +08:00
Xinchen Hui
e547c9f139
Merge branch 'PHP-7.1' into PHP-7.2
...
* PHP-7.1:
Fixed bug #76085 (Segmentation fault in buildFromIterator when directory name contains a \n)
2018-03-13 12:52:07 +08:00
Xinchen Hui
4ee9098514
Fixed bug #76085 (Segmentation fault in buildFromIterator when directory name contains a \n)
2018-03-13 12:51:26 +08:00
Gabriel Caruso
701437a948
Remove return types from some magic method in protos
...
__construct, __destruct, __wakeup does not have return types defined.
2018-03-09 12:04:46 +01:00
Gabriel Caruso
b895690dfa
remove support for string|unicode in tests
2018-02-22 08:11:30 +01:00
Gabriel Caruso
ded3d984c6
Use EXPECT instead of EXPECTF when possible
...
EXPECTF logic in run-tests.php is considerable, so let's avoid it.
2018-02-20 21:53:48 +01:00
Gabriel Caruso
21e3b0c70c
Remove trailing whitespace in inc files
2018-02-10 19:20:23 +01:00
Joe
c8e844be35
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Fixed bug #65414
2018-02-08 10:34:38 +01:00
Bishop Bettini
d806d0315f
Fixed bug #65414
2018-02-08 10:32:08 +01:00
Bishop Bettini
4765ba7dc3
Fixed bug #65414
2018-02-08 10:29:56 +01:00
Gabriel Caruso
fef879a2d6
Use bool instead of boolean while throwing a type error
...
PHP requires boolean typehints to be written "bool" and disallows
"boolean" as an alias. This changes the error messages to match
the actual type name and avoids confusing messages like "must be
of type boolean, boolean given".
This a followup to ce1d69a1f6 , which
implements the same change for integer->int.
2018-02-04 23:09:40 +01:00
Gabriel Caruso
ce1d69a1f6
Use int instead of integer in type errors
...
PHP requires integer typehints to be written "int" and does not
allow "integer" as an alias. This changes type error messages to
match the actual type name and avoids confusing messages like
"must be of the type integer, integer given".
2018-02-04 19:08:23 +01:00
Gabriel Caruso
9a4cc52c23
Remove superfluous PHP version check in tests
...
Also remove tests that target only old PHP versions.
2018-02-04 16:58:54 +01:00
Gabriel Caruso
84488d921b
Remove superfluous SKIPIF sections in more tests
2018-02-04 16:57:08 +01:00
Nikita Popov
4a7dacb5ee
Don't loop over indexes in Phar::extractTo()
...
Instead use a more idiomatic foreach loop. The behavior is not
strictly the same, but I see no reason why this specific case
should enforce continuously indexed integer keys.
Also handle references in the array while at it.
2018-01-28 22:05:44 +01:00
Nikita Popov
d79a0bf748
Merge branch 'PHP-7.2'
2018-01-28 21:53:38 +01:00
Bishop Bettini
fa586cee3e
Fixed bug #54289
...
If a directory is passed to Phar::extractTo(), loop over all
entries and extract all files with the given prefix.
2018-01-28 21:51:25 +01:00
Dmitry Stogov
9cbb521094
Access HashTable.u.flags through HT_FLAGS() macro.
2018-01-22 13:36:15 +03:00
Anatol Belski
89463341c8
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Allow pecl like usage in ext/phar, closes #2955
2018-01-15 14:26:22 +01:00
Anatol Belski
c5768a7e24
Merge branch 'PHP-7.1' into PHP-7.2
...
* PHP-7.1:
Allow pecl like usage in ext/phar, closes #2955
2018-01-15 14:25:45 +01:00
Anatol Belski
2d4fb56c1d
Allow pecl like usage in ext/phar, closes #2955
2018-01-15 14:23:46 +01:00
Bishop Bettini
cb7387275f
Add test for bug #66960
2018-01-15 12:20:10 +01:00
Xinchen Hui
a76eeea736
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Happy new year (Update copyright to 2018)
Conflicts:
ext/phar/LICENSE
2018-01-03 16:02:15 +08:00
Xinchen Hui
0e62639d28
Merge branch 'PHP-7.1' into PHP-7.2
...
* PHP-7.1:
Happy new year (Update copyright to 2018)
2018-01-03 16:00:34 +08:00
Lior Kaplan
fbfdd1e1c4
Happy new year (Update copyright to 2018)
2018-01-02 23:42:29 +02:00
Xinchen Hui
a7fe2570d3
Merge branch 'master' of git.php.net:/php-src
...
* 'master' of git.php.net:/php-src:
Update NEWS
Fixed bug #75571 : Potential infinite loop in gdImageCreateFromGifCtx
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-02 13:50:40 +08:00
Xinchen Hui
e8eb52dc98
Merge branch 'PHP-7.2' of git.php.net:/php-src into PHP-7.2
...
* 'PHP-7.2' of git.php.net:/php-src:
Update NEWS
Fixed bug #75571 : Potential infinite loop in gdImageCreateFromGifCtx
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-02 13:50:18 +08:00
Xinchen Hui
bd23bcec3e
Merge branch 'PHP-7.1' of git.php.net:/php-src into PHP-7.1
...
* 'PHP-7.1' of git.php.net:/php-src:
Update NEWS
Fixed bug #75571 : Potential infinite loop in gdImageCreateFromGifCtx
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-02 13:49:58 +08:00
Stanislav Malyshev
05eb5cda50
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Update NEWS
Fixed bug #75571 : Potential infinite loop in gdImageCreateFromGifCtx
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-01 21:07:30 -08:00
Stanislav Malyshev
a68dc899bb
Merge branch 'PHP-7.1' into PHP-7.2
...
* PHP-7.1:
Update NEWS
Fixed bug #75571 : Potential infinite loop in gdImageCreateFromGifCtx
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-01 21:07:21 -08:00
Xinchen Hui
a6519d0514
year++
2018-01-02 12:57:58 +08:00
Xinchen Hui
7a7ec01a49
year++
2018-01-02 12:55:14 +08:00
Xinchen Hui
ccd4716ec7
year++
2018-01-02 12:53:31 +08:00
Stanislav Malyshev
92c19f8a26
Merge branch 'PHP-7.0' into PHP-7.1
...
* PHP-7.0:
Update NEWS
Fixed bug #75571 : Potential infinite loop in gdImageCreateFromGifCtx
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-01 20:52:34 -08:00
Stanislav Malyshev
459ab2eef4
Merge branch 'PHP-5.6' into PHP-7.0
...
* PHP-5.6:
Update NEWS
Fixed bug #75571 : Potential infinite loop in gdImageCreateFromGifCtx
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-01 20:28:01 -08:00
Stanislav Malyshev
73ca9b3773
Fix bug #74782 : remove file name from output to avoid XSS
2018-01-01 19:51:02 -08:00
Dmitry Stogov
b864e6b58c
Move constants into read-only data segment
2017-12-15 01:55:00 +03:00