Stanislav Malyshev
6d1b06d0b4
Fix bug #81738 (buffer overflow in hash_update() on long parameter)
2022-10-25 11:32:11 +02:00
Christoph M. Becker
feb586e60a
Fix #81739 : OOB read due to insufficient validation in imageloadfont()
...
If we swap the byte order of the relevant header bytes, we need to make
sure again that the following multiplication does not overflow.
2022-10-25 10:59:07 +02:00
Dmitry Stogov
d9651a9419
Fix GH-9697: array_walk($ffiInstance, function () {}) crashes due to expecting mutable array
2022-10-10 11:21:05 +03:00
Michael Voříšek
b43e49437c
Prepare for Windows CI with Github Actions
2022-10-09 18:44:59 +02:00
George Peter Banyard
499fbcd679
Actually fix GH-9583
...
The issue is that PS(mod)->s_validate_sid is always defined for user modules, thus we need to check that the actual callable is set
Add another regression test to ensure current working behaviour is not broken (which was by the previous incorrect fix)
Closes GH-9638
2022-10-06 14:29:13 +01:00
Dmitry Stogov
072dc3c857
Fix typo
2022-10-05 21:39:16 +03:00
Dmitry Stogov
ed652a514f
Fix register allocation (missing store)
...
This fixes oss-fuzz #52022
2022-10-03 17:08:11 +03:00
Dmitry Stogov
5ca4113386
Fix abstract trace consisency for FE_FETCH instruction
2022-10-03 14:48:03 +03:00
Arnaud Le Blanc
80232de0e4
Return immediately when FD_SETSIZE is exceeded ( #9602 )
2022-10-01 11:20:43 +02:00
Andy Postnikov
c58241a003
Make socket path shorter for ext/sockets/tests/socket_cmsg_{rights|credentials}.phpt
...
When running in CI it fails when path/address is longer 108
2022-09-30 17:07:40 +01:00
David Carlier
257f108924
fix php_init_crypt_r/php_shutdown_crypt_r signatures warning.
2022-09-29 20:40:16 +01:00
Derick Rethans
d16b5d3803
Updated to version 2022.4 (2022d)
2022-09-29 11:52:06 +01:00
Athos Ribeiro
e6a822d437
Revert unintended test expectation change
...
Commit fbe3059 included an unintended change to the test which checks if
dns_get_record populates its additional parameter. This patch reverts
such change.
The issue was not detected by the CIs because their tests run in
the --offline mode, and the test in question needs internet connection.
Closes GH-9625.
2022-09-28 12:12:21 +02:00
Christoph M. Becker
809176dab0
Fix new bug81726.phpt for PHP 8.0
...
The error message has slightly changed, so we adapt our expectations.
2022-09-27 18:40:02 +02:00
Christoph M. Becker
3477499d26
Merge branch 'PHP-7.4' into PHP-8.0
...
* PHP-7.4:
Fix regression introduced by fixing bug 81726
2022-09-27 18:22:57 +02:00
Christoph M. Becker
432bf196d5
Fix regression introduced by fixing bug 81726
...
When a tar phar is created, `phar_open_from_fp()` is also called, but
since the file has just been created, none of the format checks can
succeed, so we continue to loop, but must not check again for the
format. Therefore, we bring back the old `test` variable.
Closes GH-9620.
2022-09-27 18:21:32 +02:00
George Peter Banyard
8b115254c0
Fix GH-9583: session_create_id() fails with user defined save handler that doesn't have a validateId() method
2022-09-27 15:52:21 +01:00
Derick Rethans
def8c8d174
Merge branch 'PHP-7.4' into PHP-8.0
2022-09-27 14:11:14 +01:00
Ilija Tovilo
9377c30577
Migrate MSAN build to GitHub actions
2022-09-25 16:18:58 +02:00
Dmitry Stogov
e488f7b0eb
Reorder conditions to avoid valgrind "Conditional jump or move depends on uninitialised value" warning.
2022-09-19 17:17:53 +03:00
Michael Voříšek
9a73ec0367
Always skip randomly failing OCI8 extauth tests
...
This might be caused by an issue with the Oracle Instant Client
libraries[1]; we skip the tests for the time being.
[1] <https://github.com/php/php-src/pull/9524#issuecomment-1244409815 >
Closes GH-9524.
2022-09-13 14:21:23 +02:00
George Peter Banyard
47500f3300
Fix GH-9421 Incorrect argument number for ValueError in NumberFormatter
...
Closes GH-9489
2022-09-13 12:42:58 +01:00
George Peter Banyard
293e69179d
Fix GH-9308 GMP throws the wrong error when a GMP object is passed to gmp_init()
...
Closes GH-9490
2022-09-13 11:24:19 +01:00
Christoph M. Becker
404e8bdb68
Fix #81726 : phar wrapper: DOS when using quine gzip file
...
The phar wrapper needs to uncompress the file; the uncompressed file
might be compressed, so the wrapper implementation loops. This raises
potential DOS issues regarding too deep or even infinite recursion (the
latter are called compressed file quines[1]). We avoid that by
introducing a recursion limit; we choose the somewhat arbitrary limit
`3`.
This issue has been reported by real_as3617 and gPayl0ad.
[1] <https://honno.dev/gzip-quine/ >
2022-09-09 17:10:04 +01:00
Derick Rethans
0611be4e82
Fix #81727 : Don't mangle HTTP variable names that clash with ones that have a specific semantic meaning.
2022-09-09 17:10:04 +01:00
Ilija Tovilo
4a8cca241f
Skip oci tests that leak under asan
2022-09-08 15:56:13 +02:00
Ilija Tovilo
aa7f4497bf
Fix undefined left shift in oci
...
The bit is shifted into the signed bit which is undefined. Make the
integer explicitly unsigned before shifting.
2022-09-08 15:56:10 +02:00
Ilija Tovilo
1435fc6262
Private method incorrectly marked as "overwrites" in reflection
...
Fix GH-9409
Closes GH-9469
2022-09-08 10:43:25 +02:00
Yurun
6ac3f7c84d
Fix GH-9411: PgSQL large object resource is incorrectly closed
...
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de >
Closes GH-9411.
2022-09-05 16:37:54 +02:00
Dmitry Stogov
81cb005ef7
Fix type inference
...
Fixes oss-fuzz #50792
2022-09-05 12:55:50 +03:00
Arnaud Le Blanc
db1ef97209
Add tests
2022-09-02 13:33:21 +02:00
Nicolas Grekas
93f11d8429
Fix GH-8932: Provide a way to get the called-scope of closures ( #9299 )
...
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de >
2022-09-02 13:32:50 +02:00
Dmitry Stogov
263a07e5b0
typo
2022-08-29 17:12:57 +03:00
Dmitry Stogov
4135e6011c
Fix memory leak
...
Fixes oss-fuzz #50616
2022-08-29 14:53:48 +03:00
Christoph M. Becker
725cb4e8ad
Revert "Fix GH-9296: ksort behaves incorrectly on arrays with mixed keys"
...
This reverts commit cd1aed8edd , as
discussed on internals (<https://externals.io/message/118483 >).
2022-08-29 12:41:36 +02:00
Dmitry Stogov
ce42dcf483
Fix ext/opcache/tests/jit/inc_obj_004.phpt failure introduced by fd74ee7e90
...
This should fix GH-9445
2022-08-29 12:30:14 +03:00
Michael Voříšek
f86629569c
Fix pdo_dblib ext test conflicts when run in parallel
...
Closes GH-9430.
2022-08-26 14:57:13 +02:00
Michael Voříšek
be4dd60c55
Fix oci8/pdo_oci random test failures when run in parallel
...
Closes GH-9424.
2022-08-25 15:20:50 +02:00
Christoph M. Becker
f59754694e
xmlRelaxNGCleanupTypes() is deprecated as of libxml2 2.10.0
...
The documentation[1] suggest to call `xmlCleanupParser()` instead, but
we are not doing that for reasons[2]. Thus, we do no longer call
`xmlRelaxNGCleanupTypes()` for libxml2 ≥ 2.10.0.
[1] <https://gnome.pages.gitlab.gnome.org/libxml2/devhelp/libxml2-relaxng.html#xmlRelaxNGCleanupTypes >
[2] <8742276eb3 >
Closes GH-9417.
2022-08-25 15:10:30 +02:00
Dmitry Stogov
fd74ee7e90
JIT: Make code generation to be consistent with register allocation
...
Fixes ext/opcache/tests/jit/add_014.phpt with opcache.jit=1205
2022-08-22 19:53:33 +03:00
Dmitry Stogov
c9c51eb1f1
Tracing JIT: Fix incorrect guard elimination
...
Fixes oss-fuzz #49917
2022-08-22 15:38:41 +03:00
Michael Voříšek
305892580e
Fix pdo_oci tests for PHP 8.0
2022-08-22 09:25:43 +02:00
NathanFreeman
6027d441c1
Fix #79451 : DOMDocument->replaceChild on doctype causes double free
...
We have to reset intSubset if replacing doctype with another doctype node.
Closes GH-9201.
Closes GH-9376.
2022-08-19 18:10:06 +02:00
David Carlier
52e312afb8
opcache jit fix message format for OpenBSD.
...
like macOs it requires `ll`.
Closes #9380 .
2022-08-19 16:40:29 +01:00
George Peter Banyard
d6831e9a5c
Revert Fixed bug #79451
...
The fix for 8.1 and above is not identical and I don't know how to fix without breaking the whole build apparently
2022-08-19 13:54:54 +01:00
Tim Starling
410e5d48a3
Fix GCC 9.4 uninitialized variable warning
...
ext/opcache/zend_accelerator_blacklist.c:295:4: error: ‘blacklist_path_length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
2022-08-19 12:46:55 +01:00
NathanFreeman
1d4300d870
Fix bug #79451 : Using DOMDocument->replaceChild on doctype causes double free
...
Closes GH-9201
2022-08-19 12:46:23 +01:00
Christoph M. Becker
72da418719
Fix GH-9316: $http_response_header is wrong for long status line
...
While the reason-phrase in a HTTP response status line is usually
short, there is no actual limit specified by the RFCs. As such, we
must not assume that the line fits into the buffer (which is currently
128 bytes large).
Since there is no real need to present the complete status line, we
simply read and discard the rest of a long line.
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com >
Closes GH-9319.
2022-08-18 12:27:54 +02:00
Jakub Zelenka
84dcf578b1
Fix GH-9339: OpenSSL oid_file path check warning contains uninitialized path
2022-08-17 19:49:36 +01:00
Gert de Pagter
05ed47ef12
Correct IntlDateFormatter::formatObject params
...
Closes GH-9341.
2022-08-15 17:56:34 +02:00