31962aa086
ext/pgsql: Enable lo_tell64/lo_truncate64 by removing dead VE_PG_LO64 guards
...
The guards reference undefined VE_PG_LO64, a misspelling of
HAVE_PG_LO64 (removed in GH-14628), making the 64-bit code paths
permanently dead. Remove the guards to unconditionally enable the
64-bit variants for PostgreSQL >= 9.3, consistent with pg_lo_seek().
Dropped from GH-21386 as not suitable for backport.
close GH-21437
2026-03-14 05:22:43 +00:00
c658d3c787
ext/pgsql: use smart_str_append_double() instead of snprintf call ( #21406 )
2026-03-11 01:51:53 +00:00
c56e8caaed
ext/pgsql, ext/pdo_pgsql: Remove preprocessor guards for symbols predating libpq 10 ( #21384 )
...
While working on php/doc-en#5409 to clean up outdated PostgreSQL
version notes in the documentation, I noticed that the source code
also retains #ifdef guards for symbols guaranteed to exist in
libpq >= 10.0 (the minimum enforced in build/php.m4 via
PQencryptPasswordConn).
Removed guards (all confirmed in PostgreSQL 10 documentation):
- `PG_DIAG_{INTERNAL_POSITION,INTERNAL_QUERY}`: libpq 8.0+
- `PG_DIAG_{SCHEMA,TABLE,COLUMN,DATATYPE,CONSTRAINT}_NAME`: libpq 9.3+
- `PG_DIAG_SEVERITY_NONLOCALIZED`: libpq 9.6+
- `CONNECTION_SSL_STARTUP`: libpq 8.0+
- `CONNECTION_CONSUME`: libpq 10.0+
Refs:
- https://www.postgresql.org/docs/10/libpq-exec.html#LIBPQ-PQRESULTERRORFIELD
- https://www.postgresql.org/docs/10/libpq-connect.html#LIBPQ-PQCONNECTSTARTPARAMS
- https://github.com/php/php-src/blob/53e31d58834ef04375dae7bdc549d73dae371c5a/build/php.m4#L1927
2026-03-08 05:42:50 +00:00
49f903ccc2
Merge branch 'PHP-8.5'
...
* PHP-8.5:
Fix GH-21162: pg_connect() on error memory leak.
2026-02-15 21:27:29 +00:00
6c8a71b3b7
Merge branch 'PHP-8.4' into PHP-8.5
...
* PHP-8.4:
Fix GH-21162: pg_connect() on error memory leak.
2026-02-15 21:27:19 +00:00
539c5d9f76
Fix GH-21162: pg_connect() on error memory leak.
...
The PHP_PQ_ERROR macro calls php_error_docref() which triggers user error handlers
thus libpq does not have the chance to clean the resources (and empty
connections string are allowed) on failure thus we avoid this macro
and delay the error handling after.
close GH-21165
2026-02-15 21:26:23 +00:00
daa3513c32
ext/pgsql: pg_lo_export/pg_connection_reset returning a boolean value using RETURN_BOOL ( #21150 )
2026-02-06 06:59:33 +00:00
32bd33983d
Remove unreachable code after zend_error_noreturn calls (GH-20983)
2026-02-02 14:14:15 +01:00
e9e0fe45e5
Merge branch 'PHP-8.5'
...
* PHP-8.5:
exp/pgsql: insert/update query string build possible UB fix.
2026-01-19 06:18:26 +00:00
709c2f73aa
Merge branch 'PHP-8.4' into PHP-8.5
...
* PHP-8.4:
exp/pgsql: insert/update query string build possible UB fix.
2026-01-19 06:17:40 +00:00
5785ff7728
exp/pgsql: insert/update query string build possible UB fix.
...
From PQescapeIdentifier() docs
```
A terminating zero byte is not required, and should not be counted in
length
```
2026-01-19 06:17:23 +00:00
ef87a146fb
pgsql: Don't allocate memory for default arguments ( #20757 )
2025-12-23 00:39:09 +01:00
0953e898db
Fix pg_fetch_object() when an error occurs in subroutine ( #20407 )
...
This is a follow-up of GH-20068
2025-11-06 22:47:28 +00:00
129f6e536d
ext/pgsql: Refactor parameter parsing for a few functions ( #20068 )
2025-11-05 22:33:25 +00:00
5b5fe437f5
Merge branch 'PHP-8.5'
...
* PHP-8.5:
Fix GH-20374: PHP with tidy and custom-tags
pgsql: Fix memory leak when object init fails (#20387 )
2025-11-04 20:21:17 +01:00
b8e9f7c44c
Merge branch 'PHP-8.4' into PHP-8.5
...
* PHP-8.4:
Fix GH-20374: PHP with tidy and custom-tags
pgsql: Fix memory leak when object init fails (#20387 )
2025-11-04 20:21:09 +01:00
07aab0c356
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix GH-20374: PHP with tidy and custom-tags
pgsql: Fix memory leak when object init fails (#20387 )
2025-11-04 20:20:26 +01:00
04323955c1
pgsql: Fix memory leak when object init fails ( #20387 )
...
The return value is already overwritten by this point so we do have to
clean up the old return value (i.e. dataset) after all.
2025-11-04 19:59:38 +01:00
67e5d6cc2d
Merge branch 'PHP-8.5'
...
* PHP-8.5:
Update NEWS for recent pgsql bugfix
ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name (#20180 )
2025-11-04 00:10:03 +00:00
7c6affd617
Merge branch 'PHP-8.4' into PHP-8.5
...
* PHP-8.4:
Update NEWS for recent pgsql bugfix
ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name (#20180 )
2025-11-04 00:09:44 +00:00
afca514c3b
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Update NEWS for recent pgsql bugfix
ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name (#20180 )
2025-11-04 00:08:42 +00:00
94dc6ae871
ext/pgsql: Fix segfaults when attempting to fetch row into a non-instantiable class name ( #20180 )
...
Also fix Windows CI with Postgres and CLEAN sections
---------
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com >
2025-11-04 00:04:30 +00:00
5eec4d8001
pgsql: Avoid duplicating strings and factor out parameter building code
2025-10-20 20:41:38 +02:00
da9638298c
pgsql: Avoid unnecessary work in pgsql_copy_from_query() if the input already ends in a newline
2025-10-20 20:41:38 +02:00
e2396a6ffb
pgsql: Simplify pgsql_copy_from_query() by using character buffers
...
This also avoids some unnecessary zend_string overhead.
2025-10-20 20:41:38 +02:00
8e84e9a551
pgsql: Use cheaper string conversion functions
2025-10-20 20:41:38 +02:00
81fef09d01
Merge branch 'PHP-8.5'
...
* PHP-8.5:
pgsql: Fix memory leak when first string conversion fails
2025-10-18 23:59:54 +02:00
9282111d9f
Merge branch 'PHP-8.4' into PHP-8.5
...
* PHP-8.4:
pgsql: Fix memory leak when first string conversion fails
2025-10-18 23:59:48 +02:00
d992cd8315
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
pgsql: Fix memory leak when first string conversion fails
2025-10-18 23:59:41 +02:00
cf3b70d23c
pgsql: Fix memory leak when first string conversion fails
...
If the first string conversion fails, then i==0, but memory was still
allocated for `params`. However, we skip freeing `params` when i==0.
Closes GH-20213.
2025-10-18 23:59:15 +02:00
985d681501
tree-wide: Replace zval_is_true() by zend_is_true() ( #20065 )
...
* tree-wide: Replace `zval_is_true()` by `zend_is_true()`
The former is a direct alias of the latter which is much more often used.
* zend_operators: Remove `zval_is_true()`
2025-10-07 20:44:32 +02:00
d793de1a8c
pgsql: Use true / false instead of 1 / 0 for bool parameters
...
Changes done with Coccinelle:
@r1@
identifier F;
identifier p;
typedef bool;
parameter list [n1] PL1;
parameter list [n2] PL2;
@@
F(PL1, bool p, PL2) {
...
}
@r2@
identifier r1.F;
expression list [r1.n1] EL1;
expression list [r1.n2] EL2;
@@
F(EL1,
(
- 1
+ true
|
- 0
+ false
)
, EL2)
2025-09-24 18:51:40 +02:00
b73d8b373a
Merge branch 'PHP-8.4'
2025-08-15 08:08:16 +01:00
fd4db3e178
Merge branch 'PHP-8.3' into PHP-8.4
2025-08-15 08:05:14 +01:00
987a3a5c8e
Fix GH-19484 i: potential use after free when using persistent pgsql connections.
...
By setting the notice processor to a no-op when a persistent connection is cleaned for future use.
Close GH-19485
2025-08-15 08:04:14 +01:00
841afdc486
streams: use type zend_result instead of type int
2025-08-04 15:30:57 +01:00
30f03021d1
[ci skip] Remove obsolete todo ( #19195 )
...
All arguments are documented on php.net, although result_type is called
mode in the docs and stub.
2025-07-21 10:57:54 +02:00
545d1536d8
Fix GHSA-hrwm-9436-5mv3: pgsql escaping no error checks
...
This adds error checks for escape function is pgsql and pdo_pgsql
extensions. It prevents possibility of storing not properly escaped
data which could potentially lead to some security issues.
2025-07-01 09:34:49 -07:00
49d94cced0
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix GHSA-453j-q27h-5p8x
Fix GHSA-hrwm-9436-5mv3: pgsql escaping no error checks
Fix GHSA-3cr5-j632-f35r: Null byte in hostnames
2025-07-01 17:48:00 +02:00
66bd809ac9
Fix GHSA-hrwm-9436-5mv3: pgsql escaping no error checks
...
This adds error checks for escape function is pgsql and pdo_pgsql
extensions. It prevents possibility of storing not properly escaped
data which could potentially lead to some security issues.
2025-07-01 23:01:16 +09:00
0cdd3c32de
ext/pgsql: Stop using useless convert_to_boolean() API ( #18683 )
...
There are better ways of handling this than casting the zval in place
2025-05-29 19:09:11 +01:00
2b22ea9630
Merge branch 'PHP-8.4'
...
* PHP-8.4:
ext/pgsql: Fix warning not being emittedd when failure to cancel a query
2025-05-29 15:44:08 +01:00
aae88ac799
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
ext/pgsql: Fix warning not being emittedd when failure to cancel a query
2025-05-29 15:43:52 +01:00
40422e9c55
ext/pgsql: Fix warning not being emittedd when failure to cancel a query
2025-05-29 15:42:48 +01:00
c15cacc902
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix uouv in pg_put_copy_end()
2025-04-21 17:47:55 +02:00
4621423e5e
Fix uouv in pg_put_copy_end()
...
Closes GH-18383.
2025-04-21 17:47:37 +02:00
8f6bc97a36
ext/pgsql: pg_fetch_all_columns/pg_copy_to arrays optimisations. ( #18374 )
...
changes to packed arrays for output userland values.
2025-04-21 13:43:44 +01:00
334d9bbc09
ext/pgsql: adding pg_service() alongside other connection infos.
...
returns the ongoing name of the service, if there is.
available since postgres 18
close GH-18198
2025-03-30 21:45:16 +01:00
50bffd3284
Merge branch 'PHP-8.4'
2025-03-26 17:46:38 +00:00
9c6fe6b0ff
Fix GH-18148: pg_copy_from() wrong \n offset check.
...
Close GH-18149
2025-03-26 17:44:01 +00:00
武田 憲太郎