Niels Dossche
88f546b166
Fix missing empty string checks in ext/enchant
...
The library requires the tags to be non-empty, and also requires the
ordering to be non-empty. For the tags, otherwise, assertion failures
can be observed.
Closes GH-18733.
2025-06-02 19:49:48 +02:00
Niels Dossche
58f55683c9
Fix GH-18729: 2 enchant test fails in masterfor alpine
2025-06-01 18:23:07 +02:00
Niels Dossche
f58adc4569
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix ext/enchant test SKIPIFs
2025-06-01 18:21:39 +02:00
Niels Dossche
2ebd1258b8
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix ext/enchant test SKIPIFs
2025-06-01 18:21:34 +02:00
Niels Dossche
9187caeab1
Fix ext/enchant test SKIPIFs
...
The resource check makes no sense, and the is_array() check doesn't
achieve anything. Drop the former, and replace the latter with a !
check.
Discovered while working on GH-18729.
Closes GH-18731.
2025-06-01 18:21:23 +02:00
Niels Dossche
ff80ec70c6
Add enchant_dict_remove() ( #17507 )
2025-02-02 19:14:49 +01:00
Niels Dossche
3a039e3725
Add enchant_dict_remove_from_session() ( #17393 )
2025-01-08 21:53:40 +01:00
Niels Dossche
1ec95c33e8
Merge branch 'PHP-8.4'
...
* PHP-8.4:
Fix crashes in enchant when passing null bytes
2025-01-08 20:47:37 +01:00
Niels Dossche
91384e561f
Merge branch 'PHP-8.3' into PHP-8.4
...
* PHP-8.3:
Fix crashes in enchant when passing null bytes
2025-01-08 20:47:31 +01:00
Niels Dossche
783ecad82e
Fix crashes in enchant when passing null bytes
...
See https://github.com/php/php-src/pull/17393#discussion_r1907660137
Closes GH-17407.
2025-01-08 20:47:01 +01:00
DanielEScherzer
aeb2d5cfa6
ext/[ef]*: fix a bunch of typos (GH-16621)
2024-10-28 11:28:32 +01:00
Gina Peter Bnayard
5853cdb73d
Use "must not" instead of "cannot" wording
2024-08-21 21:12:17 +01:00
Tim Düsterhus
29f98e7485
Replace @deprecated by #[\Deprecated] for internal functions / class constants ( #14750 )
...
Co-authored-by: Gina Peter Banyard <girgias@php.net >
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com >
2024-07-10 16:47:31 +02:00
guangwu
f1a22d0943
fix: typos ( #13694 )
...
Signed-off-by: guoguangwu <guoguangwug@gmail.com >
2024-03-13 09:30:33 +01:00
Ilija Tovilo
50f58c8923
Add ASAN XLEAK support
...
Only disable LSAN instead of skipping the test. This way we can still detect
memory issues which is arguably more important anyway.
Closes GH-10996
2023-04-03 08:02:19 +02:00
Nikita Popov
7485978339
Migrate SKIPIF -> EXTENSIONS ( #7138 )
...
This is an automated migration of most SKIPIF extension_loaded checks.
2021-06-11 11:57:42 +02:00
Nikita Popov
c5401854fc
Run tidy
...
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
2020-09-18 14:28:32 +02:00
George Peter Banyard
9a71d47d73
Throw ValueError on empty tag in enchant_broker_request_dict()
2020-07-31 14:35:14 +01:00
Nikita Popov
4500309f10
Skip enchant test under asan
...
There is a known memory leak here:
https://bugs.launchpad.net/ubuntu/+source/enchant/+bug/305468
2020-07-02 11:37:09 +02:00
Fabien Villepinte
0c6d06ecfa
Replace EXPECTF when possible
...
Closes GH-5779
2020-06-29 21:31:44 +02:00
Máté Kocsis
cd3e04dff3
Convert enchant resources to opaque objects
...
Additionally, deprecate ENCHANT_MYSPELL and ENCHANT_ISPELL constants.
Closes GH-5577
Co-authored-by: Remi Collet <remi@php.net >
2020-05-29 14:51:41 +02:00
Remi Collet
5318971bc5
Revert "convert enchant resources to objects of new classes - EnchantBroker - EnchantDict add OO interface deprecate enchant_broker_free* (use unset instead) deprecate ENCHANT_MYSPELL and ENCHANT_ISPELL constants"
...
This reverts commit 7db4c24a37 .
2020-05-13 15:56:14 +02:00
Remi Collet
7db4c24a37
convert enchant resources to objects of new classes - EnchantBroker - EnchantDict add OO interface deprecate enchant_broker_free* (use unset instead) deprecate ENCHANT_MYSPELL and ENCHANT_ISPELL constants
2020-05-13 15:14:50 +02:00
Remi Collet
66d42e9884
remove deprecated call and deprecate function to be removed in libenchant v2
...
add LIBENCHANT_VERSION constant
2020-04-30 09:32:00 +02:00
Nikita Popov
f8d795820e
Reindent phpt files
2020-02-03 22:52:20 +01:00
Fabien Villepinte
6daa54d3be
Fix grammar in skipif messages
2019-10-12 23:18:56 +02:00
Peter Kokot
d679f02295
Sync leading and final newlines in *.phpt sections
...
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.
According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.
C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."
Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.
[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
2018-10-15 04:33:09 +02:00
Peter Kokot
d7a3edd45d
Trim trailing whitespace in *.phpt
2018-10-14 19:46:15 +02:00
Gabriel Caruso
9c144e0d82
Trim trailing whitespace in tests
2018-10-14 12:07:20 -03:00
Peter Kokot
981e5e17fa
Remove unused ext/enchant/tests files
...
- ext/enchant/tests/hindi_correct.txt
- ext/enchant/tests/hindi_incorrect.txt
Added via 5956f9a398 but never used.
2018-09-25 22:30:22 +02:00
Christoph M. Becker
c189b4788d
Merge branch 'PHP-7.2'
...
* PHP-7.2:
Fixed bug #53070 (enchant_broker_get_path crashes if no path is set)
2017-10-15 14:08:03 +02:00
Jelle van der Waa
5acb8381b2
Fixed bug #53070 (enchant_broker_get_path crashes if no path is set)
...
enchant_broker_get_dict_path segfaults when the dict path is not setup,
instead of segfaulting return false instead.
2017-10-15 13:57:44 +02:00
Kalle Sommer Nielsen
069477f2c1
Skip these enchant tests if no dicts or providers are installed
2017-07-25 22:10:34 +02:00
Christoph M. Becker
7373da78fe
Merge branch 'pull-request/1471'
...
* pull-request/1471:
add test for php_enchant_broker_free()
2015-08-19 22:27:39 +02:00
marcosptf
bf340ec417
add test for php_enchant_broker_free()
2015-08-19 22:25:29 +02:00
Christoph M. Becker
8e9e1b7da3
Merge branch 'pull-request/1472'
...
* pull-request/1472:
This is a new test for enchant_broker_free_dict(). This function never was covered by .phpt
2015-08-19 22:16:42 +02:00
marcosptf
d085100a52
This is a new test for enchant_broker_free_dict().
...
This function never was covered by .phpt
2015-08-19 22:15:40 +02:00
marcosptf
9a4b0dbe40
testing enchant_broker_(g|s)et_dict_path
2015-08-19 21:57:42 +02:00
Christoph M. Becker
d28abb2da2
no need to skip this test if no dictionaries are installed
2015-08-17 21:43:28 +02:00
marcosptf
3b004baaaa
new test for enchant pwl file
2015-08-17 21:28:37 +02:00
marcosptf
20448abc65
Update broker_describe.phpt
2015-08-10 15:54:22 -03:00
marcosptf
6222e5f196
Update broker_describe.phpt
2015-08-10 14:50:32 -03:00
marcosptf
5dc3dadf71
Update dict_check.phpt
2015-08-10 14:14:13 -03:00
marcosptf
3c41ab9ce9
Update broker_free.phpt
2015-08-09 08:15:33 -03:00
marcosptf
32fb77952f
Update broker_dict_exists.phpt
2015-08-09 08:14:56 -03:00
marcosptf
d3cd2f8221
Update broker_describe.phpt
2015-08-09 08:14:19 -03:00
marcosptf
b7c5afbe99
Update dict_suggest.phpt
2015-08-09 08:13:12 -03:00
marcosptf
10ad115518
Update dict_store_replacement.phpt
2015-08-09 08:11:32 -03:00
marcosptf
49510ef7aa
Update dict_quick_check_01.phpt
2015-08-09 08:09:13 -03:00
marcosptf
63990ab18a
Update dict_quick_check.phpt
2015-08-09 08:06:48 -03:00