Sharad Chandran R
7effcab2cf
Fix variable assignment for PHP argument escaping in run-tests.php ( #20799 )
2025-12-29 14:49:21 +01:00
Ilija Tovilo
217fceaf58
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
[skip ci] Auto-mark SKIP_PERF_SENSITIVE tests as flaky
2025-10-21 17:53:17 +02:00
Ilija Tovilo
db98c5717e
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
[skip ci] Auto-mark SKIP_PERF_SENSITIVE tests as flaky
2025-10-21 17:53:10 +02:00
Ilija Tovilo
99076ebfb0
[skip ci] Auto-mark SKIP_PERF_SENSITIVE tests as flaky
...
These can occasionally fail in CI.
2025-10-21 17:52:04 +02:00
Ilija Tovilo
831597748b
Automatically skip tty tests if not on tty
...
See GH-19975
Closes GH-20013
2025-10-03 00:45:20 +02:00
Ilija Tovilo
e7af08d625
Hide xfail/xleak test summary
...
We don't show succeeding tests in the summary, and for all intents and purposes,
these tests have succeeded, in that they behave as expected. I've seen the
output confuse people on multiple occasions, for example GH-17105.
Closes GH-17109
2024-12-12 13:12:46 +01:00
Ilija Tovilo
8a9d45b86f
Backport flaky flag for phar tests
...
4e12189604
b6ca871396
062837aa13
2024-12-10 10:35:00 +01:00
Ilija Tovilo
5b2d80bc79
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Mark some phar tests as flaky on macOS
2024-09-13 18:14:14 +02:00
Ilija Tovilo
4e12189604
Mark some phar tests as flaky on macOS
...
Fixes GH-15748
Closes GH-15876
2024-09-13 18:13:10 +02:00
Christoph M. Becker
71b908748a
Fix run-tests.php to propagate status code on Windows
...
There is now a workaround in `system_with_timeout()` to avoid issues
with quotes and spaces in the filenames of the executable by using
`start`[1]. However, calling `start` will not propagate the process
status of the actual process. Thus, calling `proc_get_status()`
is pretty meaningless, and especially Microsoft errors cannot be
detected (typically, access violations etc.), and as such no "Termsig"
message is output.
We fix this by executing `exit` after the started command has finished.
[1] <a6d7d5234b/run-tests.php (L1157-L1162) >
Closes GH-15378.
2024-09-02 00:52:31 +02:00
Ilija Tovilo
379e913e1a
Fix run-tests.php differ calculateCommonSubsequence for EXPECTF
...
calculateCommonSubsequence should not contain regexes.
Fixes GH-13083
Closes GH-13084
2024-01-08 13:36:29 +01:00
Ilija Tovilo
2312637496
Retry tests on deadlock
...
Closes GH-12693
2023-11-22 20:39:29 -06:00
Ilija Tovilo
9bdd0f0de9
Automatically mark tests as flaky
...
Marking all of these tests as flaky is annoying, so attempt to recognize them
automatically.
Closes GH-12638
2023-11-22 20:39:29 -06:00
Ilija Tovilo
ed927365c2
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Retry tests on deadlock
2023-11-16 16:02:58 +01:00
Ilija Tovilo
58712e0698
Retry tests on deadlock
...
Closes GH-12693
2023-11-16 16:02:20 +01:00
Ilija Tovilo
082219ba0e
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Automatically mark tests as flaky
2023-11-15 13:22:35 +01:00
Ilija Tovilo
6d59640980
Automatically mark tests as flaky
...
Marking all of these tests as flaky is annoying, so attempt to recognize them
automatically.
Closes GH-12638
2023-11-15 13:21:58 +01:00
Ilija Tovilo
8f4738f41d
Merge branch 'PHP-8.2' into PHP-8.3
...
* PHP-8.2:
Increase run-tests.php timeout for asan
2023-08-30 23:10:24 +02:00
Ilija Tovilo
936538d8d7
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Increase run-tests.php timeout for asan
2023-08-30 23:10:10 +02:00
Ilija Tovilo
f4a6a6d096
Increase run-tests.php timeout for asan
...
Closes GH-12087
2023-08-30 23:09:33 +02:00
Ilija Tovilo
b20ff2f9f5
Merge branch 'PHP-8.2'
...
* PHP-8.2:
Make unrepeatable tests retriable
2023-08-29 13:59:26 +02:00
Ilija Tovilo
d5f7ffb914
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Make unrepeatable tests retriable
2023-08-29 13:58:53 +02:00
Ilija Tovilo
f2c16b7ba3
Make unrepeatable tests retriable
...
This was an error in thinking on my side. The reason these tests are
unrepeatable is because --repeat executes the same request in the same process,
and does not run the CLEAN section in between runs. This is not the case when
retrying tests.
We could potentially make CLEAN tests repeatable by including the CLEAN section
in the tested script. This does however not work for all tests (e.g. tests that
set open_basedir).
Closes GH-12072
2023-08-29 13:56:13 +02:00
Peter Kokot
e199104a35
Fix passing null to parameter of type string ( #12014 )
...
This fixes builds without cgi or phpdbg:
./configure --disable-cgi --disable-phpdbg
make
./sapi/cli/php run-tests.php
Otherwise, deprecation warnings (since PHP-8.1) are emitted:
Deprecated: escapeshellarg(): Passing null to parameter #1 ($arg) of
type string is deprecated in run-tests.php...
2023-08-22 02:51:31 +01:00
Ilija Tovilo
d397fec129
Skip xleak tests on asan ( #11610 )
...
Fixes GH-11077
2023-07-07 09:24:05 +02:00
Ilija Tovilo
b0a2727749
Merge branch 'PHP-8.2'
...
* PHP-8.2:
Implement flaky test section
2023-07-06 09:46:15 +02:00
Ilija Tovilo
4e3d9b26f9
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Implement flaky test section
2023-07-06 09:46:03 +02:00
Ilija Tovilo
849fdcae7d
Implement flaky test section
...
This re-uses the already used for automatic retesting. That's certainly better
than XFAIL.
Closes GH-11325
2023-07-06 09:45:35 +02:00
Ilija Tovilo
2d883a6ff0
Merge branch 'PHP-8.2'
...
* PHP-8.2:
[skip ci] Add more patterns to run-tests.php retry list
2023-05-27 19:22:07 +02:00
Ilija Tovilo
f735543bc9
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
[skip ci] Add more patterns to run-tests.php retry list
2023-05-27 19:21:55 +02:00
Ilija Tovilo
f249958cd3
[skip ci] Add more patterns to run-tests.php retry list
...
CURL: 404: Page Not Found
IMAP: Can't create a temporary mailbox: [ALREADYEXISTS] Mailbox already exists
Sockets: socket_bind(): Unable to bind address [98]: Address already in use
2023-05-27 19:21:19 +02:00
Ilija Tovilo
4e6025a641
Merge branch 'PHP-8.2'
...
* PHP-8.2:
Add retry mechanism in run-tests.php
2023-05-03 13:51:31 +02:00
Ilija Tovilo
81b2d2ee45
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Add retry mechanism in run-tests.php
2023-05-03 13:50:04 +02:00
Ilija Tovilo
11597d18d6
Add retry mechanism in run-tests.php
...
We have lots of spurious failures in CI, many of them with the "all" CONFLICT.
We're limiting the retrying to specific error messages. In the future we may
also provide a FLAKY section to retry specific tests.
Closes GH-10892
2023-05-03 13:47:13 +02:00
Ilija Tovilo
fc88f155be
Add zend_alloc XLEAK support
...
In the future we may want to use a different exit code to warn for tests that
didn't leak.
Closes GH-10999
2023-04-03 12:55:26 +02:00
Ilija Tovilo
50f58c8923
Add ASAN XLEAK support
...
Only disable LSAN instead of skipping the test. This way we can still detect
memory issues which is arguably more important anyway.
Closes GH-10996
2023-04-03 08:02:19 +02:00
Ilija Tovilo
ed0b773cb9
[skip ci] Avoid infinite loop in differ
...
TBH I don't understand why this can happen here but not in sebastian/diff. I'll
have to take a closer look.
2023-04-01 15:44:46 +02:00
Ilija Tovilo
b9f8b696c4
Fix one more differ direct comparison (through in_array)
2023-03-27 17:39:52 +02:00
Ilija Tovilo
c58c2666a1
Fix direct comparison in run-tests.php differ
2023-03-23 16:07:59 +01:00
Ilija Tovilo
d854492655
[skip ci] Fix var_dump statement in run-tests.php
2023-03-23 11:23:17 +01:00
Ilija Tovilo
ac961bbb1d
Implement better diff for run-tests.php
...
Borrow sebastianbergmann/diff with
MemoryEfficientLongestCommonSubsequenceCalculator
Fixes GH-10806
Closes GH-10875
2023-03-22 20:02:41 +01:00
Ilija Tovilo
5ef46020b6
Merge branch 'PHP-8.2'
...
* PHP-8.2:
Another attempt to fix MSAN nightly on master
2023-03-15 23:38:22 +01:00
Ilija Tovilo
6343975f34
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
Another attempt to fix MSAN nightly on master
2023-03-15 23:38:09 +01:00
Ilija Tovilo
471105abd7
Another attempt to fix MSAN nightly on master
2023-03-15 23:37:36 +01:00
Ilija Tovilo
a5da519d59
Merge branch 'PHP-8.2'
...
* PHP-8.2:
use_tls=0 on MSAN
2023-03-14 17:43:12 +01:00
Ilija Tovilo
ca7c7e9c05
Merge branch 'PHP-8.1' into PHP-8.2
...
* PHP-8.1:
use_tls=0 on MSAN
2023-03-14 17:43:02 +01:00
Ilija Tovilo
63525ee600
use_tls=0 on MSAN
...
Attempt to fix MSAN failure in CI
Closes GH-10851
2023-03-14 17:42:23 +01:00
Ilija Tovilo
c0ee8e833c
Merge branch 'PHP-8.2'
...
* PHP-8.2:
[skip ci] Fix diff cmd env name in run-tests.php
2023-03-10 01:10:55 +01:00
Ilija Tovilo
d3c9585204
[skip ci] Fix diff cmd env name in run-tests.php
2023-03-10 01:10:25 +01:00
Ilija Tovilo
486fb80947
[skip ci] Remove accidental run-tests.php line
2023-03-06 15:05:11 +01:00