php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 16:22:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

ext/spl: Deprecate ArrayObject and ArrayIterator with objects (#19420)

Browse Source 
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_arrayiterator_with_objects

This also moves tests into a subfolder.
This commit is contained in:
Gina Peter Banyard
2025-08-14 12:38:57 +01:00
committed by GitHub
parent 9c754baa99
commit fb87b14b6c
120 changed files with 353 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

203
ext/spl/tests/ArrayObject/arrayObject_magicMethods2.phpt Normal file
View File

@@ -0,0 +1,203 @@
--TEST--
SPL: ArrayObject: ensure a wrapped object's magic methods for property access are not invoked when manipulating the ArrayObject's elements using ->.
--FILE--
<?php
class UsesMagic {
public $a = 1;
public $b = 2;
public $c = 3;
private $priv = 'secret';
function __get($name) {
$args = func_get_args();
echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
}
function __set($name, $value) {
$args = func_get_args();
echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
}
function __isset($name) {
$args = func_get_args();
echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
}
function __unset($name) {
$args = func_get_args();
echo "In " . __METHOD__ . "(" . implode($args, ',') . ")\n";
}
}
$obj = new UsesMagic;
$ao = new ArrayObject($obj);
echo "\n--> Write existent, non-existent and dynamic:\n";
$ao->a = 'changed';
$ao->dynamic = 'new';
$ao->dynamic = 'new.changed';
echo " Original wrapped object:\n";
var_dump($obj);
echo " Wrapping ArrayObject:\n";
var_dump($ao);
echo "\n--> Read existent, non-existent and dynamic:\n";
var_dump($ao->a);
var_dump($ao->nonexistent);
var_dump($ao->dynamic);
echo " Original wrapped object:\n";
var_dump($obj);
echo " Wrapping ArrayObject:\n";
var_dump($ao);
echo "\n--> isset existent, non-existent and dynamic:\n";
var_dump(isset($ao->a));
var_dump(isset($ao->nonexistent));
var_dump(isset($ao->dynamic));
echo " Original wrapped object:\n";
var_dump($obj);
echo " Wrapping ArrayObject:\n";
var_dump($ao);
echo "\n--> Unset existent, non-existent and dynamic:\n";
unset($ao->a);
unset($ao->nonexistent);
unset($ao->dynamic);
echo " Original wrapped object:\n";
var_dump($obj);
echo " Wrapping ArrayObject:\n";
var_dump($ao);
?>
--EXPECTF--
Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
--> Write existent, non-existent and dynamic:
Deprecated: Creation of dynamic property ArrayObject::$a is deprecated in %s on line %d
Deprecated: Creation of dynamic property ArrayObject::$dynamic is deprecated in %s on line %d
Original wrapped object:
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
Wrapping ArrayObject:
object(ArrayObject)#2 (3) {
["a"]=>
string(7) "changed"
["dynamic"]=>
string(11) "new.changed"
["storage":"ArrayObject":private]=>
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
}
--> Read existent, non-existent and dynamic:
string(7) "changed"
Warning: Undefined property: ArrayObject::$nonexistent in %s on line %d
NULL
string(11) "new.changed"
Original wrapped object:
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
Wrapping ArrayObject:
object(ArrayObject)#2 (3) {
["a"]=>
string(7) "changed"
["dynamic"]=>
string(11) "new.changed"
["storage":"ArrayObject":private]=>
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
}
--> isset existent, non-existent and dynamic:
bool(true)
bool(false)
bool(true)
Original wrapped object:
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
Wrapping ArrayObject:
object(ArrayObject)#2 (3) {
["a"]=>
string(7) "changed"
["dynamic"]=>
string(11) "new.changed"
["storage":"ArrayObject":private]=>
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
}
--> Unset existent, non-existent and dynamic:
Original wrapped object:
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
Wrapping ArrayObject:
object(ArrayObject)#2 (1) {
["storage":"ArrayObject":private]=>
object(UsesMagic)#1 (4) {
["a"]=>
int(1)
["b"]=>
int(2)
["c"]=>
int(3)
["priv":"UsesMagic":private]=>
string(6) "secret"
}
}