1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 16:22:37 +01:00

ext/spl: Deprecate ArrayObject and ArrayIterator with objects (#19420)

RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_arrayiterator_with_objects

This also moves tests into a subfolder.
This commit is contained in:
Gina Peter Banyard
2025-08-14 12:38:57 +01:00
committed by GitHub
parent 9c754baa99
commit fb87b14b6c
120 changed files with 353 additions and 136 deletions

View File

@@ -0,0 +1,85 @@
--TEST--
SPL: Cloning nested ArrayObjects.
--FILE--
<?php
#[AllowDynamicProperties]
class C {
public $p = 'C::p.orig';
}
$wrappedObject = new C;
$innerArrayObject = new ArrayObject($wrappedObject);
$outerArrayObject = new ArrayObject($innerArrayObject);
$wrappedObject->dynamic1 = 'new prop added to $wrappedObject before clone';
$clonedOuterArrayObject = clone $outerArrayObject;
$wrappedObject->dynamic2 = 'new prop added to $wrappedObject after clone';
$innerArrayObject['new.iAO'] = 'new element added $innerArrayObject';
$outerArrayObject['new.oAO'] = 'new element added to $outerArrayObject';
$clonedOuterArrayObject['new.coAO'] = 'new element added to $clonedOuterArrayObject';
var_dump($wrappedObject, $innerArrayObject, $outerArrayObject, $clonedOuterArrayObject);
?>
--EXPECTF--
Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
object(C)#1 (5) {
["p"]=>
string(9) "C::p.orig"
["dynamic1"]=>
string(45) "new prop added to $wrappedObject before clone"
["dynamic2"]=>
string(44) "new prop added to $wrappedObject after clone"
["new.iAO"]=>
string(35) "new element added $innerArrayObject"
["new.oAO"]=>
string(38) "new element added to $outerArrayObject"
}
object(ArrayObject)#2 (1) {
["storage":"ArrayObject":private]=>
object(C)#1 (5) {
["p"]=>
string(9) "C::p.orig"
["dynamic1"]=>
string(45) "new prop added to $wrappedObject before clone"
["dynamic2"]=>
string(44) "new prop added to $wrappedObject after clone"
["new.iAO"]=>
string(35) "new element added $innerArrayObject"
["new.oAO"]=>
string(38) "new element added to $outerArrayObject"
}
}
object(ArrayObject)#3 (1) {
["storage":"ArrayObject":private]=>
object(ArrayObject)#2 (1) {
["storage":"ArrayObject":private]=>
object(C)#1 (5) {
["p"]=>
string(9) "C::p.orig"
["dynamic1"]=>
string(45) "new prop added to $wrappedObject before clone"
["dynamic2"]=>
string(44) "new prop added to $wrappedObject after clone"
["new.iAO"]=>
string(35) "new element added $innerArrayObject"
["new.oAO"]=>
string(38) "new element added to $outerArrayObject"
}
}
}
object(ArrayObject)#4 (1) {
["storage":"ArrayObject":private]=>
array(3) {
["p"]=>
string(9) "C::p.orig"
["dynamic1"]=>
string(45) "new prop added to $wrappedObject before clone"
["new.coAO"]=>
string(44) "new element added to $clonedOuterArrayObject"
}
}