1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 08:12:21 +01:00

ext/spl: Deprecate ArrayObject and ArrayIterator with objects (#19420)

RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_arrayiterator_with_objects

This also moves tests into a subfolder.
This commit is contained in:
Gina Peter Banyard
2025-08-14 12:38:57 +01:00
committed by GitHub
parent 9c754baa99
commit fb87b14b6c
120 changed files with 353 additions and 136 deletions

View File

@@ -0,0 +1,108 @@
--TEST--
SPL: ArrayObject::__construct basic usage with ArrayObject::ARRAY_AS_PROPS. Currently fails on php.net due to bug 45622.
--FILE--
<?php
class C {
public $prop = 'C::prop.orig';
}
class MyArrayObject extends ArrayObject {
public $prop = 'MyArrayObject::prop.orig';
}
echo "\n--> Access prop on instance of ArrayObject with ArrayObject::ARRAY_AS_PROPS:\n";
$c = new C;
$ao = new ArrayObject($c, ArrayObject::ARRAY_AS_PROPS);
testAccess($c, $ao);
echo "\n--> Access prop on instance of MyArrayObject with ArrayObject::ARRAY_AS_PROPS:\n";
$c = new C;
$ao = new MyArrayObject($c, ArrayObject::ARRAY_AS_PROPS);
testAccess($c, $ao);
function testAccess($c, $ao) {
echo " - Iteration:\n";
foreach ($ao as $key=>$value) {
echo " $key=>$value\n";
}
echo " - Read:\n";
@var_dump($ao->prop, $ao['prop']);
echo " - Write:\n";
$ao->prop = 'changed1';
$ao['prop'] = 'changed2';
var_dump($ao->prop, $ao['prop']);
echo " - Isset:\n";
var_dump(isset($ao->prop), isset($ao['prop']));
echo " - Unset:\n";
unset($ao->prop);
unset($ao['prop']);
var_dump($ao->prop, $ao['prop']);
echo " - After:\n";
var_dump($ao, $c);
}
?>
--EXPECTF--
--> Access prop on instance of ArrayObject with ArrayObject::ARRAY_AS_PROPS:
Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
- Iteration:
prop=>C::prop.orig
- Read:
string(12) "C::prop.orig"
string(12) "C::prop.orig"
- Write:
string(8) "changed2"
string(8) "changed2"
- Isset:
bool(true)
bool(true)
- Unset:
Warning: Undefined array key "prop" in %s on line %d
Warning: Undefined array key "prop" in %s on line %d
NULL
NULL
- After:
object(ArrayObject)#2 (1) {
["storage":"ArrayObject":private]=>
object(C)#1 (0) {
}
}
object(C)#1 (0) {
}
--> Access prop on instance of MyArrayObject with ArrayObject::ARRAY_AS_PROPS:
Deprecated: ArrayObject::__construct(): Using an object as a backing array for ArrayObject is deprecated, as it allows violating class constraints and invariants in %s on line %d
- Iteration:
prop=>C::prop.orig
- Read:
string(24) "MyArrayObject::prop.orig"
string(12) "C::prop.orig"
- Write:
string(8) "changed1"
string(8) "changed2"
- Isset:
bool(true)
bool(true)
- Unset:
Warning: Undefined array key "prop" in %s on line %d
Warning: Undefined array key "prop" in %s on line %d
NULL
NULL
- After:
object(MyArrayObject)#3 (1) {
["storage":"ArrayObject":private]=>
object(C)#4 (0) {
}
}
object(C)#4 (0) {
}