php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix run-tests.php -s flag

Browse Source 
- Remove unnedded putenv('NO_INTERACTION=1') when executing individual tests.
- Fix undefined variable errors when executing individual tests.
- Fix -s when NO_INTERACTION=1 is set, given we don't need to prompt anyway.

Fixes GH-20961
Closes GH-20970
This commit is contained in:
Ilija Tovilo
2026-01-19 00:32:34 +01:00
parent 5785ff7728
commit ee5fc4a030
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
run-tests.php
View File

@@ -697,7 +697,8 @@ function main(): void
write_information($user_tests, $phpdbg);
if ($test_cnt) {
putenv('NO_INTERACTION=1');
$exts_tested = [];
$exts_skipped = [];
usort($test_files, "test_sort");
$start_timestamp = time();
$start_time = hrtime(true);
@@ -777,7 +778,7 @@ function main(): void
show_end($start_timestamp, $start_time, $end_time);
show_summary();
save_results($output_file, /* prompt_to_save_results: */ true);
save_results($output_file, /* prompt_to_save_results: */ !$just_save_results);
}
$junit->saveXML();
@@ -920,7 +921,7 @@ function save_results(string $output_file, bool $prompt_to_save_results): void
{
global $sum_results, $failed_test_summary, $PHP_FAILED_TESTS, $php;
if (getenv('NO_INTERACTION')) {
if (getenv('NO_INTERACTION') && $prompt_to_save_results) {
return;
}