From ec394cc26ade8a360a0c089e748bff48b516a215 Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Thu, 14 Mar 2024 21:51:55 +0100 Subject: [PATCH] Fix implicitly marking parameter as nullable deprecation warning (#13714) A follow up around the php-src code regarding the RFC: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types --- ext/phar/phar/pharcommand.inc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ext/phar/phar/pharcommand.inc b/ext/phar/phar/pharcommand.inc index 17c5c6051fa..fee6c069ab0 100644 --- a/ext/phar/phar/pharcommand.inc +++ b/ext/phar/phar/pharcommand.inc @@ -630,15 +630,15 @@ class PharCommand extends CLICommand * This function will take a directory and iterate through * it and get the files to insert into the Phar archive. * - * @param Phar $phar The phar object. - * @param string $input The input directory - * @param string $regex The regex used in RegexIterator. - * @param string $invregex The InvertedRegexIterator expression. - * @param SplFileInfo $stub Stub file object - * @param mixed $compress Compression algorithm or NULL - * @param boolean $noloader Whether to prevent adding the loader + * @param Phar $phar The phar object. + * @param string $input The input directory + * @param string $regex The regex used in RegexIterator. + * @param string $invregex The InvertedRegexIterator expression. + * @param ?SplFileInfo $stub Stub file object + * @param mixed $compress Compression algorithm or NULL + * @param boolean $noloader Whether to prevent adding the loader */ - static function phar_add(Phar $phar, $level, $input, $regex, $invregex, SplFileInfo $stub = NULL, $compress = NULL, $noloader = false) + static function phar_add(Phar $phar, $level, $input, $regex, $invregex, ?SplFileInfo $stub, $compress = NULL, $noloader = false) { if ($input && is_file($input) && !is_dir($input)) { return self::phar_add_file($phar, $level, $input, $input, $compress);