From e2b49d6c45f0c5ed69268d32da2f4972265db663 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Mon, 26 Aug 2019 16:10:29 +0200 Subject: [PATCH] Don't use needs_live_range hook for "special" live ranges In particular we were disgarding SILENCE live ranges in opcache, because we decided that a MAY_BE_LONG type does not need a live range. --- .../uncaught_exception_error_supression.phpt | 18 ++++++++++++++++++ Zend/zend_opcode.c | 11 ++++++----- 2 files changed, 24 insertions(+), 5 deletions(-) create mode 100644 Zend/tests/uncaught_exception_error_supression.phpt diff --git a/Zend/tests/uncaught_exception_error_supression.phpt b/Zend/tests/uncaught_exception_error_supression.phpt new file mode 100644 index 00000000000..1130a9d99b0 --- /dev/null +++ b/Zend/tests/uncaught_exception_error_supression.phpt @@ -0,0 +1,18 @@ +--TEST-- +Error suppression should have no impact on uncaught exceptions +--FILE-- + +--EXPECTF-- +Fatal error: Uncaught Error: Example Exception in %s:%d +Stack trace: +#0 %s(%d): abc() +#1 {main} + thrown in %s on line %d diff --git a/Zend/zend_opcode.c b/Zend/zend_opcode.c index ff6bcfd9c41..fe81585daf8 100644 --- a/Zend/zend_opcode.c +++ b/Zend/zend_opcode.c @@ -655,6 +655,12 @@ static void emit_live_range( default: start++; kind = ZEND_LIVE_TMPVAR; + + /* Check hook to determine whether a live range is necessary, + * e.g. based on type info. */ + if (needs_live_range && !needs_live_range(op_array, orig_def_opline)) { + return; + } break; } case ZEND_COPY_TMP: @@ -694,11 +700,6 @@ static void emit_live_range( } } - /* Check hook to determine whether a live range is necessary, e.g. based on type info. */ - if (needs_live_range && !needs_live_range(op_array, orig_def_opline)) { - return; - } - emit_live_range_raw(op_array, var_num, kind, start, end); }