From da777d493a0a3681d6bc7a338e35c7bb6610f599 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 22 Feb 2023 15:13:57 +0100 Subject: [PATCH] CODING_STANDARDS.md: add rules for bool/zend_result return types (#10630) This guideline was mentioned on php-internals (https://news-web.php.net/php.internals/119573). --- CODING_STANDARDS.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CODING_STANDARDS.md b/CODING_STANDARDS.md index 61e878fe855..8615892279c 100644 --- a/CODING_STANDARDS.md +++ b/CODING_STANDARDS.md @@ -78,6 +78,11 @@ rewritten to comply with these rules. may need to control or free the memory, or when the memory in question needs to survive between multiple requests. +1. The return type of "is" or "has" style functions should be `bool`, + which return a "yes"/"no" answer. `zend_result` is an appropriate + return value for functions that perform some operation that may + succeed or fail. + ## User functions/methods naming conventions 1. Function names for user-level functions should be enclosed with in the