php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove incorrect call to zval_ptr_dtor() in user_wrapper_metadata()

Browse Source 
This one is not initialized. This is not hittable from userspace code
because all locations within first-party php-src code have a valid
`option` argument.

Closes GH-19714.
This commit is contained in:
Niels Dossche
2025-09-04 22:27:58 +02:00
parent bd88a54934
commit d10ff9bbd8
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
NEWS
View File

@@ -36,6 +36,10 @@ PHP NEWS
- Standard: - Standard:
. Fixed bug GH-16649 (UAF during array_splice). (alexandre-daubois) . Fixed bug GH-16649 (UAF during array_splice). (alexandre-daubois)
- Streams:
. Remove incorrect call to zval_ptr_dtor() in user_wrapper_metadata().
(nielsdos)
- Tidy: - Tidy:
. Fixed GH-19021 build issue with libtidy in regard of tidyOptIsReadonly . Fixed GH-19021 build issue with libtidy in regard of tidyOptIsReadonly
deprecation and TidyInternalCategory being available later than deprecation and TidyInternalCategory being available later than

1
main/streams/userspace.c
View File

@@ -1223,7 +1223,6 @@ static int user_wrapper_metadata(php_stream_wrapper *wrapper, const char *url, i
break; break;
default: default:
php_error_docref(NULL, E_WARNING, "Unknown option %d for " USERSTREAM_METADATA, option); php_error_docref(NULL, E_WARNING, "Unknown option %d for " USERSTREAM_METADATA, option);
zval_ptr_dtor(&args[2]);
return ret; return ret;
} }