php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix GH-21058: error_log() crash on null destination argument. (#21064)

Browse Source 
we preserve the lower branches behavior by letting php_stream_open_wrapper_ex
handling the null path and propagating the exception.

close GH-21064
This commit is contained in:
David CARLIER
2026-01-29 19:49:45 +00:00
committed by GitHub
parent 5ce36453d6
commit ce798afac3
3 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@@ -101,6 +101,8 @@ PHP NEWS
while COW violation flag is still set). (alexandre-daubois) while COW violation flag is still set). (alexandre-daubois)
. Invalid mode values now throw in array_filter() instead of being silently . Invalid mode values now throw in array_filter() instead of being silently
defaulted to 0. (Jorg Sowa) defaulted to 0. (Jorg Sowa)
. Fixed bug GH-21058 (error_log() crashes with message_type 3 and
null destination). (David Carlier)
- Streams: - Streams:
. Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream

2
ext/standard/basic_functions.c
View File

@@ -1369,7 +1369,7 @@ PHPAPI zend_result _php_error_log(int opt_err, const zend_string *message, const
return FAILURE; return FAILURE;
case 3: /*save to a file */ case 3: /*save to a file */
stream = php_stream_open_wrapper(ZSTR_VAL(opt), "a", REPORT_ERRORS, NULL); stream = php_stream_open_wrapper(opt ? ZSTR_VAL(opt) : NULL, "a", REPORT_ERRORS, NULL);
if (!stream) { if (!stream) {
return FAILURE; return FAILURE;
} }

13
ext/standard/tests/general_functions/gh21058.phpt Normal file
View File

@@ -0,0 +1,13 @@
--TEST--
GH-21058 (error_log() crash with null destination and message type 3)
--FILE--
<?php
try {
error_log("test", 3, null);
} catch (\ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}
?>
--EXPECT--
Path must not be empty