From 8f13599a645a97df940640e9c70f164a92e8743c Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Wed, 10 Apr 2019 13:06:02 +0200 Subject: [PATCH] Fix 29nb_async_connect.phpt Intermediate states are unreliable across versions (I think), make sure we go through the whole connect procedure. --- ext/pgsql/tests/29nb_async_connect.phpt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ext/pgsql/tests/29nb_async_connect.phpt b/ext/pgsql/tests/29nb_async_connect.phpt index fc3868a26db..a9b17ebc3a1 100755 --- a/ext/pgsql/tests/29nb_async_connect.phpt +++ b/ext/pgsql/tests/29nb_async_connect.phpt @@ -23,18 +23,20 @@ if (!$db = pg_connect($conn_str, PGSQL_CONNECT_ASYNC)) { while (TRUE) { switch ($status = pg_connect_poll($db)) { case PGSQL_POLLING_READING: - if (nb_is_readable($db_socket)) { break 2; } + nb_is_readable($db_socket); break; case PGSQL_POLLING_WRITING: - if (nb_is_writable($db_socket)) { break 2; } + nb_is_writable($db_socket); break; case PGSQL_POLLING_FAILED: die("async connection failed"); case PGSQL_POLLING_OK: break 2; + default: + die("unknown poll status"); } } -assert(pg_connection_status($db) === PGSQL_CONNECTION_MADE); +assert(pg_connection_status($db) === PGSQL_CONNECTION_OK); echo "OK"; pg_close($db);