From a2fde39169bc9e01e07445836b5ad07fb2e24848 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Mon, 10 Jul 2023 21:43:09 +0200 Subject: [PATCH] Remove always-true condition from php_dom_iterator_move_forward() basenode is already checked above --- ext/dom/dom_iterators.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ext/dom/dom_iterators.c b/ext/dom/dom_iterators.c index 2cf2c7bb6e7..2614eff85a0 100644 --- a/ext/dom/dom_iterators.c +++ b/ext/dom/dom_iterators.c @@ -219,8 +219,7 @@ static void php_dom_iterator_move_forward(zend_object_iterator *iter) /* {{{ */ if (php_dom_is_cache_tag_stale_from_node(&iterator->cache_tag, basenode)) { php_dom_mark_cache_tag_up_to_date_from_node(&iterator->cache_tag, basenode); previndex = 0; - if (basenode && (basenode->type == XML_DOCUMENT_NODE || - basenode->type == XML_HTML_DOCUMENT_NODE)) { + if (basenode->type == XML_DOCUMENT_NODE || basenode->type == XML_HTML_DOCUMENT_NODE) { curnode = xmlDocGetRootElement((xmlDoc *) basenode); } else { curnode = basenode->children;