From 9216b8be8b11f87d1d4ab5e6bdcaf98db9a9bf91 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sat, 11 Oct 2025 13:08:29 +0200 Subject: [PATCH] phar: Fix memory leak when setAlias() fails Closes GH-20135. --- NEWS | 1 + ext/phar/phar_object.c | 1 + 2 files changed, 2 insertions(+) diff --git a/NEWS b/NEWS index 0905761da01..49370da6143 100644 --- a/NEWS +++ b/NEWS @@ -17,6 +17,7 @@ PHP NEWS - Phar: . Fix memory leak of argument in webPhar. (nielsdos) + . Fix memory leak when setAlias() fails. (nielsdos) - Random: . Fix Randomizer::__serialize() w.r.t. INDIRECTs. (nielsdos) diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c index abda7e5a78c..b8577701359 100644 --- a/ext/phar/phar_object.c +++ b/ext/phar/phar_object.c @@ -2770,6 +2770,7 @@ valid_alias: phar_flush(phar_obj->archive, NULL, 0, 0, &error); if (error) { + pefree(phar_obj->archive->alias, phar_obj->archive->is_persistent); phar_obj->archive->alias = oldalias; phar_obj->archive->alias_len = oldalias_len; phar_obj->archive->is_temporary_alias = old_temp;