From 35936bfa79e8972495190cc3cbf0dc60a53fdcea Mon Sep 17 00:00:00 2001 From: Ilija Tovilo Date: Tue, 22 Apr 2025 16:10:34 +0200 Subject: [PATCH 1/2] Drop tidyp from FreeBSD build It looks like it's no longer supported. We don't test tidy on FreeBSD anyway. --- .github/actions/freebsd/action.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/actions/freebsd/action.yml b/.github/actions/freebsd/action.yml index ce9ba244515..1f7c670f272 100644 --- a/.github/actions/freebsd/action.yml +++ b/.github/actions/freebsd/action.yml @@ -27,7 +27,6 @@ runs: bzip2 \ t1lib \ gmp \ - tidyp \ libsodium \ libzip \ libxml2 \ From 3fdd3ed9f722d9f0aa3122b2340a611db2dfa110 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 22 Apr 2025 19:58:10 +0100 Subject: [PATCH 2/2] backporting C++17 detection support for recent icu4c releases. --- ext/intl/config.m4 | 11 ++++++++- ext/intl/tests/bug62070_3.phpt | 1 + .../tests/collator_get_sort_key_variant7.phpt | 1 + ext/intl/tests/locale_get_display_name8.phpt | 24 +++++++++---------- .../tests/locale_get_display_variant2.phpt | 18 +++++++------- 5 files changed, 33 insertions(+), 22 deletions(-) diff --git a/ext/intl/config.m4 b/ext/intl/config.m4 index daadd3e73d8..27cd8b30155 100644 --- a/ext/intl/config.m4 +++ b/ext/intl/config.m4 @@ -85,7 +85,16 @@ if test "$PHP_INTL" != "no"; then breakiterator/codepointiterator_methods.cpp" PHP_REQUIRE_CXX() - PHP_CXX_COMPILE_STDCXX(11, mandatory, PHP_INTL_STDCXX) + + AC_MSG_CHECKING([if intl requires -std=gnu++17]) + AS_IF([$PKG_CONFIG icu-uc --atleast-version=74],[ + AC_MSG_RESULT([yes]) + PHP_CXX_COMPILE_STDCXX(17, mandatory, PHP_INTL_STDCXX) + ],[ + AC_MSG_RESULT([no]) + PHP_CXX_COMPILE_STDCXX(11, mandatory, PHP_INTL_STDCXX) + ]) + PHP_INTL_CXX_FLAGS="$INTL_COMMON_FLAGS $PHP_INTL_STDCXX $ICU_CXXFLAGS" case $host_alias in *cygwin*) PHP_INTL_CXX_FLAGS="$PHP_INTL_CXX_FLAGS -D_POSIX_C_SOURCE=200809L" diff --git a/ext/intl/tests/bug62070_3.phpt b/ext/intl/tests/bug62070_3.phpt index 08c1bbf45f8..60e0593acfd 100644 --- a/ext/intl/tests/bug62070_3.phpt +++ b/ext/intl/tests/bug62070_3.phpt @@ -4,6 +4,7 @@ Bug #62070: Collator::getSortKey() returns garbage intl --SKIPIF-- = 62.1'); ?> += 0) die('skip for ICU < 76.1'); ?> --FILE-- = 62.1 intl --SKIPIF-- = 62.1'); ?> += 0) die('skip for ICU < 76.1'); ?> --FILE--