From dc9adda653f8a85255994c99161d9fef59ae00bf Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sun, 9 Jul 2023 01:08:34 +0200 Subject: [PATCH] Fix return value of _php_server_push_callback in case of failure It should return CURL_PUSH_DENY by default instead of CURL_PUSH_OK in the branch I added, just like the check above. I forgot to change this after doing tests. --- ext/curl/multi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/curl/multi.c b/ext/curl/multi.c index 3fbfce9b518..2551334c1c8 100644 --- a/ext/curl/multi.c +++ b/ext/curl/multi.c @@ -384,7 +384,7 @@ static int _php_server_push_callback(CURL *parent_ch, CURL *easy, size_t num_hea if (UNEXPECTED(zend_fcall_info_init(&t->func_name, 0, &fci, &t->fci_cache, NULL, NULL) == FAILURE)) { php_error_docref(NULL, E_WARNING, "Cannot call the CURLMOPT_PUSHFUNCTION"); - return CURL_PUSH_OK; + return rval; } parent = Z_CURL_P(pz_parent_ch);