From 720e006982951ab6dba15f1138fa0903284f03ee Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+ndossche@users.noreply.github.com> Date: Tue, 4 Nov 2025 08:32:22 +0100 Subject: [PATCH] random: Fix memory leak when serialization fails (#20383) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tim Düsterhus --- ext/random/engine_mt19937.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/random/engine_mt19937.c b/ext/random/engine_mt19937.c index e16c9f6722f..a1a0d02b9de 100644 --- a/ext/random/engine_mt19937.c +++ b/ext/random/engine_mt19937.c @@ -329,11 +329,11 @@ PHP_METHOD(Random_Engine_Mt19937, __serialize) /* state */ array_init(&t); + zend_hash_next_index_insert(Z_ARRVAL_P(return_value), &t); if (!engine->algo->serialize(engine->status, Z_ARRVAL(t))) { zend_throw_exception(NULL, "Engine serialize failed", 0); RETURN_THROWS(); } - zend_hash_next_index_insert(Z_ARRVAL_P(return_value), &t); } /* }}} */