From 73f52dc7295aae9728b2e9c64ae6bec92030bc66 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sun, 5 Jan 2025 13:04:39 +0100 Subject: [PATCH] Remove custom free_obj handler in xmlwriter At one point this served a purpose as it contained the cleanup code that now lives in dtor, but now it just calls the standard handler so we can just get rid of it. --- ext/xmlwriter/php_xmlwriter.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/ext/xmlwriter/php_xmlwriter.c b/ext/xmlwriter/php_xmlwriter.c index 07542c06202..f9dd7f48c86 100644 --- a/ext/xmlwriter/php_xmlwriter.c +++ b/ext/xmlwriter/php_xmlwriter.c @@ -66,16 +66,6 @@ static void xmlwriter_object_dtor(zend_object *object) } /* }}} */ -/* {{{ xmlwriter_object_free_storage */ -static void xmlwriter_object_free_storage(zend_object *object) -{ - ze_xmlwriter_object *intern = php_xmlwriter_fetch_object(object); - - zend_object_std_dtor(&intern->std); -} -/* }}} */ - - /* {{{ xmlwriter_object_new */ static zend_object *xmlwriter_object_new(zend_class_entry *class_type) { @@ -1064,7 +1054,6 @@ static PHP_MINIT_FUNCTION(xmlwriter) memcpy(&xmlwriter_object_handlers, &std_object_handlers, sizeof(zend_object_handlers)); xmlwriter_object_handlers.offset = XtOffsetOf(ze_xmlwriter_object, std); xmlwriter_object_handlers.dtor_obj = xmlwriter_object_dtor; - xmlwriter_object_handlers.free_obj = xmlwriter_object_free_storage; xmlwriter_object_handlers.clone_obj = NULL; xmlwriter_class_entry_ce = register_class_XMLWriter(); xmlwriter_class_entry_ce->create_object = xmlwriter_object_new;