From 7278364f9c28348ccf372e57856dc3ba6c46fac9 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Tue, 28 May 2024 22:59:37 +0200 Subject: [PATCH] Remove useless RETURN_NULLs() (#14350) These functions are void, their use of RETURN_NULL() was mildly confusing. --- ext/dom/element.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ext/dom/element.c b/ext/dom/element.c index 348c669e1b4..ccc116eaaf3 100644 --- a/ext/dom/element.c +++ b/ext/dom/element.c @@ -1318,8 +1318,6 @@ PHP_METHOD(DOMElement, setIdAttribute) } else { php_set_attribute_id(attrp, is_id); } - - RETURN_NULL(); } /* }}} end dom_element_set_id_attribute */ @@ -1349,8 +1347,6 @@ PHP_METHOD(DOMElement, setIdAttributeNS) } else { php_set_attribute_id(attrp, is_id); } - - RETURN_NULL(); } /* }}} end dom_element_set_id_attribute_ns */ @@ -1378,8 +1374,6 @@ static void dom_element_set_id_attribute_node(INTERNAL_FUNCTION_PARAMETERS, zend } else { php_set_attribute_id(attrp, is_id); } - - RETURN_NULL(); } PHP_METHOD(DOMElement, setIdAttributeNode)