From 6a51062c857a7635e92a444f81e80056f43eaaac Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Thu, 22 Aug 2024 14:56:32 +0200 Subject: [PATCH] Drop unused, but confusing macro definition (GH-15541) `PHP7DLLTS_EXPORTS` is not used throughout php-src, and it's unlikely that it is used by any extension, especially since it still refers to PHP 7. The symbol had been introduced in 2014[1], but is not even used in latest PHP-7.4; probably it was just supposed to be used, or part of phpng. [1] Since CI already ran for the PR, we can now [skip ci]. --- win32/build/confutils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win32/build/confutils.js b/win32/build/confutils.js index 47fca332a34..95a4e5ce3c1 100644 --- a/win32/build/confutils.js +++ b/win32/build/confutils.js @@ -3241,7 +3241,7 @@ function toolset_setup_common_cflags() var envCFLAGS = WshShell.Environment("PROCESS").Item("CFLAGS"); // CFLAGS for building the PHP dll - DEFINE("CFLAGS_PHP", "/D _USRDLL /D PHP7DLLTS_EXPORTS /D PHP_EXPORTS \ + DEFINE("CFLAGS_PHP", "/D _USRDLL /D PHP_EXPORTS \ /D LIBZEND_EXPORTS /D TSRM_EXPORTS /D SAPI_EXPORTS /D WINVER=" + WINVER); DEFINE('CFLAGS_PHP_OBJ', '$(CFLAGS_PHP) $(STATIC_EXT_CFLAGS)');