From 68b904884b5dca7e217aaed77852f7308c1140e7 Mon Sep 17 00:00:00 2001
From: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Date: Sun, 20 Apr 2025 02:31:15 +0200
Subject: [PATCH] Factor out duplicated code

---
 ext/intl/idn/idn.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/ext/intl/idn/idn.c b/ext/intl/idn/idn.c
index a0ea0795bf5..cd4546ad7f8 100644
--- a/ext/intl/idn/idn.c
+++ b/ext/intl/idn/idn.c
@@ -57,6 +57,7 @@ static void php_intl_idn_to_46(INTERNAL_FUNCTION_PARAMETERS,
 	UErrorCode	  status = U_ZERO_ERROR;
 	UIDNA		  *uts46;
 	int32_t		  len;
+	int32_t       buffer_capac;
 	zend_string	  *buffer;
 	UIDNAInfo	  info = UIDNA_INFO_INITIALIZER;
 
@@ -66,25 +67,20 @@ static void php_intl_idn_to_46(INTERNAL_FUNCTION_PARAMETERS,
 	}
 
 	if (mode == INTL_IDN_TO_ASCII) {
-		const int32_t buffer_capac = 255;
+		buffer_capac = 255;
 		buffer = zend_string_alloc(buffer_capac, 0);
 		len = uidna_nameToASCII_UTF8(uts46, ZSTR_VAL(domain), ZSTR_LEN(domain),
 				ZSTR_VAL(buffer), buffer_capac, &info, &status);
-		if (len >= buffer_capac || php_intl_idn_check_status(status, "failed to convert name") == FAILURE) {
-			uidna_close(uts46);
-			zend_string_efree(buffer);
-			RETURN_FALSE;
-		}
 	} else {
-		const int32_t buffer_capac = 252*4;
+		buffer_capac = 252*4;
 		buffer = zend_string_alloc(buffer_capac, 0);
 		len = uidna_nameToUnicodeUTF8(uts46, ZSTR_VAL(domain), ZSTR_LEN(domain),
 				ZSTR_VAL(buffer), buffer_capac, &info, &status);
-		if (len >= buffer_capac || php_intl_idn_check_status(status, "failed to convert name") == FAILURE) {
-			uidna_close(uts46);
-			zend_string_efree(buffer);
-			RETURN_FALSE;
-		}
+	}
+	if (len >= buffer_capac || php_intl_idn_check_status(status, "failed to convert name") == FAILURE) {
+		uidna_close(uts46);
+		zend_string_efree(buffer);
+		RETURN_FALSE;
 	}
 
 	ZSTR_VAL(buffer)[len] = '\0';