From 5f3e6e346c574bdcd564119e19828ff3204e3ee5 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Fri, 27 Sep 2024 19:08:13 +0200 Subject: [PATCH] Fix failing soap tests on Windows These failures are caused by the fix for GHSA-p99j-rfp4-xqvq. Since the two bug*.phpt tests don't need the "wsdl" query string, and don't even need php-cgi, we just remove the `--GET--` section. The two server*.phpt tests are harder to fix, since during evaluation of the `--SKIPIF--` section, the soap extension can be loaded, but it may not during evaluation of the `--FILE--` section. So for now, we skip these tests on Windows altogether. Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Closes GH-16084. --- ext/soap/tests/bugs/bug27722.phpt | 2 -- ext/soap/tests/bugs/bug27742.phpt | 2 -- ext/soap/tests/server011.phpt | 6 ++++++ ext/soap/tests/server012.phpt | 6 ++++++ 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ext/soap/tests/bugs/bug27722.phpt b/ext/soap/tests/bugs/bug27722.phpt index 3315b714018..1bfc2fe6ee3 100644 --- a/ext/soap/tests/bugs/bug27722.phpt +++ b/ext/soap/tests/bugs/bug27722.phpt @@ -2,8 +2,6 @@ Bug #27722 (Segfault on schema without targetNamespace) --EXTENSIONS-- soap ---GET-- -wsdl --INI-- soap.wsdl_cache_enabled=0 --FILE-- diff --git a/ext/soap/tests/bugs/bug27742.phpt b/ext/soap/tests/bugs/bug27742.phpt index 02b27dc0144..1c7c8fc09f7 100644 --- a/ext/soap/tests/bugs/bug27742.phpt +++ b/ext/soap/tests/bugs/bug27742.phpt @@ -2,8 +2,6 @@ Bug #27742 (WDSL SOAP Parsing Schema bug) --EXTENSIONS-- soap ---GET-- -wsdl --INI-- soap.wsdl_cache_enabled=0 --FILE-- diff --git a/ext/soap/tests/server011.phpt b/ext/soap/tests/server011.phpt index ad4a626c790..f236ec3affc 100644 --- a/ext/soap/tests/server011.phpt +++ b/ext/soap/tests/server011.phpt @@ -1,5 +1,11 @@ --TEST-- SOAP Server 11: bind +--SKIPIF-- + --EXTENSIONS-- soap --GET-- diff --git a/ext/soap/tests/server012.phpt b/ext/soap/tests/server012.phpt index 230108e2b92..703aefbaa78 100644 --- a/ext/soap/tests/server012.phpt +++ b/ext/soap/tests/server012.phpt @@ -1,5 +1,11 @@ --TEST-- SOAP Server 12: WSDL generation +--SKIPIF-- + --EXTENSIONS-- soap --GET--